* [PATCH v2 1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
@ 2022-07-08 18:25 ` William Zhang
0 siblings, 0 replies; 14+ messages in thread
From: William Zhang @ 2022-07-08 18:25 UTC (permalink / raw)
To: Linux ARM List
Cc: Broadcom Kernel List, William Zhang, Florian Fainelli,
Krzysztof Kozlowski, Rafał Miłecki, Rob Herring,
devicetree, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1286 bytes --]
The cpu mask value in interrupt property inherits from bcm4908.dtsi
which sets to four cpus. Correct the value to two cpus for dual core
BCM4906 SoC.
Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906
Netgear R8000P DTS files")
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- Split into two patches and add fix reference
arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi
index 66023d553524..d084c33d5ca8 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906.dtsi
@@ -9,6 +9,14 @@ cpus {
/delete-node/ cpu@3;
};
+ timer {
+ compatible = "arm,armv8-timer";
+ interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
+ };
+
pmu {
compatible = "arm,cortex-a53-pmu";
interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>,
--
2.34.1
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 2/2] arm64: dts: broadcom: bcm4908: Fix cpu node for smp boot
2022-07-08 18:25 ` William Zhang
@ 2022-07-08 18:25 ` William Zhang
-1 siblings, 0 replies; 14+ messages in thread
From: William Zhang @ 2022-07-08 18:25 UTC (permalink / raw)
To: Linux ARM List
Cc: Broadcom Kernel List, William Zhang, Florian Fainelli,
Krzysztof Kozlowski, Rafał Miłecki, Rob Herring,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]
Add spin-table enable-method and cpu-release-addr properties for
cpu0 node. This is required by all ARMv8 SoC. Otherwise some
bootloader like u-boot can not update cpu-release-addr and linux
fails to start up secondary cpus.
Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus
GT-AC5300 early DTS files")
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- Split into two patches and add fix reference
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index a4be040a00c0..967d2cd3c3ce 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -29,6 +29,8 @@ cpu0: cpu@0 {
device_type = "cpu";
compatible = "brcm,brahma-b53";
reg = <0x0>;
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0xfff8>;
next-level-cache = <&l2>;
};
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 2/2] arm64: dts: broadcom: bcm4908: Fix cpu node for smp boot
@ 2022-07-08 18:25 ` William Zhang
0 siblings, 0 replies; 14+ messages in thread
From: William Zhang @ 2022-07-08 18:25 UTC (permalink / raw)
To: Linux ARM List
Cc: Broadcom Kernel List, William Zhang, Florian Fainelli,
Krzysztof Kozlowski, Rafał Miłecki, Rob Herring,
devicetree, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1090 bytes --]
Add spin-table enable-method and cpu-release-addr properties for
cpu0 node. This is required by all ARMv8 SoC. Otherwise some
bootloader like u-boot can not update cpu-release-addr and linux
fails to start up secondary cpus.
Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus
GT-AC5300 early DTS files")
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- Split into two patches and add fix reference
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
index a4be040a00c0..967d2cd3c3ce 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
@@ -29,6 +29,8 @@ cpu0: cpu@0 {
device_type = "cpu";
compatible = "brcm,brahma-b53";
reg = <0x0>;
+ enable-method = "spin-table";
+ cpu-release-addr = <0x0 0xfff8>;
next-level-cache = <&l2>;
};
--
2.34.1
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 2/2] arm64: dts: broadcom: bcm4908: Fix cpu node for smp boot
2022-07-08 18:25 ` William Zhang
@ 2022-07-08 19:45 ` Florian Fainelli
-1 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2022-07-08 19:45 UTC (permalink / raw)
To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
Cc: Krzysztof Kozlowski, Rafał Miłecki, Rob Herring,
devicetree, linux-kernel
On Fri, 8 Jul 2022 11:25:07 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Add spin-table enable-method and cpu-release-addr properties for
> cpu0 node. This is required by all ARMv8 SoC. Otherwise some
> bootloader like u-boot can not update cpu-release-addr and linux
> fails to start up secondary cpus.
>
> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus
> GT-AC5300 early DTS files")
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree-arm64/fixes, thanks!
--
Florian
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 2/2] arm64: dts: broadcom: bcm4908: Fix cpu node for smp boot
@ 2022-07-08 19:45 ` Florian Fainelli
0 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2022-07-08 19:45 UTC (permalink / raw)
To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
Cc: Krzysztof Kozlowski, Rafał Miłecki, Rob Herring,
devicetree, linux-kernel
On Fri, 8 Jul 2022 11:25:07 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Add spin-table enable-method and cpu-release-addr properties for
> cpu0 node. This is required by all ARMv8 SoC. Otherwise some
> bootloader like u-boot can not update cpu-release-addr and linux
> fails to start up secondary cpus.
>
> Fixes: 2961f69f151c ("arm64: dts: broadcom: add BCM4908 and Asus
> GT-AC5300 early DTS files")
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree-arm64/fixes, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
2022-07-08 18:25 ` William Zhang
@ 2022-07-08 19:45 ` Florian Fainelli
-1 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2022-07-08 19:45 UTC (permalink / raw)
To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
Cc: Krzysztof Kozlowski, Rafał Miłecki, Rob Herring,
devicetree, linux-kernel
On Fri, 8 Jul 2022 11:25:06 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> The cpu mask value in interrupt property inherits from bcm4908.dtsi
> which sets to four cpus. Correct the value to two cpus for dual core
> BCM4906 SoC.
>
> Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906
> Netgear R8000P DTS files")
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree-arm64/fixes, thanks!
--
Florian
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
@ 2022-07-08 19:45 ` Florian Fainelli
0 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2022-07-08 19:45 UTC (permalink / raw)
To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
Cc: Krzysztof Kozlowski, Rafał Miłecki, Rob Herring,
devicetree, linux-kernel
On Fri, 8 Jul 2022 11:25:06 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> The cpu mask value in interrupt property inherits from bcm4908.dtsi
> which sets to four cpus. Correct the value to two cpus for dual core
> BCM4906 SoC.
>
> Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906
> Netgear R8000P DTS files")
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree-arm64/fixes, thanks!
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
2022-07-08 18:25 ` William Zhang
@ 2022-07-13 6:47 ` Rafał Miłecki
-1 siblings, 0 replies; 14+ messages in thread
From: Rafał Miłecki @ 2022-07-13 6:47 UTC (permalink / raw)
To: William Zhang
Cc: Linux ARM List, Broadcom Kernel List, Florian Fainelli,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel
On 2022-07-08 20:25, William Zhang wrote:
> The cpu mask value in interrupt property inherits from bcm4908.dtsi
> which sets to four cpus. Correct the value to two cpus for dual core
> BCM4906 SoC.
>
> Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906
> Netgear R8000P DTS files")
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Both look good, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
@ 2022-07-13 6:47 ` Rafał Miłecki
0 siblings, 0 replies; 14+ messages in thread
From: Rafał Miłecki @ 2022-07-13 6:47 UTC (permalink / raw)
To: William Zhang
Cc: Linux ARM List, Broadcom Kernel List, Florian Fainelli,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel
On 2022-07-08 20:25, William Zhang wrote:
> The cpu mask value in interrupt property inherits from bcm4908.dtsi
> which sets to four cpus. Correct the value to two cpus for dual core
> BCM4906 SoC.
>
> Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906
> Netgear R8000P DTS files")
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Both look good, thanks!
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
2022-07-08 18:25 ` William Zhang
@ 2022-07-13 6:49 ` Rafał Miłecki
-1 siblings, 0 replies; 14+ messages in thread
From: Rafał Miłecki @ 2022-07-13 6:49 UTC (permalink / raw)
To: William Zhang
Cc: Linux ARM List, Broadcom Kernel List, Florian Fainelli,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel
On 2022-07-08 20:25, William Zhang wrote:
> The cpu mask value in interrupt property inherits from bcm4908.dtsi
> which sets to four cpus. Correct the value to two cpus for dual core
> BCM4906 SoC.
>
> Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906
> Netgear R8000P DTS files")
Well, one note. You shouldn't line break Fixes: line.
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
@ 2022-07-13 6:49 ` Rafał Miłecki
0 siblings, 0 replies; 14+ messages in thread
From: Rafał Miłecki @ 2022-07-13 6:49 UTC (permalink / raw)
To: William Zhang
Cc: Linux ARM List, Broadcom Kernel List, Florian Fainelli,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel
On 2022-07-08 20:25, William Zhang wrote:
> The cpu mask value in interrupt property inherits from bcm4908.dtsi
> which sets to four cpus. Correct the value to two cpus for dual core
> BCM4906 SoC.
>
> Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906
> Netgear R8000P DTS files")
Well, one note. You shouldn't line break Fixes: line.
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
2022-07-13 6:49 ` Rafał Miłecki
@ 2022-07-13 16:29 ` Florian Fainelli
-1 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2022-07-13 16:29 UTC (permalink / raw)
To: Rafał Miłecki, William Zhang
Cc: Linux ARM List, Broadcom Kernel List, Florian Fainelli,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel
On 7/12/22 23:49, Rafał Miłecki wrote:
> On 2022-07-08 20:25, William Zhang wrote:
>> The cpu mask value in interrupt property inherits from bcm4908.dtsi
>> which sets to four cpus. Correct the value to two cpus for dual core
>> BCM4906 SoC.
>>
>> Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906
>> Netgear R8000P DTS files")
>
> Well, one note. You shouldn't line break Fixes: line.
Took care of that before applying the two patches:
https://github.com/torvalds/linux/commit/b4a544e415e9be33b37d9bfa9d9f9f4d13f553d6
https://github.com/torvalds/linux/commit/8bd582ae9a71d7f14c4e0c735b2eacaf7516d626
--
Florian
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 1/2] arm64: dts: broadcom: bcm4908: Fix timer node for BCM4906 SoC
@ 2022-07-13 16:29 ` Florian Fainelli
0 siblings, 0 replies; 14+ messages in thread
From: Florian Fainelli @ 2022-07-13 16:29 UTC (permalink / raw)
To: Rafał Miłecki, William Zhang
Cc: Linux ARM List, Broadcom Kernel List, Florian Fainelli,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel
On 7/12/22 23:49, Rafał Miłecki wrote:
> On 2022-07-08 20:25, William Zhang wrote:
>> The cpu mask value in interrupt property inherits from bcm4908.dtsi
>> which sets to four cpus. Correct the value to two cpus for dual core
>> BCM4906 SoC.
>>
>> Fixes: c8b404fb05dc ("arm64: dts: broadcom: bcm4908: add BCM4906
>> Netgear R8000P DTS files")
>
> Well, one note. You shouldn't line break Fixes: line.
Took care of that before applying the two patches:
https://github.com/torvalds/linux/commit/b4a544e415e9be33b37d9bfa9d9f9f4d13f553d6
https://github.com/torvalds/linux/commit/8bd582ae9a71d7f14c4e0c735b2eacaf7516d626
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread