* [PATCH] xen/build: remove unneeded enumeration in clean-files
@ 2022-07-11 10:58 Juergen Gross
2022-07-11 16:36 ` Anthony PERARD
0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2022-07-11 10:58 UTC (permalink / raw)
To: xen-devel
Cc: Juergen Gross, Andrew Cooper, George Dunlap, Jan Beulich,
Julien Grall, Stefano Stabellini, Wei Liu, Anthony Perard
Enumerating a file from $(targets) in $(clean-files) isn't needed.
Remove xen/include/xen/hypercall-defs.h from $(clean-files).
Reported-by: Jan Beulich <jbeulich@suse.com>
Fixes: eca1f00d0227 ("xen: generate hypercall interface related code")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
xen/include/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/Makefile b/xen/include/Makefile
index 39d9f5556c..fa0d454ab7 100644
--- a/xen/include/Makefile
+++ b/xen/include/Makefile
@@ -225,4 +225,4 @@ all: lib-x86-all
endif
clean-files := compat config generated headers*.chk xen/lib/x86/cpuid-autogen.h
-clean-files += xen/hypercall-defs.h hypercall-defs.i
+clean-files += hypercall-defs.i
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/build: remove unneeded enumeration in clean-files
2022-07-11 10:58 [PATCH] xen/build: remove unneeded enumeration in clean-files Juergen Gross
@ 2022-07-11 16:36 ` Anthony PERARD
0 siblings, 0 replies; 2+ messages in thread
From: Anthony PERARD @ 2022-07-11 16:36 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, Andrew Cooper, George Dunlap, Jan Beulich,
Julien Grall, Stefano Stabellini, Wei Liu
On Mon, Jul 11, 2022 at 12:58:40PM +0200, Juergen Gross wrote:
> Enumerating a file from $(targets) in $(clean-files) isn't needed.
>
> Remove xen/include/xen/hypercall-defs.h from $(clean-files).
>
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Fixes: eca1f00d0227 ("xen: generate hypercall interface related code")
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> xen/include/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/Makefile b/xen/include/Makefile
> index 39d9f5556c..fa0d454ab7 100644
> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -225,4 +225,4 @@ all: lib-x86-all
> endif
>
> clean-files := compat config generated headers*.chk xen/lib/x86/cpuid-autogen.h
> -clean-files += xen/hypercall-defs.h hypercall-defs.i
> +clean-files += hypercall-defs.i
The patch title is a bit too broad and only correct a recent patch. It
doesn't really matter I think if `rm -f` tries to remove the same file
twice, but maybe this patch should actually do what it is explained in
the description ;-).
There is also "headers*.chk" that is listed in both $(targets) and
$(clean-files) which could be unlisted from the latter as well.
Thanks,
--
Anthony PERARD
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-11 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-11 10:58 [PATCH] xen/build: remove unneeded enumeration in clean-files Juergen Gross
2022-07-11 16:36 ` Anthony PERARD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.