* [PATCH v1 0/2] add npcm750 function config and dts node
@ 2022-07-12 9:24 Jim Liu
2022-07-12 9:24 ` [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750 Jim Liu
2022-07-12 9:24 ` [PATCH v1 2/2] ARM: dts: npcm7xx: add npcm750 full function node Jim Liu
0 siblings, 2 replies; 10+ messages in thread
From: Jim Liu @ 2022-07-12 9:24 UTC (permalink / raw)
To: trini, JJLIU0, YSCHU, KWLIU; +Cc: u-boot
Add Nuvoton BMC npcm750 function config and dts node
Jim Liu (2):
ARM: configs: npcm7xx: add full function for nuvoton npcm750
ARM: dts: npcm7xx: add npcm750 full function node
arch/arm/dts/nuvoton-common-npcm7xx.dtsi | 3 +
arch/arm/dts/nuvoton-npcm750-evb.dts | 63 ++++-
arch/arm/dts/nuvoton-npcm750.dtsi | 1 +
arch/arm/dts/nuvoton-npcm7xx-u-boot.dtsi | 287 +++++++++++++++++++++++
configs/poleg_evb_defconfig | 55 +++++
5 files changed, 398 insertions(+), 11 deletions(-)
create mode 100644 arch/arm/dts/nuvoton-npcm7xx-u-boot.dtsi
--
2.17.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750
2022-07-12 9:24 [PATCH v1 0/2] add npcm750 function config and dts node Jim Liu
@ 2022-07-12 9:24 ` Jim Liu
2022-07-25 16:59 ` Tom Rini
2022-07-12 9:24 ` [PATCH v1 2/2] ARM: dts: npcm7xx: add npcm750 full function node Jim Liu
1 sibling, 1 reply; 10+ messages in thread
From: Jim Liu @ 2022-07-12 9:24 UTC (permalink / raw)
To: trini, JJLIU0, YSCHU, KWLIU; +Cc: u-boot
Add add full function config for nuvoton npcm750
Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
---
configs/poleg_evb_defconfig | 55 +++++++++++++++++++++++++++++++++++++
1 file changed, 55 insertions(+)
diff --git a/configs/poleg_evb_defconfig b/configs/poleg_evb_defconfig
index 16f6215148..ae463fd5d3 100644
--- a/configs/poleg_evb_defconfig
+++ b/configs/poleg_evb_defconfig
@@ -21,24 +21,79 @@ CONFIG_SYS_PROMPT="U-Boot>"
CONFIG_SYS_MAXARGS=32
CONFIG_SYS_CBSIZE=256
CONFIG_SYS_PBSIZE=280
+CONFIG_CMD_FUSE=y
CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
CONFIG_CMD_SPI=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_USB_MASS_STORAGE=y
+CONFIG_CMD_WDT=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
CONFIG_CMD_CACHE=y
+CONFIG_CMD_RNG=y
CONFIG_CMD_UUID=y
+CONFIG_CMD_HASH=y
+CONFIG_CMD_FAT=y
CONFIG_ENV_OVERWRITE=y
CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_REGMAP=y
+CONFIG_SYSCON=y
CONFIG_CLK=y
+CONFIG_NPCM_AES=y
+CONFIG_NPCM_SHA=y
+CONFIG_NPCM_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_NPCM=y
+CONFIG_MISC=y
+CONFIG_NPCM_HOST=y
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_NPCM=y
CONFIG_DM_SPI_FLASH=y
CONFIG_SPI_FLASH_MACRONIX=y
CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_PHY_BROADCOM=y
+CONFIG_PHY_FIXED=y
CONFIG_DM_ETH=y
+CONFIG_PHY_GIGE=y
+CONFIG_ETH_DESIGNWARE=y
+CONFIG_NET_NPCM750=y
+CONFIG_RGMII=y
+CONFIG_MII=y
+CONFIG_PHY=y
+CONFIG_PHY_NPCM_USB=y
CONFIG_PINCTRL=y
CONFIG_PINCONF=y
+CONFIG_PINCTRL_NPCM7XX=y
+CONFIG_DM_RESET=y
+CONFIG_DM_RNG=y
+CONFIG_RNG_NPCM=y
CONFIG_DM_SERIAL=y
CONFIG_NPCM_SERIAL=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
+CONFIG_NPCM_FIU_SPI=y
+CONFIG_NPCM_PSPI=y
CONFIG_SYSRESET=y
CONFIG_SYSRESET_WATCHDOG=y
CONFIG_TIMER=y
CONFIG_NPCM_TIMER=y
+CONFIG_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_NPCM=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_NPCM=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_MANUFACTURER="Nuvoton"
+CONFIG_USB_GADGET_VENDOR_NUM=0x0416
+CONFIG_USB_GADGET_PRODUCT_NUM=0xffff
+CONFIG_CI_UDC=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+# CONFIG_WATCHDOG is not set
+CONFIG_WDT_NPCM=y
+CONFIG_LIB_HW_RAND=y
+CONFIG_SHA_HW_ACCEL=y
+CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS=1
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v1 2/2] ARM: dts: npcm7xx: add npcm750 full function node
2022-07-12 9:24 [PATCH v1 0/2] add npcm750 function config and dts node Jim Liu
2022-07-12 9:24 ` [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750 Jim Liu
@ 2022-07-12 9:24 ` Jim Liu
2022-08-04 20:51 ` Tom Rini
1 sibling, 1 reply; 10+ messages in thread
From: Jim Liu @ 2022-07-12 9:24 UTC (permalink / raw)
To: trini, JJLIU0, YSCHU, KWLIU; +Cc: u-boot
add npcm750 BMC full function node
Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
---
arch/arm/dts/nuvoton-common-npcm7xx.dtsi | 3 +
arch/arm/dts/nuvoton-npcm750-evb.dts | 63 ++++-
arch/arm/dts/nuvoton-npcm750.dtsi | 1 +
arch/arm/dts/nuvoton-npcm7xx-u-boot.dtsi | 287 +++++++++++++++++++++++
4 files changed, 343 insertions(+), 11 deletions(-)
create mode 100644 arch/arm/dts/nuvoton-npcm7xx-u-boot.dtsi
diff --git a/arch/arm/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/dts/nuvoton-common-npcm7xx.dtsi
index 02ee4d78e2..feb88872fc 100644
--- a/arch/arm/dts/nuvoton-common-npcm7xx.dtsi
+++ b/arch/arm/dts/nuvoton-common-npcm7xx.dtsi
@@ -559,6 +559,9 @@
#size-cells = <1>;
compatible = "nuvoton,npcm750-pinctrl", "syscon", "simple-mfd";
ranges = <0 0xf0010000 0x8000>;
+ reg = <0xf0010000 0x8000>;
+ syscon-gcr = <&gcr>;
+ syscon-rst = <&rst>;
gpio0: gpio@f0010000 {
gpio-controller;
#gpio-cells = <2>;
diff --git a/arch/arm/dts/nuvoton-npcm750-evb.dts b/arch/arm/dts/nuvoton-npcm750-evb.dts
index 3e4abe6610..d4667a1df4 100644
--- a/arch/arm/dts/nuvoton-npcm750-evb.dts
+++ b/arch/arm/dts/nuvoton-npcm750-evb.dts
@@ -12,8 +12,8 @@
compatible = "nuvoton,npcm750-evb", "nuvoton,npcm750";
aliases {
- ethernet2 = &gmac0;
- ethernet3 = &gmac1;
+ eth0 = &emc0;
+ eth1 = &gmac0;
serial0 = &serial0;
serial1 = &serial1;
serial2 = &serial2;
@@ -34,11 +34,11 @@
i2c13 = &i2c13;
i2c14 = &i2c14;
i2c15 = &i2c15;
- spi0 = &spi0;
- spi1 = &spi1;
- fiu0 = &fiu0;
- fiu1 = &fiu3;
- fiu2 = &fiux;
+ spi0 = &fiu0;
+ spi1 = &fiu3;
+ spi2 = &fiux;
+ spi3 = &spi0;
+ spi4 = &spi1;
};
chosen {
@@ -51,18 +51,20 @@
};
};
-&gmac0 {
- phy-mode = "rgmii-id";
+&udc0 {
status = "okay";
+ phys = <&usbphy1 0>;
};
-&gmac1 {
+&gmac0 {
phy-mode = "rgmii-id";
+ snps,eee-force-disable;
status = "okay";
};
&ehci1 {
status = "okay";
+ phys = <&usbphy2 3>;
};
&fiu0 {
@@ -151,7 +153,7 @@
spix-mode;
};
-&watchdog1 {
+&watchdog0 {
status = "okay";
};
@@ -159,6 +161,14 @@
status = "okay";
};
+&sha {
+ status = "okay";
+};
+
+&aes {
+ status = "okay";
+};
+
&serial0 {
status = "okay";
clock-frequency = <24000000>;
@@ -403,3 +413,34 @@
&pin255_input>;
};
+&ehci1 {
+ status = "okay";
+ phys = <&usbphy2 3>;
+};
+
+&otp {
+ status = "okay";
+};
+
+&usbphy1 {
+ status = "okay";
+};
+
+&usbphy2 {
+ status = "okay";
+};
+
+&emc0 {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&r1_pins
+ &r1err_pins>;
+ fixed-link {
+ speed = <100>;
+ full-dulpex;
+ };
+};
+
+&sdhci0 {
+ status = "okay";
+};
diff --git a/arch/arm/dts/nuvoton-npcm750.dtsi b/arch/arm/dts/nuvoton-npcm750.dtsi
index 13eee0fe56..c286353832 100644
--- a/arch/arm/dts/nuvoton-npcm750.dtsi
+++ b/arch/arm/dts/nuvoton-npcm750.dtsi
@@ -3,6 +3,7 @@
// Copyright 2018 Google, Inc.
#include "nuvoton-common-npcm7xx.dtsi"
+#include "nuvoton-npcm7xx-u-boot.dtsi"
/ {
#address-cells = <1>;
diff --git a/arch/arm/dts/nuvoton-npcm7xx-u-boot.dtsi b/arch/arm/dts/nuvoton-npcm7xx-u-boot.dtsi
new file mode 100644
index 0000000000..c547e433e7
--- /dev/null
+++ b/arch/arm/dts/nuvoton-npcm7xx-u-boot.dtsi
@@ -0,0 +1,287 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/ {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ interrupt-parent = <&gic>;
+
+ wdt-reboot {
+ compatible = "wdt-reboot";
+ wdt = <&watchdog0>;
+ };
+
+ ahb {
+ udc0:udc@f0830100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0830100 0x200
+ 0xfffd0000 0x800>;
+ interrupts = <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
+ resets = <&rstc NPCM7XX_RESET_IPSRST3 NPCM7XX_RESET_UDC0>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ udc1:udc@f0831100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0831100 0x200
+ 0xfffd0800 0x800>;
+ interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ udc2: udc@f0832100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0832100 0x200
+ 0xfffd1000 0x800>;
+ interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ udc3: udc@f0833100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0833100 0x200
+ 0xfffd1800 0x800>;
+ interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ udc4: udc@f0834100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0834100 0x200
+ 0xfffd2000 0x800>;
+ interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ udc5: udc@f0835100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0835100 0x200
+ 0xfffd2800 0x800>;
+ interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ udc6: udc@f0836100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0836100 0x200
+ 0xfffd3000 0x800>;
+ interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ udc7: udc@f0837100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0837100 0x200
+ 0xfffd3800 0x800>;
+ interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ udc8: udc@f0838100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0838100 0x200
+ 0xfffd4000 0x800>;
+ interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ udc9: udc@f0839100 {
+ compatible = "nuvoton,npcm750-udc";
+ reg = <0xf0839100 0x200
+ 0xfffd4800 0x800>;
+ interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_SU>;
+ clock-names = "clk_usb_bridge";
+ };
+
+ emc0: eth@f0825000 {
+ device_type = "network";
+ compatible = "nuvoton,npcm750-emc";
+ reg = <0xf0825000 0x1000>;
+ phy-mode = "rmii";
+ id = <0>;
+ syscon-gcr = <&gcr>;
+ interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk NPCM7XX_CLK_AHB>;
+ clock-names = "clk_emc";
+ resets = <&rstc NPCM7XX_RESET_IPSRST1 NPCM7XX_RESET_EMC1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&r1_pins
+ &r1md_pins>;
+ status = "disabled";
+ };
+
+ ohci1: ohci@f0807000 {
+ compatible = "nuvoton,npcm750-ohci";
+ reg = <0xf0807000 0x1000>;
+ interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+ resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_USB_HOST>;
+ status = "disabled";
+ };
+
+ usbphy {
+ compatible = "simple-bus", "nuvoton,npcm750-usb-phy";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ syscon = <&gcr>;
+ usbphy1: usbphy1 {
+ compatible = "nuvoton,npcm750-usb-phy";
+ #phy-cells = <1>;
+ reg = <1>;
+ resets = <&rstc NPCM7XX_RESET_IPSRST3 NPCM7XX_RESET_USB_PHY_1>;
+ status = "disabled";
+ };
+ usbphy2: usbphy2 {
+ compatible = "nuvoton,npcm750-usb-phy";
+ #phy-cells = <1>;
+ reg = <2>;
+ resets =<&rstc NPCM7XX_RESET_IPSRST3 NPCM7XX_RESET_USB_PHY_2>;
+ status = "disabled";
+ };
+ };
+
+ sdhci0: sdhci0@f0842000 {
+ compatible = "nuvoton,npcm750-sdhci";
+ reg = <0xf0842000 0x200>;
+ index = <0x0>;
+ bus-width = <0x8>;
+ cap-mmc-highspeed;
+ interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk NPCM7XX_CLK_SDHC>;
+ clock-frequency = <50000000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&mmc_pins
+ &mmc8_pins>;
+ status = "disabled";
+ };
+
+ sdhci1: sdhci1@f0840000 {
+ compatible = "nuvoton,npcm750-sdhci";
+ reg = <0xf0840000 0x2000>;
+ index = <0x1>;
+ bus-width = <0x4>;
+ cap-mmc-highspeed;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sd1_pins>;
+ status = "disabled";
+ };
+
+ aes: aes@f0858000 {
+ compatible = "nuvoton,npcm750-aes";
+ reg = <0xf0858000 0x1000>;
+ clocks = <&clk NPCM7XX_CLK_AHB>;
+ clock-names = "clk_ahb";
+ status = "disabled";
+ };
+
+ sha: sha@f085a000 {
+ compatible = "nuvoton,npcm750-sha";
+ reg = <0xf085a000 0x1000>;
+ clocks = <&clk NPCM7XX_CLK_AHB>;
+ clock-names = "clk_ahb";
+ status = "disabled";
+ };
+
+ //ehci1
+ usb@f0806000 {
+ resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_USB_HOST>;
+ };
+
+ apb {
+ otp:otp@189000 {
+ compatible = "nuvoton,npcm750-otp";
+ reg = <0x189000 0x1000
+ 0x18a000 0x1000>;
+ status = "disabled";
+ clocks = <&clk NPCM7XX_CLK_APB4>;
+ clock-names = "clk_apb4";
+ };
+
+ rng@b000 {
+ clocks = <&clk NPCM7XX_CLK_APB1>;
+ };
+ gpio_0: gpio0@10000 {
+ compatible = "nuvoton,npcm-gpio";
+ reg = <0x10000 0xB0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-bank-name = "gpio0";
+ };
+
+ gpio_1: gpio1@11000 {
+ compatible = "nuvoton,npcm-gpio";
+ reg = <0x11000 0xB0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-bank-name = "gpio1";
+ };
+
+ gpio_2: gpio2@12000 {
+ compatible = "nuvoton,npcm-gpio";
+ reg = <0x12000 0xB0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-bank-name = "gpio2";
+ };
+ gpio_3: gpio3@13000 {
+ compatible = "nuvoton,npcm-gpio";
+ reg = <0x13000 0xB0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-bank-name = "gpio3";
+ };
+
+ gpio_4: gpio4@14000 {
+ compatible = "nuvoton,npcm-gpio";
+ reg = <0x14000 0xB0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-bank-name = "gpio4";
+ };
+
+ gpio_5: gpio5@15000 {
+ compatible = "nuvoton,npcm-gpio";
+ reg = <0x15000 0xB0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-bank-name = "gpio5";
+ };
+
+ gpio_6: gpio6@16000 {
+ compatible = "nuvoton,npcm-gpio";
+ reg = <0x16000 0xB0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-bank-name = "gpio6";
+ };
+ gpio_7: gpio7@17000 {
+ compatible = "nuvoton,npcm-gpio";
+ reg = <0x17000 0xB0>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-bank-name = "gpio7";
+ };
+
+ };
+ };
+};
+
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750
2022-07-12 9:24 ` [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750 Jim Liu
@ 2022-07-25 16:59 ` Tom Rini
2022-08-02 2:54 ` Jim Liu
0 siblings, 1 reply; 10+ messages in thread
From: Tom Rini @ 2022-07-25 16:59 UTC (permalink / raw)
To: Jim Liu; +Cc: JJLIU0, YSCHU, KWLIU, u-boot
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
On Tue, Jul 12, 2022 at 05:24:06PM +0800, Jim Liu wrote:
> Add add full function config for nuvoton npcm750
>
> Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
Does the i2c driver need to be reposted? This patch causes the platform
to fail to build as the i2c driver file is missing.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750
2022-07-25 16:59 ` Tom Rini
@ 2022-08-02 2:54 ` Jim Liu
2022-08-02 12:09 ` Tom Rini
0 siblings, 1 reply; 10+ messages in thread
From: Jim Liu @ 2022-08-02 2:54 UTC (permalink / raw)
To: Tom Rini; +Cc: JJLIU0, YSCHU, KWLIU, u-boot
Hi Tom
Thanks for your review.
My i2c driver status is Awaiting Upstream.
Is this the reason for the failure?
What should I do to fix this build error?
Any comments are most welcome!
Best regards,
Jim
On Tue, Jul 26, 2022 at 12:59 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Tue, Jul 12, 2022 at 05:24:06PM +0800, Jim Liu wrote:
>
> > Add add full function config for nuvoton npcm750
> >
> > Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
>
> Does the i2c driver need to be reposted? This patch causes the platform
> to fail to build as the i2c driver file is missing.
>
> --
> Tom
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750
2022-08-02 2:54 ` Jim Liu
@ 2022-08-02 12:09 ` Tom Rini
2022-08-02 12:28 ` Jim Liu
0 siblings, 1 reply; 10+ messages in thread
From: Tom Rini @ 2022-08-02 12:09 UTC (permalink / raw)
To: Jim Liu, Heiko Schocher; +Cc: JJLIU0, YSCHU, KWLIU, u-boot
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Tue, Aug 02, 2022 at 10:54:33AM +0800, Jim Liu wrote:
> Hi Tom
>
> Thanks for your review.
> My i2c driver status is Awaiting Upstream.
> Is this the reason for the failure?
> What should I do to fix this build error?
>
> Any comments are most welcome!
Heiko?
>
>
> Best regards,
> Jim
>
> On Tue, Jul 26, 2022 at 12:59 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Jul 12, 2022 at 05:24:06PM +0800, Jim Liu wrote:
> >
> > > Add add full function config for nuvoton npcm750
> > >
> > > Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
> >
> > Does the i2c driver need to be reposted? This patch causes the platform
> > to fail to build as the i2c driver file is missing.
> >
> > --
> > Tom
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750
2022-08-02 12:09 ` Tom Rini
@ 2022-08-02 12:28 ` Jim Liu
2023-01-09 3:00 ` Jim Liu
0 siblings, 1 reply; 10+ messages in thread
From: Jim Liu @ 2022-08-02 12:28 UTC (permalink / raw)
To: Tom Rini; +Cc: Heiko Schocher, JJLIU0, KWLIU, YSCHU, u-boot
Hi Tom
Yes , the link is as below
https://patchwork.ozlabs.org/project/uboot/patch/20220623053142.6659-1-JJLIU0@nuvoton.com/
Best regards,
Jim
Tom Rini <trini@konsulko.com>於 2022年8月2日 週二，下午8:09寫道：
> On Tue, Aug 02, 2022 at 10:54:33AM +0800, Jim Liu wrote:
> > Hi Tom
> >
> > Thanks for your review.
> > My i2c driver status is Awaiting Upstream.
> > Is this the reason for the failure?
> > What should I do to fix this build error?
> >
> > Any comments are most welcome!
>
> Heiko?
>
> >
> >
> > Best regards,
> > Jim
> >
> > On Tue, Jul 26, 2022 at 12:59 AM Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Tue, Jul 12, 2022 at 05:24:06PM +0800, Jim Liu wrote:
> > >
> > > > Add add full function config for nuvoton npcm750
> > > >
> > > > Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
> > >
> > > Does the i2c driver need to be reposted? This patch causes the
> platform
> > > to fail to build as the i2c driver file is missing.
> > >
> > > --
> > > Tom
>
> --
> Tom
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 2/2] ARM: dts: npcm7xx: add npcm750 full function node
2022-07-12 9:24 ` [PATCH v1 2/2] ARM: dts: npcm7xx: add npcm750 full function node Jim Liu
@ 2022-08-04 20:51 ` Tom Rini
0 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2022-08-04 20:51 UTC (permalink / raw)
To: Jim Liu; +Cc: JJLIU0, YSCHU, KWLIU, u-boot
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
On Tue, Jul 12, 2022 at 05:24:07PM +0800, Jim Liu wrote:
> add npcm750 BMC full function node
>
> Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750
2022-08-02 12:28 ` Jim Liu
@ 2023-01-09 3:00 ` Jim Liu
2023-01-09 14:17 ` Tom Rini
0 siblings, 1 reply; 10+ messages in thread
From: Jim Liu @ 2023-01-09 3:00 UTC (permalink / raw)
To: Tom Rini; +Cc: Heiko Schocher, JJLIU0, KWLIU, YSCHU, u-boot
Hi Tom
I push some patches to fix some errors about this config patch and
wait for all reviewers to merge.
Could you check this patch again or should I use new master uboot
update patch and resend it ?
Best regards,
Jim
On Tue, Aug 2, 2022 at 8:28 PM Jim Liu <jim.t90615@gmail.com> wrote:
>
> Hi Tom
>
> Yes , the link is as below
>
> https://patchwork.ozlabs.org/project/uboot/patch/20220623053142.6659-1-JJLIU0@nuvoton.com/
>
> Best regards,
> Jim
>
>
> Tom Rini <trini@konsulko.com>於 2022年8月2日 週二，下午8:09寫道：
>>
>> On Tue, Aug 02, 2022 at 10:54:33AM +0800, Jim Liu wrote:
>> > Hi Tom
>> >
>> > Thanks for your review.
>> > My i2c driver status is Awaiting Upstream.
>> > Is this the reason for the failure?
>> > What should I do to fix this build error?
>> >
>> > Any comments are most welcome!
>>
>> Heiko?
>>
>> >
>> >
>> > Best regards,
>> > Jim
>> >
>> > On Tue, Jul 26, 2022 at 12:59 AM Tom Rini <trini@konsulko.com> wrote:
>> > >
>> > > On Tue, Jul 12, 2022 at 05:24:06PM +0800, Jim Liu wrote:
>> > >
>> > > > Add add full function config for nuvoton npcm750
>> > > >
>> > > > Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
>> > >
>> > > Does the i2c driver need to be reposted? This patch causes the platform
>> > > to fail to build as the i2c driver file is missing.
>> > >
>> > > --
>> > > Tom
>>
>> --
>> Tom
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750
2023-01-09 3:00 ` Jim Liu
@ 2023-01-09 14:17 ` Tom Rini
0 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2023-01-09 14:17 UTC (permalink / raw)
To: Jim Liu; +Cc: Heiko Schocher, JJLIU0, KWLIU, YSCHU, u-boot
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]
On Mon, Jan 09, 2023 at 11:00:41AM +0800, Jim Liu wrote:
> Hi Tom
>
> I push some patches to fix some errors about this config patch and
> wait for all reviewers to merge.
> Could you check this patch again or should I use new master uboot
> update patch and resend it ?
Please re-post, built and tested, on top of the master branch, once I
release v2023.01 later today, and then merge the next branch in. Thanks!
>
> Best regards,
> Jim
>
> On Tue, Aug 2, 2022 at 8:28 PM Jim Liu <jim.t90615@gmail.com> wrote:
> >
> > Hi Tom
> >
> > Yes , the link is as below
> >
> > https://patchwork.ozlabs.org/project/uboot/patch/20220623053142.6659-1-JJLIU0@nuvoton.com/
> >
> > Best regards,
> > Jim
> >
> >
> > Tom Rini <trini@konsulko.com>於 2022年8月2日 週二，下午8:09寫道：
> >>
> >> On Tue, Aug 02, 2022 at 10:54:33AM +0800, Jim Liu wrote:
> >> > Hi Tom
> >> >
> >> > Thanks for your review.
> >> > My i2c driver status is Awaiting Upstream.
> >> > Is this the reason for the failure?
> >> > What should I do to fix this build error?
> >> >
> >> > Any comments are most welcome!
> >>
> >> Heiko?
> >>
> >> >
> >> >
> >> > Best regards,
> >> > Jim
> >> >
> >> > On Tue, Jul 26, 2022 at 12:59 AM Tom Rini <trini@konsulko.com> wrote:
> >> > >
> >> > > On Tue, Jul 12, 2022 at 05:24:06PM +0800, Jim Liu wrote:
> >> > >
> >> > > > Add add full function config for nuvoton npcm750
> >> > > >
> >> > > > Signed-off-by: Jim Liu <JJLIU0@nuvoton.com>
> >> > >
> >> > > Does the i2c driver need to be reposted? This patch causes the platform
> >> > > to fail to build as the i2c driver file is missing.
> >> > >
> >> > > --
> >> > > Tom
> >>
> >> --
> >> Tom
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-09 14:17 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 9:24 [PATCH v1 0/2] add npcm750 function config and dts node Jim Liu
2022-07-12 9:24 ` [PATCH v1 1/2] ARM: configs: npcm7xx: add full function for nuvoton npcm750 Jim Liu
2022-07-25 16:59 ` Tom Rini
2022-08-02 2:54 ` Jim Liu
2022-08-02 12:09 ` Tom Rini
2022-08-02 12:28 ` Jim Liu
2023-01-09 3:00 ` Jim Liu
2023-01-09 14:17 ` Tom Rini
2022-07-12 9:24 ` [PATCH v1 2/2] ARM: dts: npcm7xx: add npcm750 full function node Jim Liu
2022-08-04 20:51 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.