* [PATCH] arm64: dts: qcom: sc8280xp: add missing apps_smmu irq
@ 2022-07-12 8:01 Parikshit Pareek
2022-07-12 12:00 ` Andrew Halaney
2022-07-12 12:10 ` Dmitry Baryshkov
0 siblings, 2 replies; 4+ messages in thread
From: Parikshit Pareek @ 2022-07-12 8:01 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson
Cc: Sai Prakash Ranjan, Rajendra Nayak, Prasanna Kumar,
linux-arm-msm, Parikshit Pareek
Add missing irq number 696, and correct the interrupt-mapping of context banks.
Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 7945cbb57bb4..1197d60c2827 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -1591,6 +1591,7 @@
<GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: add missing apps_smmu irq
2022-07-12 8:01 [PATCH] arm64: dts: qcom: sc8280xp: add missing apps_smmu irq Parikshit Pareek
@ 2022-07-12 12:00 ` Andrew Halaney
2022-07-12 12:10 ` Dmitry Baryshkov
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Halaney @ 2022-07-12 12:00 UTC (permalink / raw)
To: Parikshit Pareek
Cc: Andy Gross, Bjorn Andersson, Sai Prakash Ranjan, Rajendra Nayak,
Prasanna Kumar, linux-arm-msm
On Tue, Jul 12, 2022 at 01:31:56PM +0530, Parikshit Pareek wrote:
> Add missing irq number 696, and correct the interrupt-mapping of context banks.
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 7945cbb57bb4..1197d60c2827 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1591,6 +1591,7 @@
> <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1
>
Looks good to me, thanks!
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: add missing apps_smmu irq
2022-07-12 8:01 [PATCH] arm64: dts: qcom: sc8280xp: add missing apps_smmu irq Parikshit Pareek
2022-07-12 12:00 ` Andrew Halaney
@ 2022-07-12 12:10 ` Dmitry Baryshkov
2022-07-12 12:28 ` Andrew Halaney
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-07-12 12:10 UTC (permalink / raw)
To: Parikshit Pareek
Cc: Andy Gross, Bjorn Andersson, Sai Prakash Ranjan, Rajendra Nayak,
Prasanna Kumar, linux-arm-msm
On Tue, 12 Jul 2022 at 11:02, Parikshit Pareek <quic_ppareek@quicinc.com> wrote:
>
> Add missing irq number 696, and correct the interrupt-mapping of context banks.
If these two patches touch the same device (and the same interrupts
property), it might be better to merge them into the single patch.
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 7945cbb57bb4..1197d60c2827 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1591,6 +1591,7 @@
> <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc8280xp: add missing apps_smmu irq
2022-07-12 12:10 ` Dmitry Baryshkov
@ 2022-07-12 12:28 ` Andrew Halaney
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Halaney @ 2022-07-12 12:28 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Parikshit Pareek, Andy Gross, Bjorn Andersson,
Sai Prakash Ranjan, Rajendra Nayak, Prasanna Kumar,
linux-arm-msm
On Tue, Jul 12, 2022 at 03:10:16PM +0300, Dmitry Baryshkov wrote:
> On Tue, 12 Jul 2022 at 11:02, Parikshit Pareek <quic_ppareek@quicinc.com> wrote:
> >
> > Add missing irq number 696, and correct the interrupt-mapping of context banks.
>
> If these two patches touch the same device (and the same interrupts
> property), it might be better to merge them into the single patch.
>
Heh, I mislead Parikshit into splitting them... sorry!
> >
> > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> > ---
> > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > index 7945cbb57bb4..1197d60c2827 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > @@ -1591,6 +1591,7 @@
> > <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,
> > --
> > 2.17.1
> >
>
>
> --
> With best wishes
> Dmitry
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-12 12:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 8:01 [PATCH] arm64: dts: qcom: sc8280xp: add missing apps_smmu irq Parikshit Pareek
2022-07-12 12:00 ` Andrew Halaney
2022-07-12 12:10 ` Dmitry Baryshkov
2022-07-12 12:28 ` Andrew Halaney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.