* [PATCH] btrfs: slience the sparse warn of rcu_string
@ 2022-07-14 1:11 Wang Yugui
2022-07-14 7:15 ` Johannes Thumshirn
2022-07-14 8:00 ` Wang Yugui
0 siblings, 2 replies; 3+ messages in thread
From: Wang Yugui @ 2022-07-14 1:11 UTC (permalink / raw)
To: linux-btrfs; +Cc: Wang Yugui
slience the sparse warn of rcu_string reported by 'make C=1'
Signed-off-by: Wang Yugui <wangyugui@e16-tech.com>
---
fs/btrfs/dev-replace.c | 2 +-
fs/btrfs/volumes.c | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index f43196a893ca..25b94e0e433f 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@ -1007,7 +1007,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
btrfs_sysfs_update_devid(tgt_device);
if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &src_device->dev_state))
btrfs_scratch_superblocks(fs_info, src_device->bdev,
- src_device->name->str);
+ rcu_str_deref(src_device->name));
/* write back the superblocks */
trans = btrfs_start_transaction(root, 0);
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index bf4e140f6bfc..e9f62c9c3db5 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -398,7 +398,7 @@ static struct btrfs_fs_devices *alloc_fs_devices(const u8 *fsid,
void btrfs_free_device(struct btrfs_device *device)
{
WARN_ON(!list_empty(&device->post_commit_list));
- rcu_string_free(device->name);
+ rcu_string_free(rcu_dereference(device->name));
extent_io_tree_release(&device->alloc_state);
btrfs_destroy_dev_zone_info(device);
kfree(device);
@@ -606,7 +606,7 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
if (!device->name)
return -EINVAL;
- ret = btrfs_get_bdev_and_sb(device->name->str, flags, holder, 1,
+ ret = btrfs_get_bdev_and_sb(rcu_str_deref(device->name), flags, holder, 1,
&bdev, &disk_super);
if (ret)
return ret;
@@ -873,7 +873,7 @@ static noinline struct btrfs_device *device_list_add(const char *path,
disk_super->fsid, devid, found_transid, path,
current->comm, task_pid_nr(current));
- } else if (!device->name || strcmp(device->name->str, path)) {
+ } else if (!device->name || strcmp(rcu_str_deref(device->name), path)) {
/*
* When FS is already mounted.
* 1. If you are here and if the device->name is NULL that
@@ -943,7 +943,7 @@ static noinline struct btrfs_device *device_list_add(const char *path,
mutex_unlock(&fs_devices->device_list_mutex);
return ERR_PTR(-ENOMEM);
}
- rcu_string_free(device->name);
+ rcu_string_free(rcu_dereference(device->name));
rcu_assign_pointer(device->name, name);
if (test_bit(BTRFS_DEV_STATE_MISSING, &device->dev_state)) {
fs_devices->missing_devices--;
@@ -1000,7 +1000,7 @@ static struct btrfs_fs_devices *clone_fs_devices(struct btrfs_fs_devices *orig)
* uuid mutex so nothing we touch in here is going to disappear.
*/
if (orig_dev->name) {
- name = rcu_string_strdup(orig_dev->name->str,
+ name = rcu_string_strdup(rcu_str_deref(orig_dev->name),
GFP_KERNEL);
if (!name) {
btrfs_free_device(device);
@@ -2182,7 +2182,7 @@ int btrfs_rm_device(struct btrfs_fs_info *fs_info,
*/
if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state)) {
btrfs_scratch_superblocks(fs_info, device->bdev,
- device->name->str);
+ rcu_str_deref(device->name));
if (device->bdev) {
sync_blockdev(device->bdev);
invalidate_bdev(device->bdev);
@@ -2297,7 +2297,7 @@ void btrfs_destroy_dev_replace_tgtdev(struct btrfs_device *tgtdev)
mutex_unlock(&fs_devices->device_list_mutex);
btrfs_scratch_superblocks(tgtdev->fs_info, tgtdev->bdev,
- tgtdev->name->str);
+ rcu_str_deref(tgtdev->name));
btrfs_close_bdev(tgtdev);
synchronize_rcu();
--
2.36.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: slience the sparse warn of rcu_string
2022-07-14 1:11 [PATCH] btrfs: slience the sparse warn of rcu_string Wang Yugui
@ 2022-07-14 7:15 ` Johannes Thumshirn
2022-07-14 8:00 ` Wang Yugui
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2022-07-14 7:15 UTC (permalink / raw)
To: Wang Yugui, linux-btrfs
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: slience the sparse warn of rcu_string
2022-07-14 1:11 [PATCH] btrfs: slience the sparse warn of rcu_string Wang Yugui
2022-07-14 7:15 ` Johannes Thumshirn
@ 2022-07-14 8:00 ` Wang Yugui
1 sibling, 0 replies; 3+ messages in thread
From: Wang Yugui @ 2022-07-14 8:00 UTC (permalink / raw)
To: linux-btrfs; +Cc: Wang Yugui
Hi,
A warn example could be added to changelog.
warn example:
fs/btrfs/volumes.c:2300:41: warning: incorrect type in argument 3 (different address spaces)
fs/btrfs/volumes.c:2300:41: expected char const *device_path
fs/btrfs/volumes.c:2300:41: got char [noderef] __rcu *
Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2022/07/14
> slience the sparse warn of rcu_string reported by 'make C=1'
>
> Signed-off-by: Wang Yugui <wangyugui@e16-tech.com>
> ---
> fs/btrfs/dev-replace.c | 2 +-
> fs/btrfs/volumes.c | 14 +++++++-------
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index f43196a893ca..25b94e0e433f 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -1007,7 +1007,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
> btrfs_sysfs_update_devid(tgt_device);
> if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &src_device->dev_state))
> btrfs_scratch_superblocks(fs_info, src_device->bdev,
> - src_device->name->str);
> + rcu_str_deref(src_device->name));
>
> /* write back the superblocks */
> trans = btrfs_start_transaction(root, 0);
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index bf4e140f6bfc..e9f62c9c3db5 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -398,7 +398,7 @@ static struct btrfs_fs_devices *alloc_fs_devices(const u8 *fsid,
> void btrfs_free_device(struct btrfs_device *device)
> {
> WARN_ON(!list_empty(&device->post_commit_list));
> - rcu_string_free(device->name);
> + rcu_string_free(rcu_dereference(device->name));
> extent_io_tree_release(&device->alloc_state);
> btrfs_destroy_dev_zone_info(device);
> kfree(device);
> @@ -606,7 +606,7 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
> if (!device->name)
> return -EINVAL;
>
> - ret = btrfs_get_bdev_and_sb(device->name->str, flags, holder, 1,
> + ret = btrfs_get_bdev_and_sb(rcu_str_deref(device->name), flags, holder, 1,
> &bdev, &disk_super);
> if (ret)
> return ret;
> @@ -873,7 +873,7 @@ static noinline struct btrfs_device *device_list_add(const char *path,
> disk_super->fsid, devid, found_transid, path,
> current->comm, task_pid_nr(current));
>
> - } else if (!device->name || strcmp(device->name->str, path)) {
> + } else if (!device->name || strcmp(rcu_str_deref(device->name), path)) {
> /*
> * When FS is already mounted.
> * 1. If you are here and if the device->name is NULL that
> @@ -943,7 +943,7 @@ static noinline struct btrfs_device *device_list_add(const char *path,
> mutex_unlock(&fs_devices->device_list_mutex);
> return ERR_PTR(-ENOMEM);
> }
> - rcu_string_free(device->name);
> + rcu_string_free(rcu_dereference(device->name));
> rcu_assign_pointer(device->name, name);
> if (test_bit(BTRFS_DEV_STATE_MISSING, &device->dev_state)) {
> fs_devices->missing_devices--;
> @@ -1000,7 +1000,7 @@ static struct btrfs_fs_devices *clone_fs_devices(struct btrfs_fs_devices *orig)
> * uuid mutex so nothing we touch in here is going to disappear.
> */
> if (orig_dev->name) {
> - name = rcu_string_strdup(orig_dev->name->str,
> + name = rcu_string_strdup(rcu_str_deref(orig_dev->name),
> GFP_KERNEL);
> if (!name) {
> btrfs_free_device(device);
> @@ -2182,7 +2182,7 @@ int btrfs_rm_device(struct btrfs_fs_info *fs_info,
> */
> if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state)) {
> btrfs_scratch_superblocks(fs_info, device->bdev,
> - device->name->str);
> + rcu_str_deref(device->name));
> if (device->bdev) {
> sync_blockdev(device->bdev);
> invalidate_bdev(device->bdev);
> @@ -2297,7 +2297,7 @@ void btrfs_destroy_dev_replace_tgtdev(struct btrfs_device *tgtdev)
> mutex_unlock(&fs_devices->device_list_mutex);
>
> btrfs_scratch_superblocks(tgtdev->fs_info, tgtdev->bdev,
> - tgtdev->name->str);
> + rcu_str_deref(tgtdev->name));
>
> btrfs_close_bdev(tgtdev);
> synchronize_rcu();
> --
> 2.36.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-14 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14 1:11 [PATCH] btrfs: slience the sparse warn of rcu_string Wang Yugui
2022-07-14 7:15 ` Johannes Thumshirn
2022-07-14 8:00 ` Wang Yugui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.