All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rockchip: rk3308: fix same-as-spl boot order
@ 2022-07-14 14:18 John Keeping
  2022-07-14 16:23 ` Philipp Tomsich
  2022-08-27  3:24 ` Kever Yang
  0 siblings, 2 replies; 3+ messages in thread
From: John Keeping @ 2022-07-14 14:18 UTC (permalink / raw)
  To: u-boot; +Cc: John Keeping, Simon Glass, Philipp Tomsich, Kever Yang

Rockchip SoCs need the boot_devices array defined in order to map the
bootloader's value to a U-Boot device.  Implement this for rk3308.

Signed-off-by: John Keeping <john@metanate.com>
---
 arch/arm/mach-rockchip/rk3308/rk3308.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/mach-rockchip/rk3308/rk3308.c b/arch/arm/mach-rockchip/rk3308/rk3308.c
index 70fe0d0ac3..dd9109b7c3 100644
--- a/arch/arm/mach-rockchip/rk3308/rk3308.c
+++ b/arch/arm/mach-rockchip/rk3308/rk3308.c
@@ -8,6 +8,7 @@
 #include <asm/global_data.h>
 #include <asm/io.h>
 #include <asm/arch/grf_rk3308.h>
+#include <asm/arch-rockchip/bootrom.h>
 #include <asm/arch-rockchip/hardware.h>
 #include <asm/gpio.h>
 #include <debug_uart.h>
@@ -142,6 +143,11 @@ enum {
 
 #define GPIO0_A4	4
 
+const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1] = {
+	[BROM_BOOTSOURCE_EMMC] = "/mmc@ff490000",
+	[BROM_BOOTSOURCE_SD] = "/mmc@ff480000",
+};
+
 int rk_board_init(void)
 {
 	static struct rk3308_grf * const grf = (void *)GRF_BASE;
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] rockchip: rk3308: fix same-as-spl boot order
  2022-07-14 14:18 [PATCH] rockchip: rk3308: fix same-as-spl boot order John Keeping
@ 2022-07-14 16:23 ` Philipp Tomsich
  2022-08-27  3:24 ` Kever Yang
  1 sibling, 0 replies; 3+ messages in thread
From: Philipp Tomsich @ 2022-07-14 16:23 UTC (permalink / raw)
  To: John Keeping; +Cc: u-boot, Simon Glass, Kever Yang

On Thu, 14 Jul 2022 at 16:18, John Keeping <john@metanate.com> wrote:
>
> Rockchip SoCs need the boot_devices array defined in order to map the
> bootloader's value to a U-Boot device.  Implement this for rk3308.
>
> Signed-off-by: John Keeping <john@metanate.com>

Reviewed-by: Philipp Tomsich <philipp.tomsich@vrull.eu>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] rockchip: rk3308: fix same-as-spl boot order
  2022-07-14 14:18 [PATCH] rockchip: rk3308: fix same-as-spl boot order John Keeping
  2022-07-14 16:23 ` Philipp Tomsich
@ 2022-08-27  3:24 ` Kever Yang
  1 sibling, 0 replies; 3+ messages in thread
From: Kever Yang @ 2022-08-27  3:24 UTC (permalink / raw)
  To: John Keeping, u-boot; +Cc: Simon Glass, Philipp Tomsich


On 2022/7/14 22:18, John Keeping wrote:
> Rockchip SoCs need the boot_devices array defined in order to map the
> bootloader's value to a U-Boot device.  Implement this for rk3308.
>
> Signed-off-by: John Keeping <john@metanate.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/mach-rockchip/rk3308/rk3308.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mach-rockchip/rk3308/rk3308.c b/arch/arm/mach-rockchip/rk3308/rk3308.c
> index 70fe0d0ac3..dd9109b7c3 100644
> --- a/arch/arm/mach-rockchip/rk3308/rk3308.c
> +++ b/arch/arm/mach-rockchip/rk3308/rk3308.c
> @@ -8,6 +8,7 @@
>   #include <asm/global_data.h>
>   #include <asm/io.h>
>   #include <asm/arch/grf_rk3308.h>
> +#include <asm/arch-rockchip/bootrom.h>
>   #include <asm/arch-rockchip/hardware.h>
>   #include <asm/gpio.h>
>   #include <debug_uart.h>
> @@ -142,6 +143,11 @@ enum {
>   
>   #define GPIO0_A4	4
>   
> +const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1] = {
> +	[BROM_BOOTSOURCE_EMMC] = "/mmc@ff490000",
> +	[BROM_BOOTSOURCE_SD] = "/mmc@ff480000",
> +};
> +
>   int rk_board_init(void)
>   {
>   	static struct rk3308_grf * const grf = (void *)GRF_BASE;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-08-27  3:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14 14:18 [PATCH] rockchip: rk3308: fix same-as-spl boot order John Keeping
2022-07-14 16:23 ` Philipp Tomsich
2022-08-27  3:24 ` Kever Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.