All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/mstpd: fix install path
@ 2022-07-09 15:55 Francois Perrad
  2022-07-09 19:14 ` Colin Foster
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Francois Perrad @ 2022-07-09 15:55 UTC (permalink / raw)
  To: buildroot

note: the current configuration works only if BR2_ROOTFS_MERGED_USR is enabled
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/mstpd/mstpd.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/mstpd/mstpd.mk b/package/mstpd/mstpd.mk
index 907d09424..22c91a639 100644
--- a/package/mstpd/mstpd.mk
+++ b/package/mstpd/mstpd.mk
@@ -10,4 +10,7 @@ MSTPD_AUTORECONF = YES
 MSTPD_LICENSE = GPL-2.0, RSA Data Security (md5)
 MSTPD_LICENSE_FILES = LICENSE hmac_md5.c
 
+# mstpd requires that it is installed into /sbin, not /usr/sbin
+MSTPD_CONF_OPTS = --sbindir=/sbin
+
 $(eval $(autotools-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/mstpd: fix install path
  2022-07-09 15:55 [Buildroot] [PATCH] package/mstpd: fix install path Francois Perrad
@ 2022-07-09 19:14 ` Colin Foster
  2022-07-18 10:20 ` Thomas Petazzoni via buildroot
  2022-08-10 15:29 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Colin Foster @ 2022-07-09 19:14 UTC (permalink / raw)
  To: Francois Perrad; +Cc: buildroot

On Sat, Jul 09, 2022 at 05:55:57PM +0200, Francois Perrad wrote:
> note: the current configuration works only if BR2_ROOTFS_MERGED_USR is enabled
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

If you use these:

Tested-by: Colin Foster <colin.foster@in-advantage.com>

I'll fix up MSTPD as well, since it is currently incompatible with
busybox `pidof` and we'll be off to the races!

> ---
>  package/mstpd/mstpd.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/mstpd/mstpd.mk b/package/mstpd/mstpd.mk
> index 907d09424..22c91a639 100644
> --- a/package/mstpd/mstpd.mk
> +++ b/package/mstpd/mstpd.mk
> @@ -10,4 +10,7 @@ MSTPD_AUTORECONF = YES
>  MSTPD_LICENSE = GPL-2.0, RSA Data Security (md5)
>  MSTPD_LICENSE_FILES = LICENSE hmac_md5.c
>  
> +# mstpd requires that it is installed into /sbin, not /usr/sbin
> +MSTPD_CONF_OPTS = --sbindir=/sbin
> +
>  $(eval $(autotools-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/mstpd: fix install path
  2022-07-09 15:55 [Buildroot] [PATCH] package/mstpd: fix install path Francois Perrad
  2022-07-09 19:14 ` Colin Foster
@ 2022-07-18 10:20 ` Thomas Petazzoni via buildroot
  2022-08-10 15:29 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-18 10:20 UTC (permalink / raw)
  To: Francois Perrad; +Cc: buildroot

On Sat,  9 Jul 2022 17:55:57 +0200
Francois Perrad <fperrad@gmail.com> wrote:

> note: the current configuration works only if BR2_ROOTFS_MERGED_USR is enabled
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/mstpd/mstpd.mk | 3 +++
>  1 file changed, 3 insertions(+)

Applied to master with an improved commit message and comment in the
.mk file.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/mstpd: fix install path
  2022-07-09 15:55 [Buildroot] [PATCH] package/mstpd: fix install path Francois Perrad
  2022-07-09 19:14 ` Colin Foster
  2022-07-18 10:20 ` Thomas Petazzoni via buildroot
@ 2022-08-10 15:29 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-08-10 15:29 UTC (permalink / raw)
  To: Francois Perrad; +Cc: buildroot

>>>>> "Francois" == Francois Perrad <fperrad@gmail.com> writes:

 > note: the current configuration works only if BR2_ROOTFS_MERGED_USR is enabled
 > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-08-10 15:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-09 15:55 [Buildroot] [PATCH] package/mstpd: fix install path Francois Perrad
2022-07-09 19:14 ` Colin Foster
2022-07-18 10:20 ` Thomas Petazzoni via buildroot
2022-08-10 15:29 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.