All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs-progs: fi show: Print missing device for a mounted file system
Date: Mon, 18 Jul 2022 17:59:17 +0200	[thread overview]
Message-ID: <20220718155917.GG13489@twin.jikos.cz> (raw)
In-Reply-To: <2e4435e8-3bfc-99b8-d474-247fd6c015d8@suse.com>

On Tue, Jun 07, 2022 at 11:35:45AM +0300, Nikolay Borisov wrote:
> 
> 
> On 29.03.22 г. 11:30 ч., Nikolay Borisov wrote:
> > Currently when a device is missing for a mounted filesystem the output
> > that is produced is unhelpful:
> > 
> > Label: none  uuid: 139ef309-021f-4b98-a3a8-ce230a83b1e2
> > 	Total devices 2 FS bytes used 128.00KiB
> > 	devid    1 size 5.00GiB used 1.26GiB path /dev/loop0
> > 	*** Some devices missing
> > 
> > While the context which prints this is perfectly capable of showing
> > which device exactly is missing, like so:
> > 
> > Label: none  uuid: 4a85a40b-9b79-4bde-8e52-c65a550a176b
> > 	Total devices 2 FS bytes used 128.00KiB
> > 	devid    1 size 5.00GiB used 1.26GiB path /dev/loop0
> > 	devid    2 size 0 used 0 path /dev/loop1 ***MISSING***
> > 
> > This is a lot more usable output as it presents the user with the id
> > of the missing device and its path.
> > 
> > Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> 
> 
> Ping

Sorry for late reponse, added to devel, thanks.

  reply	other threads:[~2022-07-18 16:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  8:30 [PATCH 1/2] btrfs-progs: fi show: Print missing device for a mounted file system Nikolay Borisov
2022-03-29  8:30 ` [PATCH 2/2] btrfs-progs: tests: Add test for fi show Nikolay Borisov
2022-07-18 16:04   ` David Sterba
2022-06-07  8:35 ` [PATCH 1/2] btrfs-progs: fi show: Print missing device for a mounted file system Nikolay Borisov
2022-07-18 15:59   ` David Sterba [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-09-02 10:06 Nikolay Borisov
2021-09-02 10:27 ` Qu Wenruo
2021-09-02 10:41   ` Nikolay Borisov
2021-09-02 10:46     ` Qu Wenruo
2021-09-02 10:59       ` Nikolay Borisov
2021-09-02 12:17         ` Qu Wenruo
2021-09-06 16:47           ` g.btrfs
2021-09-06 23:24             ` Anand Jain
2021-09-07  6:03             ` Nikolay Borisov
2021-09-07  8:59               ` Graham Cobb
2021-09-07  9:15                 ` Nikolay Borisov
2021-09-07 16:28             ` Goffredo Baroncelli
2021-09-02 11:44 ` Anand Jain
2021-09-02 14:28   ` Nikolay Borisov
2021-09-03  5:12     ` Anand Jain
2021-09-03  6:58       ` Nikolay Borisov
2021-09-07 13:50 ` David Sterba
2021-09-07 14:18   ` Nikolay Borisov
2021-09-08 11:17   ` Nikolay Borisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220718155917.GG13489@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.