From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs-progs: fi show: Print missing device for a mounted file system
Date: Fri, 3 Sep 2021 13:12:31 +0800 [thread overview]
Message-ID: <c3aa7db1-c3ca-2a26-2eaf-c975e2b0af54@oracle.com> (raw)
In-Reply-To: <44803fc4-8f7d-2bda-f7b3-06017f6d5b39@suse.com>
On 02/09/2021 22:28, Nikolay Borisov wrote:
>
>
> On 2.09.21 г. 14:44, Anand Jain wrote:
>> On 02/09/2021 18:06, Nikolay Borisov wrote:
>>> Currently when a device is missing for a mounted filesystem the output
>>> that is produced is unhelpful:
>>>
>>> Label: none uuid: 139ef309-021f-4b98-a3a8-ce230a83b1e2
>>> Total devices 2 FS bytes used 128.00KiB
>>> devid 1 size 5.00GiB used 1.26GiB path /dev/loop0
>>> *** Some devices missing
>>>
>>> While the context which prints this is perfectly capable of showing
>>> which device exactly is missing, like so:
>>>
>>> Label: none uuid: 4a85a40b-9b79-4bde-8e52-c65a550a176b
>>> Total devices 2 FS bytes used 128.00KiB
>>> devid 1 size 5.00GiB used 1.26GiB path /dev/loop0
>>> devid 2 size 0 used 0 path /dev/loop1 ***MISSING***
This change has to percolate to xfstests as well. I think btrfs/197,
btrfs/198 and btrfs/003 depends on the existing format. IMO those
test cases still have to be backward btrfs-progs compatible.
Thanks, Anand
>>>
>>> This is a lot more usable output as it presents the user with the id
>>> of the missing device and its path.
>>
>> Looks better. How does this fair in the case of unmounted btrfs? Because
>> btrfs fi show is supposed to work on an unmounted btrfs to help find
>> btrfs devices.
>
> On unmounted fs the output is unchanged - i.e we simply print "missing
> device" because there is no way to derive the name of the missing
> device. Check print_one_uuid for reference.
>
> <snip>
>
next prev parent reply other threads:[~2021-09-03 5:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 10:06 [PATCH 1/2] btrfs-progs: fi show: Print missing device for a mounted file system Nikolay Borisov
2021-09-02 10:06 ` [PATCH 2/2] btrfs-progs: tests: Add test for fi show Nikolay Borisov
2021-09-02 10:27 ` [PATCH 1/2] btrfs-progs: fi show: Print missing device for a mounted file system Qu Wenruo
2021-09-02 10:41 ` Nikolay Borisov
2021-09-02 10:46 ` Qu Wenruo
2021-09-02 10:59 ` Nikolay Borisov
2021-09-02 12:17 ` Qu Wenruo
2021-09-06 16:47 ` g.btrfs
2021-09-06 23:24 ` Anand Jain
2021-09-07 6:03 ` Nikolay Borisov
2021-09-07 8:59 ` Graham Cobb
2021-09-07 9:15 ` Nikolay Borisov
2021-09-07 16:28 ` Goffredo Baroncelli
2021-09-02 11:44 ` Anand Jain
2021-09-02 14:28 ` Nikolay Borisov
2021-09-03 5:12 ` Anand Jain [this message]
2021-09-03 6:58 ` Nikolay Borisov
2021-09-07 13:50 ` David Sterba
2021-09-07 14:18 ` Nikolay Borisov
2021-09-08 11:17 ` Nikolay Borisov
2022-03-29 8:30 Nikolay Borisov
2022-06-07 8:35 ` Nikolay Borisov
2022-07-18 15:59 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3aa7db1-c3ca-2a26-2eaf-c975e2b0af54@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.