* [PATCH v2 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
@ 2022-07-15 8:06 Alexander Stein
2022-07-18 21:50 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Stein @ 2022-07-15 8:06 UTC (permalink / raw)
To: Joakim Zhang, David S . Miller, Jakub Kicinski, Rob Herring
Cc: Alexander Stein, netdev, devicetree
These properties are inherited from ethernet-controller.yaml.
This fixes the dt_binding_check warning:
imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v2:
* Add amount and names of nvmem-cells (copied from ethernet-controller.yaml)
Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
index daa2f79a294f..b5b55dca08cb 100644
--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -121,6 +121,14 @@ properties:
mac-address: true
+ nvmem-cells:
+ maxItems: 1
+ description:
+ Reference to an nvmem node for the MAC address
+
+ nvmem-cell-names:
+ const: mac-address
+
tx-internal-delay-ps:
enum: [0, 2000]
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
2022-07-15 8:06 [PATCH v2 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties Alexander Stein
@ 2022-07-18 21:50 ` Rob Herring
2022-07-20 6:25 ` Re: [PATCH v2 1/1] dt-bindings: net: fsl, fec: " Alexander Stein
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-07-18 21:50 UTC (permalink / raw)
To: Alexander Stein
Cc: Joakim Zhang, David S . Miller, Jakub Kicinski, netdev, devicetree
On Fri, Jul 15, 2022 at 10:06:40AM +0200, Alexander Stein wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Add amount and names of nvmem-cells (copied from ethernet-controller.yaml)
>
> Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index daa2f79a294f..b5b55dca08cb 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -121,6 +121,14 @@ properties:
>
> mac-address: true
>
> + nvmem-cells:
> + maxItems: 1
> + description:
> + Reference to an nvmem node for the MAC address
> +
> + nvmem-cell-names:
> + const: mac-address
Sorry, steered you wrong on this. I didn't realize
ethernet-controller.yaml already defined these. You just need
'unevaluatedProperties: false' instead additionalProperties.
I'm not sure what the FIXME for the additionalProperties is all about
though.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH v2 1/1] dt-bindings: net: fsl, fec: Add nvmem-cells / nvmem-cell-names properties
2022-07-18 21:50 ` Rob Herring
@ 2022-07-20 6:25 ` Alexander Stein
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2022-07-20 6:25 UTC (permalink / raw)
To: Rob Herring
Cc: Joakim Zhang, David S . Miller, Jakub Kicinski, netdev, devicetree
Am Montag, 18. Juli 2022, 23:50:16 CEST schrieb Rob Herring:
> On Fri, Jul 15, 2022 at 10:06:40AM +0200, Alexander Stein wrote:
> > These properties are inherited from ethernet-controller.yaml.
> > This fixes the dt_binding_check warning:
> > imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> > 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Changes in v2:
> > * Add amount and names of nvmem-cells (copied from
> > ethernet-controller.yaml)>
> > Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > b/Documentation/devicetree/bindings/net/fsl,fec.yaml index
> > daa2f79a294f..b5b55dca08cb 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> >
> > @@ -121,6 +121,14 @@ properties:
> > mac-address: true
> >
> > + nvmem-cells:
> > + maxItems: 1
> > + description:
> > + Reference to an nvmem node for the MAC address
> > +
> > + nvmem-cell-names:
> > + const: mac-address
>
> Sorry, steered you wrong on this. I didn't realize
> ethernet-controller.yaml already defined these. You just need
> 'unevaluatedProperties: false' instead additionalProperties.
Ok, will come up with a new version.
> I'm not sure what the FIXME for the additionalProperties is all about
> though.
I guess this is about the deprecated properties (phy-reset-gpios, phy-reset-
duration, phy-reset-active-high, phy-reset-post-delay), which you can see in
the example. There is e.g. phy-reset-gpios and put to MAC node, but nowadays
this should be reset-gpios property in PHY node (see ethernet-phy.yaml)
Unfortunately you can't get rid of it until a single, common MDIO bus is
supported by multiple fec instances, see [1].
Best regards,
Alexander
[1] https://www.spinics.net/lists/kernel/msg4110563.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-20 6:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15 8:06 [PATCH v2 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties Alexander Stein
2022-07-18 21:50 ` Rob Herring
2022-07-20 6:25 ` Re: [PATCH v2 1/1] dt-bindings: net: fsl, fec: " Alexander Stein
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.