All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/char/hw_random/core.c:429:13: warning: use of uninitialized value '<unknown>' [CWE-457]
@ 2022-07-20 13:34 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-07-20 13:34 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5174 bytes --]

:::::: 
:::::: Manual check reason: "low confidence bisect report"
:::::: Manual check reason: "low confidence static check warning: drivers/char/hw_random/core.c:429:13: warning: use of uninitialized value '<unknown>' [CWE-457] [-Wanalyzer-use-of-uninitialized-value]"
:::::: 

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Dominik Brodowski <linux@dominikbrodowski.net>
CC: Herbert Xu <herbert@gondor.apana.org.au>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ca85855bdcae8f84f1512e88b4c75009ea17ea2f
commit: 8208285632f950d2bfd489b10148e05134b7119e hwrng: core - introduce rng_quality sysfs attribute
date:   5 months ago
:::::: branch date: 2 days ago
:::::: commit date: 5 months ago
config: arm-randconfig-c002-20220718 (https://download.01.org/0day-ci/archive/20220720/202207202141.uHkem5CH-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8208285632f950d2bfd489b10148e05134b7119e
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 8208285632f950d2bfd489b10148e05134b7119e
        # save the config file
         ARCH=arm KBUILD_USERCFLAGS='-fanalyzer -Wno-error' 

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>


gcc-analyzer warnings: (new ones prefixed by >>)
   drivers/char/hw_random/core.c: In function 'rng_quality_store':
>> drivers/char/hw_random/core.c:429:13: warning: use of uninitialized value '<unknown>' [CWE-457] [-Wanalyzer-use-of-uninitialized-value]
     429 |         u16 quality;
         |             ^~~~~~~
     'rng_quality_store': event 1
       |
       |  429 |         u16 quality;
       |      |             ^~~~~~~
       |      |             |
       |      |             (1) use of uninitialized value '<unknown>' here
       |

vim +429 drivers/char/hw_random/core.c

8208285632f950 Dominik Brodowski 2022-02-13  424  
8208285632f950 Dominik Brodowski 2022-02-13  425  static ssize_t rng_quality_store(struct device *dev,
8208285632f950 Dominik Brodowski 2022-02-13  426  				 struct device_attribute *attr,
8208285632f950 Dominik Brodowski 2022-02-13  427  				 const char *buf, size_t len)
8208285632f950 Dominik Brodowski 2022-02-13  428  {
8208285632f950 Dominik Brodowski 2022-02-13 @429  	u16 quality;
8208285632f950 Dominik Brodowski 2022-02-13  430  	int ret = -EINVAL;
8208285632f950 Dominik Brodowski 2022-02-13  431  
8208285632f950 Dominik Brodowski 2022-02-13  432  	if (len < 2)
8208285632f950 Dominik Brodowski 2022-02-13  433  		return -EINVAL;
8208285632f950 Dominik Brodowski 2022-02-13  434  
8208285632f950 Dominik Brodowski 2022-02-13  435  	ret = mutex_lock_interruptible(&rng_mutex);
8208285632f950 Dominik Brodowski 2022-02-13  436  	if (ret)
8208285632f950 Dominik Brodowski 2022-02-13  437  		return -ERESTARTSYS;
8208285632f950 Dominik Brodowski 2022-02-13  438  
8208285632f950 Dominik Brodowski 2022-02-13  439  	ret = kstrtou16(buf, 0, &quality);
8208285632f950 Dominik Brodowski 2022-02-13  440  	if (ret || quality > 1024) {
8208285632f950 Dominik Brodowski 2022-02-13  441  		ret = -EINVAL;
8208285632f950 Dominik Brodowski 2022-02-13  442  		goto out;
8208285632f950 Dominik Brodowski 2022-02-13  443  	}
8208285632f950 Dominik Brodowski 2022-02-13  444  
8208285632f950 Dominik Brodowski 2022-02-13  445  	if (!current_rng) {
8208285632f950 Dominik Brodowski 2022-02-13  446  		ret = -ENODEV;
8208285632f950 Dominik Brodowski 2022-02-13  447  		goto out;
8208285632f950 Dominik Brodowski 2022-02-13  448  	}
8208285632f950 Dominik Brodowski 2022-02-13  449  
8208285632f950 Dominik Brodowski 2022-02-13  450  	current_rng->quality = quality;
8208285632f950 Dominik Brodowski 2022-02-13  451  	current_quality = quality; /* obsolete */
8208285632f950 Dominik Brodowski 2022-02-13  452  
8208285632f950 Dominik Brodowski 2022-02-13  453  	/* the best available RNG may have changed */
8208285632f950 Dominik Brodowski 2022-02-13  454  	ret = enable_best_rng();
8208285632f950 Dominik Brodowski 2022-02-13  455  
8208285632f950 Dominik Brodowski 2022-02-13  456  	/* start/stop rngd if necessary */
8208285632f950 Dominik Brodowski 2022-02-13  457  	if (current_rng)
8208285632f950 Dominik Brodowski 2022-02-13  458  		hwrng_manage_rngd(current_rng);
8208285632f950 Dominik Brodowski 2022-02-13  459  
8208285632f950 Dominik Brodowski 2022-02-13  460  out:
8208285632f950 Dominik Brodowski 2022-02-13  461  	mutex_unlock(&rng_mutex);
8208285632f950 Dominik Brodowski 2022-02-13  462  	return ret ? ret : len;
8208285632f950 Dominik Brodowski 2022-02-13  463  }
8208285632f950 Dominik Brodowski 2022-02-13  464  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread
* drivers/char/hw_random/core.c:429:13: warning: use of uninitialized value '<unknown>' [CWE-457]
@ 2022-07-25 23:50 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-07-25 23:50 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5174 bytes --]

:::::: 
:::::: Manual check reason: "low confidence bisect report"
:::::: Manual check reason: "low confidence static check warning: drivers/char/hw_random/core.c:429:13: warning: use of uninitialized value '<unknown>' [CWE-457] [-Wanalyzer-use-of-uninitialized-value]"
:::::: 

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Dominik Brodowski <linux@dominikbrodowski.net>
CC: Herbert Xu <herbert@gondor.apana.org.au>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e0dccc3b76fb35bb257b4118367a883073d7390e
commit: 8208285632f950d2bfd489b10148e05134b7119e hwrng: core - introduce rng_quality sysfs attribute
date:   5 months ago
:::::: branch date: 27 hours ago
:::::: commit date: 5 months ago
config: arm-randconfig-c002-20220718 (https://download.01.org/0day-ci/archive/20220726/202207260740.IWjpDrEF-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8208285632f950d2bfd489b10148e05134b7119e
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 8208285632f950d2bfd489b10148e05134b7119e
        # save the config file
         ARCH=arm KBUILD_USERCFLAGS='-fanalyzer -Wno-error' 

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

gcc-analyzer warnings: (new ones prefixed by >>)
   drivers/char/hw_random/core.c: In function 'rng_quality_store':
>> drivers/char/hw_random/core.c:429:13: warning: use of uninitialized value '<unknown>' [CWE-457] [-Wanalyzer-use-of-uninitialized-value]
     429 |         u16 quality;
         |             ^~~~~~~
     'rng_quality_store': event 1
       |
       |  429 |         u16 quality;
       |      |             ^~~~~~~
       |      |             |
       |      |             (1) use of uninitialized value '<unknown>' here
       |

vim +429 drivers/char/hw_random/core.c

8208285632f950 Dominik Brodowski 2022-02-13  424  
8208285632f950 Dominik Brodowski 2022-02-13  425  static ssize_t rng_quality_store(struct device *dev,
8208285632f950 Dominik Brodowski 2022-02-13  426  				 struct device_attribute *attr,
8208285632f950 Dominik Brodowski 2022-02-13  427  				 const char *buf, size_t len)
8208285632f950 Dominik Brodowski 2022-02-13  428  {
8208285632f950 Dominik Brodowski 2022-02-13 @429  	u16 quality;
8208285632f950 Dominik Brodowski 2022-02-13  430  	int ret = -EINVAL;
8208285632f950 Dominik Brodowski 2022-02-13  431  
8208285632f950 Dominik Brodowski 2022-02-13  432  	if (len < 2)
8208285632f950 Dominik Brodowski 2022-02-13  433  		return -EINVAL;
8208285632f950 Dominik Brodowski 2022-02-13  434  
8208285632f950 Dominik Brodowski 2022-02-13  435  	ret = mutex_lock_interruptible(&rng_mutex);
8208285632f950 Dominik Brodowski 2022-02-13  436  	if (ret)
8208285632f950 Dominik Brodowski 2022-02-13  437  		return -ERESTARTSYS;
8208285632f950 Dominik Brodowski 2022-02-13  438  
8208285632f950 Dominik Brodowski 2022-02-13  439  	ret = kstrtou16(buf, 0, &quality);
8208285632f950 Dominik Brodowski 2022-02-13  440  	if (ret || quality > 1024) {
8208285632f950 Dominik Brodowski 2022-02-13  441  		ret = -EINVAL;
8208285632f950 Dominik Brodowski 2022-02-13  442  		goto out;
8208285632f950 Dominik Brodowski 2022-02-13  443  	}
8208285632f950 Dominik Brodowski 2022-02-13  444  
8208285632f950 Dominik Brodowski 2022-02-13  445  	if (!current_rng) {
8208285632f950 Dominik Brodowski 2022-02-13  446  		ret = -ENODEV;
8208285632f950 Dominik Brodowski 2022-02-13  447  		goto out;
8208285632f950 Dominik Brodowski 2022-02-13  448  	}
8208285632f950 Dominik Brodowski 2022-02-13  449  
8208285632f950 Dominik Brodowski 2022-02-13  450  	current_rng->quality = quality;
8208285632f950 Dominik Brodowski 2022-02-13  451  	current_quality = quality; /* obsolete */
8208285632f950 Dominik Brodowski 2022-02-13  452  
8208285632f950 Dominik Brodowski 2022-02-13  453  	/* the best available RNG may have changed */
8208285632f950 Dominik Brodowski 2022-02-13  454  	ret = enable_best_rng();
8208285632f950 Dominik Brodowski 2022-02-13  455  
8208285632f950 Dominik Brodowski 2022-02-13  456  	/* start/stop rngd if necessary */
8208285632f950 Dominik Brodowski 2022-02-13  457  	if (current_rng)
8208285632f950 Dominik Brodowski 2022-02-13  458  		hwrng_manage_rngd(current_rng);
8208285632f950 Dominik Brodowski 2022-02-13  459  
8208285632f950 Dominik Brodowski 2022-02-13  460  out:
8208285632f950 Dominik Brodowski 2022-02-13  461  	mutex_unlock(&rng_mutex);
8208285632f950 Dominik Brodowski 2022-02-13  462  	return ret ? ret : len;
8208285632f950 Dominik Brodowski 2022-02-13  463  }
8208285632f950 Dominik Brodowski 2022-02-13  464  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-25 23:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 13:34 drivers/char/hw_random/core.c:429:13: warning: use of uninitialized value '<unknown>' [CWE-457] kernel test robot
2022-07-25 23:50 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.