* [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options
@ 2022-06-19 21:01 Fabrice Fontaine
2022-06-19 21:01 ` [Buildroot] [PATCH 2/3] package/bind: disable cmocka Fabrice Fontaine
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2022-06-19 21:01 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
--enable-threads, --with-randomdev, --enable-filter-aaaa, --with-ecdsa,
--with-eddsa, --with-aes, --with-gost are all unrecognized since bump to
version 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92:
configure: WARNING: unrecognized options: --disable-gtk-doc, --disable-gtk-doc-html, --disable-doc, --disable-docs, --disable-documentation, --with-xmlto, --with-fop, --disable-dependency-tracking, --enable-ipv6, --enable-nls, --enable-threads, --with-randomdev, --enable-filter-aaaa, --with-ecdsa, --with-eddsa, --with-aes, --with-gost
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/bind/bind.mk | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/package/bind/bind.mk b/package/bind/bind.mk
index 5164001ab5..0ce78d08cb 100644
--- a/package/bind/bind.mk
+++ b/package/bind/bind.mk
@@ -31,17 +31,11 @@ BIND_CONF_ENV = \
BUILD_CFLAGS="$(TARGET_CFLAGS)" \
LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
BIND_CONF_OPTS = \
- $(if $(BR2_TOOLCHAIN_HAS_THREADS),--enable-threads,--disable-threads) \
--without-lmdb \
--with-json-c=no \
- --with-randomdev=/dev/urandom \
--enable-epoll \
- --enable-filter-aaaa \
--disable-backtrace \
- --with-openssl=$(STAGING_DIR)/usr \
- --with-ecdsa=yes \
- --with-eddsa=no \
- --with-aes=yes
+ --with-openssl=$(STAGING_DIR)/usr
BIND_DEPENDENCIES = host-pkgconf libuv openssl
@@ -73,13 +67,6 @@ else
BIND_CONF_OPTS += --with-libxml2=no
endif
-# GOST cipher support requires openssl extra engines
-ifeq ($(BR2_PACKAGE_OPENSSL_ENGINES),y)
-BIND_CONF_OPTS += --with-gost=yes
-else
-BIND_CONF_OPTS += --with-gost=no
-endif
-
# Used by dnssec-keymgr
ifeq ($(BR2_PACKAGE_PYTHON_PLY),y)
BIND_DEPENDENCIES += host-python-ply
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/3] package/bind: disable cmocka
2022-06-19 21:01 [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options Fabrice Fontaine
@ 2022-06-19 21:01 ` Fabrice Fontaine
2022-06-28 18:10 ` Raphael Pavlidis via buildroot
2022-08-11 17:33 ` Peter Korsgaard
2022-06-19 21:01 ` [Buildroot] [PATCH 3/3] package/bind: add libmaxminddb optional dependency Fabrice Fontaine
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2022-06-19 21:01 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Disable cmocka (wich is enabled by default)
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/bind/bind.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/bind/bind.mk b/package/bind/bind.mk
index 0ce78d08cb..c84abe91a0 100644
--- a/package/bind/bind.mk
+++ b/package/bind/bind.mk
@@ -31,6 +31,7 @@ BIND_CONF_ENV = \
BUILD_CFLAGS="$(TARGET_CFLAGS)" \
LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
BIND_CONF_OPTS = \
+ --without-cmocka \
--without-lmdb \
--with-json-c=no \
--enable-epoll \
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 3/3] package/bind: add libmaxminddb optional dependency
2022-06-19 21:01 [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options Fabrice Fontaine
2022-06-19 21:01 ` [Buildroot] [PATCH 2/3] package/bind: disable cmocka Fabrice Fontaine
@ 2022-06-19 21:01 ` Fabrice Fontaine
2022-08-11 17:33 ` Peter Korsgaard
2022-07-20 21:36 ` [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options Thomas Petazzoni via buildroot
2022-08-11 17:33 ` Peter Korsgaard
3 siblings, 1 reply; 9+ messages in thread
From: Fabrice Fontaine @ 2022-06-19 21:01 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Add libmaxminddb optional dependency (which is enabled by default), two
options must be used to enable/disable this dependency:
[pairwise: --enable-geoip --with-maxminddb=auto, --enable-geoip --with-maxminddb=yes, --disable-geoip]
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/bind/bind.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/bind/bind.mk b/package/bind/bind.mk
index c84abe91a0..1646fc6237 100644
--- a/package/bind/bind.mk
+++ b/package/bind/bind.mk
@@ -61,6 +61,13 @@ else
BIND_CONF_OPTS += --with-gssapi=no
endif
+ifeq ($(BR2_PACKAGE_LIBMAXMINDDB),y)
+BIND_CONF_OPTS += --enable-geoip --with-maxminddb
+BIND_DEPENDENCIES += libmaxminddb
+else
+BIND_CONF_OPTS += --disable-geoip
+endif
+
ifeq ($(BR2_PACKAGE_LIBXML2),y)
BIND_CONF_OPTS += --with-libxml2
BIND_DEPENDENCIES += libxml2
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 2/3] package/bind: disable cmocka
2022-06-19 21:01 ` [Buildroot] [PATCH 2/3] package/bind: disable cmocka Fabrice Fontaine
@ 2022-06-28 18:10 ` Raphael Pavlidis via buildroot
2022-07-20 21:37 ` Thomas Petazzoni via buildroot
2022-08-11 17:33 ` Peter Korsgaard
1 sibling, 1 reply; 9+ messages in thread
From: Raphael Pavlidis via buildroot @ 2022-06-28 18:10 UTC (permalink / raw)
To: buildroot
Maybe we could make this dependency dynamically, if the
BR2_PACKAGE_CMOCKA is enabled.
For Example:
ifeq ($(BR2_PACKAGE_CMOCKA),y)
BIND_CONF_OPTS += --with-cmocka
BIND_DEPENDENCIES += cmocka
else
BIND_CONF_OPTS += --without-cmocka
endif
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options
2022-06-19 21:01 [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options Fabrice Fontaine
2022-06-19 21:01 ` [Buildroot] [PATCH 2/3] package/bind: disable cmocka Fabrice Fontaine
2022-06-19 21:01 ` [Buildroot] [PATCH 3/3] package/bind: add libmaxminddb optional dependency Fabrice Fontaine
@ 2022-07-20 21:36 ` Thomas Petazzoni via buildroot
2022-08-11 17:33 ` Peter Korsgaard
3 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-20 21:36 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
On Sun, 19 Jun 2022 23:01:00 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> --enable-threads, --with-randomdev, --enable-filter-aaaa, --with-ecdsa,
> --with-eddsa, --with-aes, --with-gost are all unrecognized since bump to
> version 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92:
>
> configure: WARNING: unrecognized options: --disable-gtk-doc, --disable-gtk-doc-html, --disable-doc, --disable-docs, --disable-documentation, --with-xmlto, --with-fop, --disable-dependency-tracking, --enable-ipv6, --enable-nls, --enable-threads, --with-randomdev, --enable-filter-aaaa, --with-ecdsa, --with-eddsa, --with-aes, --with-gost
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/bind/bind.mk | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
Series applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 2/3] package/bind: disable cmocka
2022-06-28 18:10 ` Raphael Pavlidis via buildroot
@ 2022-07-20 21:37 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-20 21:37 UTC (permalink / raw)
To: Raphael Pavlidis via buildroot; +Cc: Raphael Pavlidis
Hello Raphael,
On Tue, 28 Jun 2022 20:10:07 +0200
Raphael Pavlidis via buildroot <buildroot@buildroot.org> wrote:
> Maybe we could make this dependency dynamically, if the
> BR2_PACKAGE_CMOCKA is enabled.
>
> For Example:
>
> ifeq ($(BR2_PACKAGE_CMOCKA),y)
> BIND_CONF_OPTS += --with-cmocka
> BIND_DEPENDENCIES += cmocka
> else
> BIND_CONF_OPTS += --without-cmocka
> endif
Correct, but we don't "require" this. Indeed, if nobody has ever had
the need for cmocka support in bind, it's fine for the moment to have
an unconditional --without-cmocka. This can be improved later by
someone needing this cmocka support.
Essentially all what I'm saying is that we don't require supporting all
possible optional dependencies/features: it's fine to have some of them
not supported in Buildroot, until someone really needs them.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options
2022-06-19 21:01 [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options Fabrice Fontaine
` (2 preceding siblings ...)
2022-07-20 21:36 ` [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options Thomas Petazzoni via buildroot
@ 2022-08-11 17:33 ` Peter Korsgaard
3 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2022-08-11 17:33 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> --enable-threads, --with-randomdev, --enable-filter-aaaa, --with-ecdsa,
> --with-eddsa, --with-aes, --with-gost are all unrecognized since bump to
> version 9.16.26 in commit 8adeaec8afacbc680edebae91524f6144926ac92:
> configure: WARNING: unrecognized options: --disable-gtk-doc,
> --disable-gtk-doc-html, --disable-doc, --disable-docs,
> --disable-documentation, --with-xmlto, --with-fop,
> --disable-dependency-tracking, --enable-ipv6, --enable-nls,
> --enable-threads, --with-randomdev, --enable-filter-aaaa,
> --with-ecdsa, --with-eddsa, --with-aes, --with-gost
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 3/3] package/bind: add libmaxminddb optional dependency
2022-06-19 21:01 ` [Buildroot] [PATCH 3/3] package/bind: add libmaxminddb optional dependency Fabrice Fontaine
@ 2022-08-11 17:33 ` Peter Korsgaard
0 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2022-08-11 17:33 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Add libmaxminddb optional dependency (which is enabled by default), two
> options must be used to enable/disable this dependency:
> [pairwise: --enable-geoip --with-maxminddb=auto, --enable-geoip
> --with-maxminddb=yes, --disable-geoip]
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 2/3] package/bind: disable cmocka
2022-06-19 21:01 ` [Buildroot] [PATCH 2/3] package/bind: disable cmocka Fabrice Fontaine
2022-06-28 18:10 ` Raphael Pavlidis via buildroot
@ 2022-08-11 17:33 ` Peter Korsgaard
1 sibling, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2022-08-11 17:33 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Disable cmocka (wich is enabled by default)
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-08-11 17:33 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-19 21:01 [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options Fabrice Fontaine
2022-06-19 21:01 ` [Buildroot] [PATCH 2/3] package/bind: disable cmocka Fabrice Fontaine
2022-06-28 18:10 ` Raphael Pavlidis via buildroot
2022-07-20 21:37 ` Thomas Petazzoni via buildroot
2022-08-11 17:33 ` Peter Korsgaard
2022-06-19 21:01 ` [Buildroot] [PATCH 3/3] package/bind: add libmaxminddb optional dependency Fabrice Fontaine
2022-08-11 17:33 ` Peter Korsgaard
2022-07-20 21:36 ` [Buildroot] [PATCH 1/3] package/bind: drop unrecognized options Thomas Petazzoni via buildroot
2022-08-11 17:33 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.