All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] block/io_uring: add missing include file
@ 2022-07-21  6:56 Jinhao Fan
  2022-07-21  7:09 ` Stefano Garzarella
  0 siblings, 1 reply; 3+ messages in thread
From: Jinhao Fan @ 2022-07-21  6:56 UTC (permalink / raw)
  To: qemu-devel
  Cc: its, kbusch, Jinhao Fan, Aarushi Mehta, Julia Suvorova,
	Stefan Hajnoczi, Stefano Garzarella, Kevin Wolf, Hanna Reitz,
	open list:Linux io_uring

The commit "Use io_uring_register_ring_fd() to skip fd operations" uses
warn_report but did not include the header file "qemu/error-report.h".
This causes "error: implicit declaration of function ‘warn_report’".
Include this header file.

Signed-off-by: Jinhao Fan <fanjinhao21s@ict.ac.cn>
---
 block/io_uring.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/io_uring.c b/block/io_uring.c
index f8a19fd97f..a1760152e0 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -11,6 +11,7 @@
 #include "qemu/osdep.h"
 #include <liburing.h>
 #include "block/aio.h"
+#include "qemu/error-report.h"
 #include "qemu/queue.h"
 #include "block/block.h"
 #include "block/raw-aio.h"
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] block/io_uring: add missing include file
  2022-07-21  6:56 [PATCH] block/io_uring: add missing include file Jinhao Fan
@ 2022-07-21  7:09 ` Stefano Garzarella
  2022-07-27 16:44   ` Kevin Wolf
  0 siblings, 1 reply; 3+ messages in thread
From: Stefano Garzarella @ 2022-07-21  7:09 UTC (permalink / raw)
  To: Jinhao Fan
  Cc: qemu-devel, its, kbusch, Aarushi Mehta, Julia Suvorova,
	Stefan Hajnoczi, Kevin Wolf, Hanna Reitz,
	open list:Linux io_uring

On Thu, Jul 21, 2022 at 02:56:45PM +0800, Jinhao Fan wrote:
>The commit "Use io_uring_register_ring_fd() to skip fd operations" uses
>warn_report but did not include the header file "qemu/error-report.h".
>This causes "error: implicit declaration of function ‘warn_report’".
>Include this header file.
>

We could add:

Fixes: e2848bc574 ("Use io_uring_register_ring_fd() to skip fd operations")

>Signed-off-by: Jinhao Fan <fanjinhao21s@ict.ac.cn>
>---
> block/io_uring.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/block/io_uring.c b/block/io_uring.c
>index f8a19fd97f..a1760152e0 100644
>--- a/block/io_uring.c
>+++ b/block/io_uring.c
>@@ -11,6 +11,7 @@
> #include "qemu/osdep.h"
> #include <liburing.h>
> #include "block/aio.h"
>+#include "qemu/error-report.h"
> #include "qemu/queue.h"
> #include "block/block.h"
> #include "block/raw-aio.h"
>-- 
>2.25.1
>
>

Thanks for the fix:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>




^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] block/io_uring: add missing include file
  2022-07-21  7:09 ` Stefano Garzarella
@ 2022-07-27 16:44   ` Kevin Wolf
  0 siblings, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2022-07-27 16:44 UTC (permalink / raw)
  To: Stefano Garzarella
  Cc: Jinhao Fan, qemu-devel, its, kbusch, Aarushi Mehta,
	Julia Suvorova, Stefan Hajnoczi, Hanna Reitz,
	open list:Linux io_uring

Am 21.07.2022 um 09:09 hat Stefano Garzarella geschrieben:
> On Thu, Jul 21, 2022 at 02:56:45PM +0800, Jinhao Fan wrote:
> > The commit "Use io_uring_register_ring_fd() to skip fd operations" uses
> > warn_report but did not include the header file "qemu/error-report.h".
> > This causes "error: implicit declaration of function ‘warn_report’".
> > Include this header file.
> > 
> 
> We could add:
> 
> Fixes: e2848bc574 ("Use io_uring_register_ring_fd() to skip fd operations")
> 
> > Signed-off-by: Jinhao Fan <fanjinhao21s@ict.ac.cn>
> > ---
> > block/io_uring.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/block/io_uring.c b/block/io_uring.c
> > index f8a19fd97f..a1760152e0 100644
> > --- a/block/io_uring.c
> > +++ b/block/io_uring.c
> > @@ -11,6 +11,7 @@
> > #include "qemu/osdep.h"
> > #include <liburing.h>
> > #include "block/aio.h"
> > +#include "qemu/error-report.h"
> > #include "qemu/queue.h"
> > #include "block/block.h"
> > #include "block/raw-aio.h"
> > -- 
> > 2.25.1
> > 
> > 
> 
> Thanks for the fix:
> 
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks, applied to the block branch.

Kevin



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-27 17:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21  6:56 [PATCH] block/io_uring: add missing include file Jinhao Fan
2022-07-21  7:09 ` Stefano Garzarella
2022-07-27 16:44   ` Kevin Wolf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.