* Re: [PATCH] drm/imx/dcss: get rid of HPD warning message
@ 2022-07-21 12:25 ` Laurent Pinchart
0 siblings, 0 replies; 9+ messages in thread
From: Laurent Pinchart @ 2022-07-21 12:25 UTC (permalink / raw)
To: Laurentiu Palcu
Cc: Lucas Stach, Philipp Zabel, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Kieran Bingham, Paul Cercueil, Nikita Yushchenko,
dri-devel, linux-arm-kernel, linux-kernel
Hi Laurentiu,
Thank you for the patch.
On Thu, Jul 21, 2022 at 03:09:12PM +0300, Laurentiu Palcu wrote:
> When DCSS + MIPI_DSI is used, and the last bridge in the chain supports
> HPD, we can see a "Hot plug detection already enabled" warning stack
> trace dump that's thrown when DCSS is initialized.
>
> The problem appeared when HPD was enabled by default in the
> bridge_connector initialization, which made the
> drm_bridge_connector_enable_hpd() call, in DCSS init path, redundant.
> So, let's remove that call.
>
> Fixes: 09077bc311658 ("drm/bridge_connector: enable HPD by default if supported")
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> index 9b84df34a6a12..8cf3352d88582 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> @@ -142,8 +142,6 @@ struct dcss_kms_dev *dcss_kms_attach(struct dcss_dev *dcss)
>
> drm_kms_helper_poll_init(drm);
>
> - drm_bridge_connector_enable_hpd(kms->connector);
> -
> ret = drm_dev_register(drm, 0);
> if (ret)
> goto cleanup_crtc;
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/imx/dcss: get rid of HPD warning message
@ 2022-07-21 12:25 ` Laurent Pinchart
0 siblings, 0 replies; 9+ messages in thread
From: Laurent Pinchart @ 2022-07-21 12:25 UTC (permalink / raw)
To: Laurentiu Palcu
Cc: Nikita Yushchenko, David Airlie, Sascha Hauer, linux-kernel,
dri-devel, Paul Cercueil, Kieran Bingham, NXP Linux Team,
Shawn Guo, Pengutronix Kernel Team, linux-arm-kernel
Hi Laurentiu,
Thank you for the patch.
On Thu, Jul 21, 2022 at 03:09:12PM +0300, Laurentiu Palcu wrote:
> When DCSS + MIPI_DSI is used, and the last bridge in the chain supports
> HPD, we can see a "Hot plug detection already enabled" warning stack
> trace dump that's thrown when DCSS is initialized.
>
> The problem appeared when HPD was enabled by default in the
> bridge_connector initialization, which made the
> drm_bridge_connector_enable_hpd() call, in DCSS init path, redundant.
> So, let's remove that call.
>
> Fixes: 09077bc311658 ("drm/bridge_connector: enable HPD by default if supported")
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> index 9b84df34a6a12..8cf3352d88582 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> @@ -142,8 +142,6 @@ struct dcss_kms_dev *dcss_kms_attach(struct dcss_dev *dcss)
>
> drm_kms_helper_poll_init(drm);
>
> - drm_bridge_connector_enable_hpd(kms->connector);
> -
> ret = drm_dev_register(drm, 0);
> if (ret)
> goto cleanup_crtc;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/imx/dcss: get rid of HPD warning message
2022-07-21 12:25 ` Laurent Pinchart
(?)
@ 2022-08-04 12:47 ` Laurentiu Palcu
-1 siblings, 0 replies; 9+ messages in thread
From: Laurentiu Palcu @ 2022-08-04 12:47 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Lucas Stach, Philipp Zabel, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Kieran Bingham, Paul Cercueil, Nikita Yushchenko,
dri-devel, linux-arm-kernel, linux-kernel
On Thu, Jul 21, 2022 at 03:25:02PM +0300, Laurent Pinchart wrote:
> Hi Laurentiu,
>
> Thank you for the patch.
>
> On Thu, Jul 21, 2022 at 03:09:12PM +0300, Laurentiu Palcu wrote:
> > When DCSS + MIPI_DSI is used, and the last bridge in the chain supports
> > HPD, we can see a "Hot plug detection already enabled" warning stack
> > trace dump that's thrown when DCSS is initialized.
> >
> > The problem appeared when HPD was enabled by default in the
> > bridge_connector initialization, which made the
> > drm_bridge_connector_enable_hpd() call, in DCSS init path, redundant.
> > So, let's remove that call.
> >
> > Fixes: 09077bc311658 ("drm/bridge_connector: enable HPD by default if supported")
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied to drm-misc/drm-misc-fixes.
Thanks,
laurentiu
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/imx/dcss: get rid of HPD warning message
@ 2022-08-04 12:47 ` Laurentiu Palcu
0 siblings, 0 replies; 9+ messages in thread
From: Laurentiu Palcu @ 2022-08-04 12:47 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Lucas Stach, Philipp Zabel, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Kieran Bingham, Paul Cercueil, Nikita Yushchenko,
dri-devel, linux-arm-kernel, linux-kernel
On Thu, Jul 21, 2022 at 03:25:02PM +0300, Laurent Pinchart wrote:
> Hi Laurentiu,
>
> Thank you for the patch.
>
> On Thu, Jul 21, 2022 at 03:09:12PM +0300, Laurentiu Palcu wrote:
> > When DCSS + MIPI_DSI is used, and the last bridge in the chain supports
> > HPD, we can see a "Hot plug detection already enabled" warning stack
> > trace dump that's thrown when DCSS is initialized.
> >
> > The problem appeared when HPD was enabled by default in the
> > bridge_connector initialization, which made the
> > drm_bridge_connector_enable_hpd() call, in DCSS init path, redundant.
> > So, let's remove that call.
> >
> > Fixes: 09077bc311658 ("drm/bridge_connector: enable HPD by default if supported")
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied to drm-misc/drm-misc-fixes.
Thanks,
laurentiu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/imx/dcss: get rid of HPD warning message
@ 2022-08-04 12:47 ` Laurentiu Palcu
0 siblings, 0 replies; 9+ messages in thread
From: Laurentiu Palcu @ 2022-08-04 12:47 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Nikita Yushchenko, David Airlie, Sascha Hauer, linux-kernel,
dri-devel, Paul Cercueil, Kieran Bingham, NXP Linux Team,
Shawn Guo, Pengutronix Kernel Team, linux-arm-kernel
On Thu, Jul 21, 2022 at 03:25:02PM +0300, Laurent Pinchart wrote:
> Hi Laurentiu,
>
> Thank you for the patch.
>
> On Thu, Jul 21, 2022 at 03:09:12PM +0300, Laurentiu Palcu wrote:
> > When DCSS + MIPI_DSI is used, and the last bridge in the chain supports
> > HPD, we can see a "Hot plug detection already enabled" warning stack
> > trace dump that's thrown when DCSS is initialized.
> >
> > The problem appeared when HPD was enabled by default in the
> > bridge_connector initialization, which made the
> > drm_bridge_connector_enable_hpd() call, in DCSS init path, redundant.
> > So, let's remove that call.
> >
> > Fixes: 09077bc311658 ("drm/bridge_connector: enable HPD by default if supported")
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied to drm-misc/drm-misc-fixes.
Thanks,
laurentiu
^ permalink raw reply [flat|nested] 9+ messages in thread