From: Douglas Anderson <dianders@chromium.org> To: dri-devel@lists.freedesktop.org Cc: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, freedreno@lists.freedesktop.org, Douglas Anderson <dianders@chromium.org>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org Subject: [RFC PATCH] drm/edid: Make 144 Hz not preferred on Sharp LQ140M1JW46 Date: Thu, 21 Jul 2022 15:23:40 -0700 [thread overview] Message-ID: <20220721152314.RFC.1.Ie333b3e4aff6e4a5b58c4aa805e030e561be8773@changeid> (raw) The Sharp LQ140M1JW46 panel is on the Qualcomm sc7280 CRD reference board. This panel supports 144 Hz and 60 Hz. In the EDID, the 144 Hz mode is listed first and thus is marked preferred. The EDID decode I ran says: First detailed timing includes the native pixel format and preferred refresh rate. ... Detailed Timing Descriptors: DTD 1: 1920x1080 143.981 Hz 16:9 166.587 kHz 346.500 MHz Hfront 48 Hsync 32 Hback 80 Hpol N Vfront 3 Vsync 5 Vback 69 Vpol N DTD 2: 1920x1080 59.990 Hz 16:9 69.409 kHz 144.370 MHz Hfront 48 Hsync 32 Hback 80 Hpol N Vfront 3 Vsync 5 Vback 69 Vpol N I'm proposing here that the above is actually a bug and that the 60 Hz mode really should be considered preferred by Linux. The argument here is that this is a laptop panel and on a laptop we know power will always be a concern. Presumably even if someone using this panel wanted to use 144 Hz for some use cases they would only do so dynamically and would still want the default to be 60 Hz. Let's change the default to 60 Hz using a standard quirk. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index bbc25e3b7220..06ff8ba216af 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -160,6 +160,9 @@ static const struct edid_quirk { EDID_QUIRK('S', 'A', 'M', 596, EDID_QUIRK_PREFER_LARGE_60), EDID_QUIRK('S', 'A', 'M', 638, EDID_QUIRK_PREFER_LARGE_60), + /* 144 Hz should only be used when needed; it wastes power */ + EDID_QUIRK('S', 'H', 'P', 0x1523, EDID_QUIRK_PREFER_LARGE_60), + /* Sony PVM-2541A does up to 12 bpc, but only reports max 8 bpc */ EDID_QUIRK('S', 'N', 'Y', 0x2541, EDID_QUIRK_FORCE_12BPC), -- 2.37.1.359.gd136c6c3e2-goog
WARNING: multiple messages have this Message-ID (diff)
From: Douglas Anderson <dianders@chromium.org> To: dri-devel@lists.freedesktop.org Cc: Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, Douglas Anderson <dianders@chromium.org>, freedreno@lists.freedesktop.org Subject: [RFC PATCH] drm/edid: Make 144 Hz not preferred on Sharp LQ140M1JW46 Date: Thu, 21 Jul 2022 15:23:40 -0700 [thread overview] Message-ID: <20220721152314.RFC.1.Ie333b3e4aff6e4a5b58c4aa805e030e561be8773@changeid> (raw) The Sharp LQ140M1JW46 panel is on the Qualcomm sc7280 CRD reference board. This panel supports 144 Hz and 60 Hz. In the EDID, the 144 Hz mode is listed first and thus is marked preferred. The EDID decode I ran says: First detailed timing includes the native pixel format and preferred refresh rate. ... Detailed Timing Descriptors: DTD 1: 1920x1080 143.981 Hz 16:9 166.587 kHz 346.500 MHz Hfront 48 Hsync 32 Hback 80 Hpol N Vfront 3 Vsync 5 Vback 69 Vpol N DTD 2: 1920x1080 59.990 Hz 16:9 69.409 kHz 144.370 MHz Hfront 48 Hsync 32 Hback 80 Hpol N Vfront 3 Vsync 5 Vback 69 Vpol N I'm proposing here that the above is actually a bug and that the 60 Hz mode really should be considered preferred by Linux. The argument here is that this is a laptop panel and on a laptop we know power will always be a concern. Presumably even if someone using this panel wanted to use 144 Hz for some use cases they would only do so dynamically and would still want the default to be 60 Hz. Let's change the default to 60 Hz using a standard quirk. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index bbc25e3b7220..06ff8ba216af 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -160,6 +160,9 @@ static const struct edid_quirk { EDID_QUIRK('S', 'A', 'M', 596, EDID_QUIRK_PREFER_LARGE_60), EDID_QUIRK('S', 'A', 'M', 638, EDID_QUIRK_PREFER_LARGE_60), + /* 144 Hz should only be used when needed; it wastes power */ + EDID_QUIRK('S', 'H', 'P', 0x1523, EDID_QUIRK_PREFER_LARGE_60), + /* Sony PVM-2541A does up to 12 bpc, but only reports max 8 bpc */ EDID_QUIRK('S', 'N', 'Y', 0x2541, EDID_QUIRK_FORCE_12BPC), -- 2.37.1.359.gd136c6c3e2-goog
next reply other threads:[~2022-07-21 22:24 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-21 22:23 Douglas Anderson [this message] 2022-07-21 22:23 ` [RFC PATCH] drm/edid: Make 144 Hz not preferred on Sharp LQ140M1JW46 Douglas Anderson 2022-07-22 16:37 ` Abhinav Kumar 2022-07-22 16:37 ` Abhinav Kumar 2022-07-22 16:48 ` Doug Anderson 2022-07-22 16:48 ` Doug Anderson 2022-07-22 17:36 ` Rob Clark 2022-07-22 17:36 ` Rob Clark 2022-07-28 17:34 ` Abhinav Kumar 2022-07-28 17:34 ` Abhinav Kumar 2022-07-28 21:18 ` Doug Anderson 2022-07-28 21:18 ` Doug Anderson 2022-07-29 7:51 ` Maxime Ripard 2022-07-29 7:51 ` Maxime Ripard 2022-07-29 14:50 ` Doug Anderson 2022-07-29 14:50 ` Doug Anderson 2022-07-29 16:41 ` Maxime Ripard 2022-07-29 16:41 ` Maxime Ripard 2022-07-29 19:57 ` Doug Anderson 2022-07-29 19:57 ` Doug Anderson 2022-08-15 6:45 ` Maxime Ripard 2022-08-15 6:45 ` Maxime Ripard 2022-08-17 23:45 ` Doug Anderson 2022-08-17 23:45 ` Doug Anderson 2022-08-18 10:31 ` Jani Nikula 2022-08-18 10:31 ` Jani Nikula
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220721152314.RFC.1.Ie333b3e4aff6e4a5b58c4aa805e030e561be8773@changeid \ --to=dianders@chromium.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.