[PATCH] dma-mapping: update comment after dmabounce removal

[PATCH] dma-mapping: update comment after dmabounce removal

[Lukas Bulwahn]

Commit e3217540c271 ("ARM/dma-mapping: remove dmabounce") removes the
config DMABOUNCE. A comment to the function __dma_page_cpu_to_dev() refers
to this removed config DMABOUNCE.

Remove the obsolete explanation, but keep the recommendation not to use
__dma_page_cpu_to_dev() and use dma_sync_* functions instead.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 arch/arm/mm/dma-mapping.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index e68d1d2ac4be..16c2cdd04639 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -679,8 +679,7 @@ static void dma_cache_maint_page(struct page *page, unsigned long offset,
 
 /*
  * Make an area consistent for devices.
- * Note: Drivers should NOT use this function directly, as it will break
- * platforms with CONFIG_DMABOUNCE.
+ * Note: Drivers should NOT use this function directly.
  * Use the driver DMA support - see dma-mapping.h (dma_sync_*)
  */
 static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
-- 
2.17.1

[PATCH] dma-mapping: update comment after dmabounce removal

[Lukas Bulwahn]

Commit e3217540c271 ("ARM/dma-mapping: remove dmabounce") removes the
config DMABOUNCE. A comment to the function __dma_page_cpu_to_dev() refers
to this removed config DMABOUNCE.

Remove the obsolete explanation, but keep the recommendation not to use
__dma_page_cpu_to_dev() and use dma_sync_* functions instead.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 arch/arm/mm/dma-mapping.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index e68d1d2ac4be..16c2cdd04639 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -679,8 +679,7 @@ static void dma_cache_maint_page(struct page *page, unsigned long offset,
 
 /*
  * Make an area consistent for devices.
- * Note: Drivers should NOT use this function directly, as it will break
- * platforms with CONFIG_DMABOUNCE.
+ * Note: Drivers should NOT use this function directly.
  * Use the driver DMA support - see dma-mapping.h (dma_sync_*)
  */
 static void __dma_page_cpu_to_dev(struct page *page, unsigned long off,
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dma-mapping: update comment after dmabounce removal

[Arnd Bergmann]

On Wed, Jul 20, 2022 at 9:02 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit e3217540c271 ("ARM/dma-mapping: remove dmabounce") removes the
> config DMABOUNCE. A comment to the function __dma_page_cpu_to_dev() refers
> to this removed config DMABOUNCE.
>
> Remove the obsolete explanation, but keep the recommendation not to use
> __dma_page_cpu_to_dev() and use dma_sync_* functions instead.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---

Thanks!

Acked-by: Arnd Bergmann <arnd@arndb.de>

The e3217540c271 commit is only in Christoph's dma-mapping tree, so this would
ideally get applied on top before the merge window.

        Arnd

Re: [PATCH] dma-mapping: update comment after dmabounce removal

[Arnd Bergmann]

On Wed, Jul 20, 2022 at 9:02 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit e3217540c271 ("ARM/dma-mapping: remove dmabounce") removes the
> config DMABOUNCE. A comment to the function __dma_page_cpu_to_dev() refers
> to this removed config DMABOUNCE.
>
> Remove the obsolete explanation, but keep the recommendation not to use
> __dma_page_cpu_to_dev() and use dma_sync_* functions instead.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---

Thanks!

Acked-by: Arnd Bergmann <arnd@arndb.de>

The e3217540c271 commit is only in Christoph's dma-mapping tree, so this would
ideally get applied on top before the merge window.

        Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dma-mapping: update comment after dmabounce removal

[Christoph Hellwig]

On Fri, Jul 22, 2022 at 02:50:20PM +0200, Arnd Bergmann wrote:
> The e3217540c271 commit is only in Christoph's dma-mapping tree, so this would
> ideally get applied on top before the merge window.

I'll pick it up.

Re: [PATCH] dma-mapping: update comment after dmabounce removal

[Christoph Hellwig]

On Fri, Jul 22, 2022 at 02:50:20PM +0200, Arnd Bergmann wrote:
> The e3217540c271 commit is only in Christoph's dma-mapping tree, so this would
> ideally get applied on top before the merge window.

I'll pick it up.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dma-mapping: update comment after dmabounce removal

[Christoph Hellwig]

Thanks, applied.

Re: [PATCH] dma-mapping: update comment after dmabounce removal

[Christoph Hellwig]

Thanks, applied.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel