[Buildroot] [PATCH 00/16] Use single letter notation in genimage.cfg files for partition-type-uuid

[Buildroot] [PATCH 00/16] Use single letter notation in genimage.cfg files for partition-type-uuid

[Giulio Benetti]

This patchset convert partition-type-uuid to single letter notation
*without* "".

Note:
This patchset must be applied after this patch:
https://patchwork.ozlabs.org/project/buildroot/patch/20220204000657.747245-1-giulio.benetti@benettiengineering.com/

Giulio Benetti (16):
  board/aarch64-efi/genimage-efi: convert partition-type-uuid to single
    letter notation
  board/beaglev/genimage-efi: convert partition-type-uuid to single
    letter notation
  board/friendlyarm/nanopc-t4/genimage: convert partition-type-uuid to
    single letter notation
  board/friendlyarm/nanopi-m4/genimage: keep partition-type-uuid without
    "" for consistency
  board/orangepi/orangepi-pc-plus/genimage: keep partition-type-uuid
    without "" for consistency
  board/orangepi/orangepi-r1/genimage: fix partition-type-uuid for boot
    partition and remove "" for consistency
  board/orangepi/orangepi-zero-plus2/genimage: keep partition-type-uuid
    without "" for consistency
  board/pc/genimage-efi: convert partition-type-uuid to single letter
    notation
  board/pine64/rockpro64/genimage: convert partition-type-uuid to single
    letter notation
  board/qemu/aarch64-sbsa/genimage: convert partition-type-uuid to
    single letter notation
  board/radxa/rockpi-n4/genimage: convert partition-type-uuid to single
    letter notation
  board/radxa/rockpi-n10/genimage: convert partition-type-uuid to single
    letter notation
  board/radxa/rockpi-n8/genimage: convert partition-type-uuid to single
    letter notation
  board/sifive/hifive-unleashed/genimage_sdcard: convert
    partition-type-uuid to single letter notation
  board/sifive/hifive-unleashed/genimage_sdcard: add comments to
    particular partition-type-uuid parameters
  board/sifive/hifive-unleashed/genimage_spi-nor: add comments to
    particular partition-type-uuid parameters

 board/aarch64-efi/genimage-efi.cfg                 | 4 ++--
 board/beaglev/genimage.cfg                         | 2 +-
 board/friendlyarm/nanopc-t4/genimage.cfg           | 4 ++--
 board/friendlyarm/nanopi-m4/genimage.cfg           | 4 ++--
 board/orangepi/orangepi-pc-plus/genimage.cfg       | 4 ++--
 board/orangepi/orangepi-r1/genimage.cfg            | 4 ++--
 board/orangepi/orangepi-zero-plus2/genimage.cfg    | 4 ++--
 board/pc/genimage-efi.cfg                          | 4 ++--
 board/pine64/rockpro64/genimage.cfg                | 4 ++--
 board/qemu/aarch64-sbsa/genimage.cfg               | 4 ++--
 board/radxa/rockpi-4/genimage.cfg                  | 4 ++--
 board/radxa/rockpi-n10/genimage.cfg                | 4 ++--
 board/radxa/rockpi-n8/genimage.cfg                 | 4 ++--
 board/sifive/hifive-unleashed/genimage_sdcard.cfg  | 4 +++-
 board/sifive/hifive-unleashed/genimage_spi-nor.cfg | 2 ++
 15 files changed, 30 insertions(+), 26 deletions(-)

-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 01/16] board/aarch64-efi/genimage-efi: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/aarch64-efi/genimage-efi.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/aarch64-efi/genimage-efi.cfg b/board/aarch64-efi/genimage-efi.cfg
index 87e85816bc..7fbe13d390 100644
--- a/board/aarch64-efi/genimage-efi.cfg
+++ b/board/aarch64-efi/genimage-efi.cfg
@@ -18,13 +18,13 @@ image disk.img {
 
 	partition boot {
 		image = "efi-part.vfat"
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = U
 		offset = 32K
 		bootable = true
 	}
 
 	partition root {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = L
 		image = "rootfs.ext2"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 02/16] board/beaglev/genimage-efi: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/beaglev/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/beaglev/genimage.cfg b/board/beaglev/genimage.cfg
index deefdbc110..54f9118ea9 100644
--- a/board/beaglev/genimage.cfg
+++ b/board/beaglev/genimage.cfg
@@ -4,7 +4,7 @@ image sdcard.img {
 	}
 
 	partition rootfs {
-		partition-type-uuid = 72ec70a6-cf74-40e6-bd49-4bda08e8f224
+		partition-type-uuid = L
 		partition-uuid = 0fef845a-c6e1-45bc-82f7-002fa720f958
 		bootable = "true"
 		image = "rootfs.ext4"
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 03/16] board/friendlyarm/nanopc-t4/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/friendlyarm/nanopc-t4/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/friendlyarm/nanopc-t4/genimage.cfg b/board/friendlyarm/nanopc-t4/genimage.cfg
index 98dc2f3892..272037c9f7 100644
--- a/board/friendlyarm/nanopc-t4/genimage.cfg
+++ b/board/friendlyarm/nanopc-t4/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 04/16] board/friendlyarm/nanopi-m4/genimage: keep partition-type-uuid without "" for consistency

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/friendlyarm/nanopi-m4/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/friendlyarm/nanopi-m4/genimage.cfg b/board/friendlyarm/nanopi-m4/genimage.cfg
index 8d0e6ad13b..655981847e 100644
--- a/board/friendlyarm/nanopi-m4/genimage.cfg
+++ b/board/friendlyarm/nanopi-m4/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 05/16] board/orangepi/orangepi-pc-plus/genimage: keep partition-type-uuid without "" for consistency

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/orangepi/orangepi-pc-plus/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/orangepi/orangepi-pc-plus/genimage.cfg b/board/orangepi/orangepi-pc-plus/genimage.cfg
index 3812d785d5..d94239e9a2 100644
--- a/board/orangepi/orangepi-pc-plus/genimage.cfg
+++ b/board/orangepi/orangepi-pc-plus/genimage.cfg
@@ -28,7 +28,7 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid  = "F"
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 	}
@@ -36,7 +36,7 @@ image sdcard.img {
 	# 'rootfs' will be used as the partition label, used
 	# with root=PARTLABEL=rootfs kernel command line
 	partition rootfs {
-		partition-type-uuid = "L"
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 		size = 512M
 	}
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 06/16] board/orangepi/orangepi-r1/genimage: fix partition-type-uuid for boot partition and remove "" for consistency

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/orangepi/orangepi-r1/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/orangepi/orangepi-r1/genimage.cfg b/board/orangepi/orangepi-r1/genimage.cfg
index e93e802bd9..78b69269b7 100644
--- a/board/orangepi/orangepi-r1/genimage.cfg
+++ b/board/orangepi/orangepi-r1/genimage.cfg
@@ -28,7 +28,7 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = "U"
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 	}
@@ -36,7 +36,7 @@ image sdcard.img {
 	# 'rootfs' will be used as the partition label, used
 	# with root=PARTLABEL=rootfs kernel command line
 	partition rootfs {
-		partition-type-uuid = "L"
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 		size = 512M
 	}
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 07/16] board/orangepi/orangepi-zero-plus2/genimage: keep partition-type-uuid without "" for consistency

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/orangepi/orangepi-zero-plus2/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/orangepi/orangepi-zero-plus2/genimage.cfg b/board/orangepi/orangepi-zero-plus2/genimage.cfg
index 5a7ee7707a..9538e6a54e 100644
--- a/board/orangepi/orangepi-zero-plus2/genimage.cfg
+++ b/board/orangepi/orangepi-zero-plus2/genimage.cfg
@@ -26,7 +26,7 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = "F"
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 	}
@@ -34,7 +34,7 @@ image sdcard.img {
 	# 'rootfs' will be used as the partition label, used
 	# with root=PARTLABEL=rootfs kernel command line
 	partition rootfs {
-		partition-type-uuid = "L"
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 		size = 256M
 	}
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 08/16] board/pc/genimage-efi: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/pc/genimage-efi.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/pc/genimage-efi.cfg b/board/pc/genimage-efi.cfg
index 035a077a78..9626a5f2e7 100644
--- a/board/pc/genimage-efi.cfg
+++ b/board/pc/genimage-efi.cfg
@@ -19,13 +19,13 @@ image disk.img {
 
 	partition boot {
 		image = "efi-part.vfat"
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = U
 		offset = 32K
 		bootable = true
 	}
 
 	partition root {
-		partition-type-uuid = 44479540-f297-41b2-9af7-d131d5f0458a
+		partition-type-uuid = L
 		partition-uuid = UUID_TMP
 		image = "rootfs.ext2"
 	}
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 09/16] board/pine64/rockpro64/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/pine64/rockpro64/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/pine64/rockpro64/genimage.cfg b/board/pine64/rockpro64/genimage.cfg
index d3926f2df6..4b96a3447d 100644
--- a/board/pine64/rockpro64/genimage.cfg
+++ b/board/pine64/rockpro64/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 10/16] board/qemu/aarch64-sbsa/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/qemu/aarch64-sbsa/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/qemu/aarch64-sbsa/genimage.cfg b/board/qemu/aarch64-sbsa/genimage.cfg
index bdf8a89d75..629f4e07b7 100644
--- a/board/qemu/aarch64-sbsa/genimage.cfg
+++ b/board/qemu/aarch64-sbsa/genimage.cfg
@@ -19,13 +19,13 @@ image disk.img {
 
 	partition boot {
 		image = "efi-part.vfat"
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = U
 		offset = 32K
 		bootable = true
 	}
 
 	partition root {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = L
 		image = "rootfs.ext2"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 11/16] board/radxa/rockpi-n4/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/radxa/rockpi-4/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/radxa/rockpi-4/genimage.cfg b/board/radxa/rockpi-4/genimage.cfg
index 68cc4d61a8..3c3bd8b7fc 100644
--- a/board/radxa/rockpi-4/genimage.cfg
+++ b/board/radxa/rockpi-4/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 12/16] board/radxa/rockpi-n10/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/radxa/rockpi-n10/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/radxa/rockpi-n10/genimage.cfg b/board/radxa/rockpi-n10/genimage.cfg
index 7f4b639bbc..2773658330 100644
--- a/board/radxa/rockpi-n10/genimage.cfg
+++ b/board/radxa/rockpi-n10/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 13/16] board/radxa/rockpi-n8/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/radxa/rockpi-n8/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/radxa/rockpi-n8/genimage.cfg b/board/radxa/rockpi-n8/genimage.cfg
index 909a646499..3fced4a5d8 100644
--- a/board/radxa/rockpi-n8/genimage.cfg
+++ b/board/radxa/rockpi-n8/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 14/16] board/sifive/hifive-unleashed/genimage_sdcard: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/sifive/hifive-unleashed/genimage_sdcard.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/sifive/hifive-unleashed/genimage_sdcard.cfg b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
index e66f221d73..b8bd787488 100644
--- a/board/sifive/hifive-unleashed/genimage_sdcard.cfg
+++ b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
@@ -17,7 +17,7 @@ image sdcard.img {
 
 	partition rootfs {
 		image = "rootfs.ext4"
-		partition-type-uuid = 0FC63DAF-8483-4772-8E79-3D69D8477DE4
+		partition-type-uuid = L
 		bootable = true
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 15/16] board/sifive/hifive-unleashed/genimage_sdcard: add comments to particular partition-type-uuid parameters

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/sifive/hifive-unleashed/genimage_sdcard.cfg | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/board/sifive/hifive-unleashed/genimage_sdcard.cfg b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
index b8bd787488..47e59a90d7 100644
--- a/board/sifive/hifive-unleashed/genimage_sdcard.cfg
+++ b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
@@ -6,12 +6,14 @@ image sdcard.img {
 	partition u-boot-spl {
 		image = "u-boot-spl.bin"
 		offset = 17K
+		# ZSBL only loads from this type of partition type uuid
 		partition-type-uuid = 5B193300-FC78-40CD-8002-E86C45580B47
 	}
 
 	partition u-boot {
 		image = "u-boot.itb"
 		offset = 1041K
+		# U-Boot expects exactly this partition type uuid
 		partition-type-uuid = 2E54B353-1271-4842-806F-E436D6AF6985
 	}
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/16] board/aarch64-efi/genimage-efi: convert partition-type-uuid to single letter notation

[Yann E. MORIN]

Giulio, All,

FTR, a little recap of what we discussed on IRC, see below

On 2022-02-06 21:05 +0100, Giulio Benetti spake thusly:
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  board/aarch64-efi/genimage-efi.cfg | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/aarch64-efi/genimage-efi.cfg b/board/aarch64-efi/genimage-efi.cfg
> index 87e85816bc..7fbe13d390 100644
> --- a/board/aarch64-efi/genimage-efi.cfg
> +++ b/board/aarch64-efi/genimage-efi.cfg
> @@ -18,13 +18,13 @@ image disk.img {
>  
>  	partition boot {
>  		image = "efi-part.vfat"
> -		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
> +		partition-type-uuid = U
>  		offset = 32K
>  		bootable = true
>  	}
>  
>  	partition root {
> -		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
> +		partition-type-uuid = L

As we discussed on IRC, this is not the same thing. genimage will extend
the 'L' shorthand to the full UUID 0fc63daf-8483-4772-8e79-3d69d8477de4,
which is different.

So I don't think uaing the shorthands are correct.

The UUID assignments are available on Wikipedia:
    https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs

But the systemd docuemntation has extra UUID definitions:
    https://man.archlinux.org/man/systemd-gpt-auto-generator.8

And finally, if neither resources has a UUID for a specific
architecture, we can still use the 'generic' "Linux filesystem data"
UUID 0FC63DAF-8483-4772-8E79-3D69D8477DE4.

Regards,
Yann E. MORIN.

>  		image = "rootfs.ext2"
>  	}
>  }
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/16] board/aarch64-efi/genimage-efi: convert partition-type-uuid to single letter notation

[Thomas Petazzoni via buildroot]

Hello,

On Sun, 6 Feb 2022 22:36:57 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> >  	partition root {
> > -		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
> > +		partition-type-uuid = L  
> 
> As we discussed on IRC, this is not the same thing. genimage will extend
> the 'L' shorthand to the full UUID 0fc63daf-8483-4772-8e79-3d69d8477de4,
> which is different.

And? Is that really important?

> So I don't think uaing the shorthands are correct.

Why?

> The UUID assignments are available on Wikipedia:
>     https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs
> 
> But the systemd docuemntation has extra UUID definitions:
>     https://man.archlinux.org/man/systemd-gpt-auto-generator.8

Yes, but how useful are they?

Unless these systemd-defined UUID are really relevant, I would prefer
that we use the shortcuts provided by genimage wherever possible, and
only rely on using the full UUID for special cases, such as the
board/sifive/hifive-unleashed/genimage_sdcard.cfg (PATCH 15/16).

This way, it would be pretty clear that we have the "common cases" (boot
partition, rootfs partition) and the "odd/special cases".

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/16] board/aarch64-efi/genimage-efi: convert partition-type-uuid to single letter notation

[Yann E. MORIN]

Thomas, All,

On 2022-02-07 08:55 +0100, Thomas Petazzoni spake thusly:
> On Sun, 6 Feb 2022 22:36:57 +0100
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > >  	partition root {
> > > -		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
> > > +		partition-type-uuid = L  
> > As we discussed on IRC, this is not the same thing. genimage will extend
> > the 'L' shorthand to the full UUID 0fc63daf-8483-4772-8e79-3d69d8477de4,
> > which is different.
> And? Is that really important?
> > So I don't think uaing the shorthands are correct.
> Why?

I think that it is important that we do adhere to the expected values;
see below...

> > The UUID assignments are available on Wikipedia:
> >     https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs
> > But the systemd docuemntation has extra UUID definitions:
> >     https://man.archlinux.org/man/systemd-gpt-auto-generator.8
> Yes, but how useful are they?

Why would we diverge from the specs?

> Unless these systemd-defined UUID are really relevant, I would prefer
> that we use the shortcuts provided by genimage wherever possible, and
> only rely on using the full UUID for special cases, such as the
> board/sifive/hifive-unleashed/genimage_sdcard.cfg (PATCH 15/16).

There are tools that expect those values, to autodetect partitions. This
is the case, of course, of systemd-gpt-auto-generator, which will lookup
the partition UUIDs, but other tools may expect these UUIDs too.

I am not saying that we would cause trouble by changing our board
descriptions, but if we want to allow people to just copy them as the
base for their own development, then diverging from expected behaviour
is not nice.

> This way, it would be pretty clear that we have the "common cases" (boot
> partition, rootfs partition) and the "odd/special cases".

I think the "common case" would be "adhere to spec, use specified
values", while the exceptions are "the spec says nothing, use something
else and comment it".

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/16] board/aarch64-efi/genimage-efi: convert partition-type-uuid to single letter notation

[Arnout Vandecappelle]

On 07/02/2022 18:37, Yann E. MORIN wrote:
> Thomas, All,
> 
> On 2022-02-07 08:55 +0100, Thomas Petazzoni spake thusly:
>> On Sun, 6 Feb 2022 22:36:57 +0100
>> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
>>>>   	partition root {
>>>> -		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
>>>> +		partition-type-uuid = L
>>> As we discussed on IRC, this is not the same thing. genimage will extend
>>> the 'L' shorthand to the full UUID 0fc63daf-8483-4772-8e79-3d69d8477de4,
>>> which is different.
>> And? Is that really important?
>>> So I don't think uaing the shorthands are correct.
>> Why?
> 
> I think that it is important that we do adhere to the expected values;
> see below...
> 
>>> The UUID assignments are available on Wikipedia:
>>>      https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs
>>> But the systemd docuemntation has extra UUID definitions:
>>>      https://man.archlinux.org/man/systemd-gpt-auto-generator.8
>> Yes, but how useful are they?
> 
> Why would we diverge from the specs?
> 
>> Unless these systemd-defined UUID are really relevant, I would prefer
>> that we use the shortcuts provided by genimage wherever possible, and
>> only rely on using the full UUID for special cases, such as the
>> board/sifive/hifive-unleashed/genimage_sdcard.cfg (PATCH 15/16).
> 
> There are tools that expect those values, to autodetect partitions. This
> is the case, of course, of systemd-gpt-auto-generator, which will lookup
> the partition UUIDs, but other tools may expect these UUIDs too.

  At least for systemd-gpt-auto-generator, the UUID for rootfs is only relevant 
in case systemd is the one mounting the rootfs, i.e. in case of it running from 
initramfs and pivoting into a mounted root.

  That is not a scenario that we support in Buildroot, by a long shot. 
Therefore, my suggestion would be to use the default Linux partition type for 
the rootfs, i.e. L. Since this is actually the default for genimage, I would 
even leave it out completely.

  Giulio, that would mean rewriting this series and removing everywhere L is 
specified. Do you agree with that?


> I am not saying that we would cause trouble by changing our board
> descriptions, but if we want to allow people to just copy them as the
> base for their own development, then diverging from expected behaviour
> is not nice.

  I think the cases where a non-standard (where "standard" means the actual GPT 
standard, not the additional stuff that systemd invented) partition type is 
relevant are going to be so unusual that the default we put in our genimage.cfg 
is going to be of no relevance whatsoever.

  Regards,
  Arnout


> 
>> This way, it would be pretty clear that we have the "common cases" (boot
>> partition, rootfs partition) and the "odd/special cases".
> 
> I think the "common case" would be "adhere to spec, use specified
> values", while the exceptions are "the spec says nothing, use something
> else and comment it".
> 
> Regards,
> Yann E. MORIN.
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/16] board/aarch64-efi/genimage-efi: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Hi Arnout, Yann, Thomas, All,

On 13/02/22 16:06, Arnout Vandecappelle wrote:
> 
> 
> On 07/02/2022 18:37, Yann E. MORIN wrote:
>> Thomas, All,
>>
>> On 2022-02-07 08:55 +0100, Thomas Petazzoni spake thusly:
>>> On Sun, 6 Feb 2022 22:36:57 +0100
>>> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
>>>>>    	partition root {
>>>>> -		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
>>>>> +		partition-type-uuid = L
>>>> As we discussed on IRC, this is not the same thing. genimage will extend
>>>> the 'L' shorthand to the full UUID 0fc63daf-8483-4772-8e79-3d69d8477de4,
>>>> which is different.
>>> And? Is that really important?
>>>> So I don't think uaing the shorthands are correct.
>>> Why?
>>
>> I think that it is important that we do adhere to the expected values;
>> see below...
>>
>>>> The UUID assignments are available on Wikipedia:
>>>>       https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs
>>>> But the systemd docuemntation has extra UUID definitions:
>>>>       https://man.archlinux.org/man/systemd-gpt-auto-generator.8
>>> Yes, but how useful are they?
>>
>> Why would we diverge from the specs?
>>
>>> Unless these systemd-defined UUID are really relevant, I would prefer
>>> that we use the shortcuts provided by genimage wherever possible, and
>>> only rely on using the full UUID for special cases, such as the
>>> board/sifive/hifive-unleashed/genimage_sdcard.cfg (PATCH 15/16).
>>
>> There are tools that expect those values, to autodetect partitions. This
>> is the case, of course, of systemd-gpt-auto-generator, which will lookup
>> the partition UUIDs, but other tools may expect these UUIDs too.
> 
>    At least for systemd-gpt-auto-generator, the UUID for rootfs is only relevant
> in case systemd is the one mounting the rootfs, i.e. in case of it running from
> initramfs and pivoting into a mounted root.
> 
>    That is not a scenario that we support in Buildroot, by a long shot.
> Therefore, my suggestion would be to use the default Linux partition type for
> the rootfs, i.e. L. Since this is actually the default for genimage, I would
> even leave it out completely.
> 
>    Giulio, that would mean rewriting this series and removing everywhere L is
> specified. Do you agree with that?

I'm going to rework and remove L, less code we have the better IMHO.
Also, this gives less ambiguity on letters, because we're going to end 
up only having:
F => Fat
U => Efi(that recalls UEFI(to me at least) even if it's not the same 
thing as EFI)

> 
>> I am not saying that we would cause trouble by changing our board
>> descriptions, but if we want to allow people to just copy them as the
>> base for their own development, then diverging from expected behaviour
>> is not nice.
> 
>    I think the cases where a non-standard (where "standard" means the actual GPT
> standard, not the additional stuff that systemd invented) partition type is
> relevant are going to be so unusual that the default we put in our genimage.cfg
> is going to be of no relevance whatsoever.

Yes, I agree too. At least for the moment I would use the genimage 
letters and if needed we can modify it later.

Thank you all!

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

>    Regards,
>    Arnout
> 
> 
>>
>>> This way, it would be pretty clear that we have the "common cases" (boot
>>> partition, rootfs partition) and the "odd/special cases".
>>
>> I think the "common case" would be "adhere to spec, use specified
>> values", while the exceptions are "the spec says nothing, use something
>> else and comment it".
>>
>> Regards,
>> Yann E. MORIN.
>>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 00/16] Use single letter notation in genimage.cfg files for partition-type-uuid

[Giulio Benetti]

This patchset convert partition-type-uuid to single letter notation
*without* "" and without L(rootfs) since it's the default value for
partition-type-uuid if it's not specified.

V1->V2:
* remove every partition-type-uuid = L as suggested by Arnout

Giulio Benetti (16):
  board/aarch64-efi/genimage-efi: convert partition-type-uuid to single
    letter notation
  board/beaglev/genimage-efi: remove partition-type-uuid since its
    default value is L(rootfs)
  board/friendlyarm/nanopc-t4/genimage: convert partition-type-uuid to
    single letter notation
  board/friendlyarm/nanopi-m4/genimage: convert partition-type-uuid to
    single letter notation
  board/orangepi/orangepi-pc-plus/genimage: keep partition-type-uuid
    without "" for consistency
  board/orangepi/orangepi-r1/genimage: fix partition-type-uuid for boot
    partition and remove "" for consistency
  board/orangepi/orangepi-zero-plus2/genimage: keep partition-type-uuid
    without "" for consistency
  board/pc/genimage-efi: convert partition-type-uuid to single letter
    notation
  board/pine64/rockpro64/genimage: convert partition-type-uuid to single
    letter notation
  board/qemu/aarch64-sbsa/genimage: convert partition-type-uuid to
    single letter notation
  board/radxa/rockpi-n4/genimage: convert partition-type-uuid to single
    letter notation
  board/radxa/rockpi-n10/genimage: convert partition-type-uuid to single
    letter notation
  board/radxa/rockpi-n8/genimage: convert partition-type-uuid to single
    letter notation
  board/sifive/hifive-unleashed/genimage_sdcard: remove
    partition-type-uuid since its default value is L(rootfs)
  board/sifive/hifive-unleashed/genimage_sdcard: add comments to
    particular partition-type-uuid parameters
  board/sifive/hifive-unleashed/genimage_spi-nor: add comments to
    particular partition-type-uuid parameters

 board/aarch64-efi/genimage-efi.cfg                 | 3 +--
 board/beaglev/genimage.cfg                         | 2 +-
 board/friendlyarm/nanopc-t4/genimage.cfg           | 3 +--
 board/friendlyarm/nanopi-m4/genimage.cfg           | 3 +--
 board/orangepi/orangepi-pc-plus/genimage.cfg       | 3 +--
 board/orangepi/orangepi-r1/genimage.cfg            | 3 +--
 board/orangepi/orangepi-zero-plus2/genimage.cfg    | 3 +--
 board/pc/genimage-efi.cfg                          | 3 +--
 board/pine64/rockpro64/genimage.cfg                | 3 +--
 board/qemu/aarch64-sbsa/genimage.cfg               | 3 +--
 board/radxa/rockpi-4/genimage.cfg                  | 3 +--
 board/radxa/rockpi-n10/genimage.cfg                | 3 +--
 board/radxa/rockpi-n8/genimage.cfg                 | 4 ++--
 board/sifive/hifive-unleashed/genimage_sdcard.cfg  | 3 ++-
 board/sifive/hifive-unleashed/genimage_spi-nor.cfg | 2 ++
 15 files changed, 18 insertions(+), 26 deletions(-)

-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 01/16] board/aarch64-efi/genimage-efi: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/aarch64-efi/genimage-efi.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/aarch64-efi/genimage-efi.cfg b/board/aarch64-efi/genimage-efi.cfg
index 87e85816bc..3708727c18 100644
--- a/board/aarch64-efi/genimage-efi.cfg
+++ b/board/aarch64-efi/genimage-efi.cfg
@@ -18,13 +18,12 @@ image disk.img {
 
 	partition boot {
 		image = "efi-part.vfat"
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = U
 		offset = 32K
 		bootable = true
 	}
 
 	partition root {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext2"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 02/16] board/beaglev/genimage-efi: remove partition-type-uuid since its default value is L(rootfs)

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/beaglev/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/beaglev/genimage.cfg b/board/beaglev/genimage.cfg
index deefdbc110..54f9118ea9 100644
--- a/board/beaglev/genimage.cfg
+++ b/board/beaglev/genimage.cfg
@@ -4,7 +4,7 @@ image sdcard.img {
 	}
 
 	partition rootfs {
-		partition-type-uuid = 72ec70a6-cf74-40e6-bd49-4bda08e8f224
+		partition-type-uuid = L
 		partition-uuid = 0fef845a-c6e1-45bc-82f7-002fa720f958
 		bootable = "true"
 		image = "rootfs.ext4"
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 03/16] board/friendlyarm/nanopc-t4/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/friendlyarm/nanopc-t4/genimage.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/friendlyarm/nanopc-t4/genimage.cfg b/board/friendlyarm/nanopc-t4/genimage.cfg
index 98dc2f3892..f966d48f3f 100644
--- a/board/friendlyarm/nanopc-t4/genimage.cfg
+++ b/board/friendlyarm/nanopc-t4/genimage.cfg
@@ -26,14 +26,13 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 04/16] board/friendlyarm/nanopi-m4/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/friendlyarm/nanopi-m4/genimage.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/friendlyarm/nanopi-m4/genimage.cfg b/board/friendlyarm/nanopi-m4/genimage.cfg
index 8d0e6ad13b..db1205bfbf 100644
--- a/board/friendlyarm/nanopi-m4/genimage.cfg
+++ b/board/friendlyarm/nanopi-m4/genimage.cfg
@@ -26,14 +26,13 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 05/16] board/orangepi/orangepi-pc-plus/genimage: keep partition-type-uuid without "" for consistency

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value, so let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/orangepi/orangepi-pc-plus/genimage.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/orangepi/orangepi-pc-plus/genimage.cfg b/board/orangepi/orangepi-pc-plus/genimage.cfg
index 3812d785d5..2c68b28e10 100644
--- a/board/orangepi/orangepi-pc-plus/genimage.cfg
+++ b/board/orangepi/orangepi-pc-plus/genimage.cfg
@@ -28,7 +28,7 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid  = "F"
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 	}
@@ -36,7 +36,6 @@ image sdcard.img {
 	# 'rootfs' will be used as the partition label, used
 	# with root=PARTLABEL=rootfs kernel command line
 	partition rootfs {
-		partition-type-uuid = "L"
 		image = "rootfs.ext4"
 		size = 512M
 	}
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 06/16] board/orangepi/orangepi-r1/genimage: fix partition-type-uuid for boot partition and remove "" for consistency

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/orangepi/orangepi-r1/genimage.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/orangepi/orangepi-r1/genimage.cfg b/board/orangepi/orangepi-r1/genimage.cfg
index e93e802bd9..da96e4c4b8 100644
--- a/board/orangepi/orangepi-r1/genimage.cfg
+++ b/board/orangepi/orangepi-r1/genimage.cfg
@@ -28,7 +28,7 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = "U"
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 	}
@@ -36,7 +36,6 @@ image sdcard.img {
 	# 'rootfs' will be used as the partition label, used
 	# with root=PARTLABEL=rootfs kernel command line
 	partition rootfs {
-		partition-type-uuid = "L"
 		image = "rootfs.ext4"
 		size = 512M
 	}
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 07/16] board/orangepi/orangepi-zero-plus2/genimage: keep partition-type-uuid without "" for consistency

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/orangepi/orangepi-zero-plus2/genimage.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/orangepi/orangepi-zero-plus2/genimage.cfg b/board/orangepi/orangepi-zero-plus2/genimage.cfg
index 5a7ee7707a..0a03384f30 100644
--- a/board/orangepi/orangepi-zero-plus2/genimage.cfg
+++ b/board/orangepi/orangepi-zero-plus2/genimage.cfg
@@ -26,7 +26,7 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = "F"
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 	}
@@ -34,7 +34,6 @@ image sdcard.img {
 	# 'rootfs' will be used as the partition label, used
 	# with root=PARTLABEL=rootfs kernel command line
 	partition rootfs {
-		partition-type-uuid = "L"
 		image = "rootfs.ext4"
 		size = 256M
 	}
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 08/16] board/pc/genimage-efi: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/pc/genimage-efi.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/pc/genimage-efi.cfg b/board/pc/genimage-efi.cfg
index 035a077a78..68498772a1 100644
--- a/board/pc/genimage-efi.cfg
+++ b/board/pc/genimage-efi.cfg
@@ -19,13 +19,12 @@ image disk.img {
 
 	partition boot {
 		image = "efi-part.vfat"
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = U
 		offset = 32K
 		bootable = true
 	}
 
 	partition root {
-		partition-type-uuid = 44479540-f297-41b2-9af7-d131d5f0458a
 		partition-uuid = UUID_TMP
 		image = "rootfs.ext2"
 	}
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 09/16] board/pine64/rockpro64/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/pine64/rockpro64/genimage.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/pine64/rockpro64/genimage.cfg b/board/pine64/rockpro64/genimage.cfg
index d3926f2df6..978a77de95 100644
--- a/board/pine64/rockpro64/genimage.cfg
+++ b/board/pine64/rockpro64/genimage.cfg
@@ -26,14 +26,13 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 10/16] board/qemu/aarch64-sbsa/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/qemu/aarch64-sbsa/genimage.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/qemu/aarch64-sbsa/genimage.cfg b/board/qemu/aarch64-sbsa/genimage.cfg
index bdf8a89d75..8308b58789 100644
--- a/board/qemu/aarch64-sbsa/genimage.cfg
+++ b/board/qemu/aarch64-sbsa/genimage.cfg
@@ -19,13 +19,12 @@ image disk.img {
 
 	partition boot {
 		image = "efi-part.vfat"
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = U
 		offset = 32K
 		bootable = true
 	}
 
 	partition root {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext2"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 11/16] board/radxa/rockpi-n4/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/radxa/rockpi-4/genimage.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/radxa/rockpi-4/genimage.cfg b/board/radxa/rockpi-4/genimage.cfg
index 68cc4d61a8..07bee5bf81 100644
--- a/board/radxa/rockpi-4/genimage.cfg
+++ b/board/radxa/rockpi-4/genimage.cfg
@@ -26,14 +26,13 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 12/16] board/radxa/rockpi-n10/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/radxa/rockpi-n10/genimage.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/radxa/rockpi-n10/genimage.cfg b/board/radxa/rockpi-n10/genimage.cfg
index 7f4b639bbc..cd0e3610c2 100644
--- a/board/radxa/rockpi-n10/genimage.cfg
+++ b/board/radxa/rockpi-n10/genimage.cfg
@@ -26,14 +26,13 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 13/16] board/radxa/rockpi-n8/genimage: convert partition-type-uuid to single letter notation

[Giulio Benetti]

Note that rootfs doesn't need partition-type-uuid = L since L(rootfs) is
the default value. So let's remove it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/radxa/rockpi-n8/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/radxa/rockpi-n8/genimage.cfg b/board/radxa/rockpi-n8/genimage.cfg
index 909a646499..3fced4a5d8 100644
--- a/board/radxa/rockpi-n8/genimage.cfg
+++ b/board/radxa/rockpi-n8/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = F
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3
+		partition-type-uuid = L
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 14/16] board/sifive/hifive-unleashed/genimage_sdcard: remove partition-type-uuid since its default value is L(rootfs)

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/sifive/hifive-unleashed/genimage_sdcard.cfg | 1 -
 1 file changed, 1 deletion(-)

diff --git a/board/sifive/hifive-unleashed/genimage_sdcard.cfg b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
index e66f221d73..1e0c800153 100644
--- a/board/sifive/hifive-unleashed/genimage_sdcard.cfg
+++ b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
@@ -17,7 +17,6 @@ image sdcard.img {
 
 	partition rootfs {
 		image = "rootfs.ext4"
-		partition-type-uuid = 0FC63DAF-8483-4772-8E79-3D69D8477DE4
 		bootable = true
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 15/16] board/sifive/hifive-unleashed/genimage_sdcard: add comments to particular partition-type-uuid parameters

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/sifive/hifive-unleashed/genimage_sdcard.cfg | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/board/sifive/hifive-unleashed/genimage_sdcard.cfg b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
index 1e0c800153..e5618fa4c1 100644
--- a/board/sifive/hifive-unleashed/genimage_sdcard.cfg
+++ b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
@@ -6,12 +6,14 @@ image sdcard.img {
 	partition u-boot-spl {
 		image = "u-boot-spl.bin"
 		offset = 17K
+		# ZSBL only loads from this type of partition type uuid
 		partition-type-uuid = 5B193300-FC78-40CD-8002-E86C45580B47
 	}
 
 	partition u-boot {
 		image = "u-boot.itb"
 		offset = 1041K
+		# U-Boot expects exactly this partition type uuid
 		partition-type-uuid = 2E54B353-1271-4842-806F-E436D6AF6985
 	}
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 16/16] board/sifive/hifive-unleashed/genimage_spi-nor: add comments to particular partition-type-uuid parameters

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/sifive/hifive-unleashed/genimage_spi-nor.cfg | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/board/sifive/hifive-unleashed/genimage_spi-nor.cfg b/board/sifive/hifive-unleashed/genimage_spi-nor.cfg
index 903e675a90..f5e8f188e3 100644
--- a/board/sifive/hifive-unleashed/genimage_spi-nor.cfg
+++ b/board/sifive/hifive-unleashed/genimage_spi-nor.cfg
@@ -8,12 +8,14 @@ image spi-nor.img {
 	partition u-boot-spl {
 		image = "u-boot-spl.bin"
 		offset = 20K
+		# ZSBL only loads from this type of partition type uuid
 		partition-type-uuid = 5B193300-FC78-40CD-8002-E86C45580B47
 	}
 
 	partition u-boot {
 		image = "u-boot.itb"
 		offset = 1044K
+		# U-Boot expects exactly this partition type uuid
 		partition-type-uuid = 2E54B353-1271-4842-806F-E436D6AF6985
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 00/16] Use single letter notation in genimage.cfg files for partition-type-uuid

[Thomas Petazzoni via buildroot]

Hello,

On Sun,  6 Feb 2022 21:05:16 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This patchset convert partition-type-uuid to single letter notation
> *without* "".

I have sent a new iteration of this series at:

  https://patchwork.ozlabs.org/project/buildroot/list/?series=310888

which makes some slightly different choices, after discussion with
Arnout. Feedback welcome.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot