* [PATCH] slimbus: qcom-ngd-ctrl: Add check for platform_driver_register
@ 2022-07-23 3:23 ` williamsukatube
0 siblings, 0 replies; 2+ messages in thread
From: williamsukatube @ 2022-07-23 3:23 UTC (permalink / raw)
To: agross, bjorn.andersson, srinivas.kandagatla, linux-arm-msm,
alsa-devel, linux-kernel
Cc: konrad.dybcio, William Dean, Hacash Robot
From: William Dean <williamsukatube@gmail.com>
As platform_driver_register() could fail, it should be better
to deal with the return value in order to maintain the code
consisitency.
Fixes: 1830dad34c070 ("slimbus: ngd: register ngd driver only once.")
Reported-by: Hacash Robot <hacashRobot@santino.com>
Signed-off-by: William Dean <williamsukatube@gmail.com>
---
drivers/slimbus/qcom-ngd-ctrl.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index 0aa8408464ad..a31ec00a37ac 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -1585,7 +1585,12 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
return PTR_ERR(pds);
}
- platform_driver_register(&qcom_slim_ngd_driver);
+ ret = platform_driver_register(&qcom_slim_ngd_driver);
+ if (ret) {
+ dev_err(dev, "platform driver register failed: %d\n", ret);
+ return ret;
+ }
+
return of_qcom_slim_ngd_register(dev, ctrl);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] slimbus: qcom-ngd-ctrl: Add check for platform_driver_register
@ 2022-07-23 3:23 ` williamsukatube
0 siblings, 0 replies; 2+ messages in thread
From: williamsukatube @ 2022-07-23 3:23 UTC (permalink / raw)
To: agross, bjorn.andersson, srinivas.kandagatla, linux-arm-msm,
alsa-devel, linux-kernel
Cc: Hacash Robot, William Dean, konrad.dybcio
From: William Dean <williamsukatube@gmail.com>
As platform_driver_register() could fail, it should be better
to deal with the return value in order to maintain the code
consisitency.
Fixes: 1830dad34c070 ("slimbus: ngd: register ngd driver only once.")
Reported-by: Hacash Robot <hacashRobot@santino.com>
Signed-off-by: William Dean <williamsukatube@gmail.com>
---
drivers/slimbus/qcom-ngd-ctrl.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index 0aa8408464ad..a31ec00a37ac 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -1585,7 +1585,12 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
return PTR_ERR(pds);
}
- platform_driver_register(&qcom_slim_ngd_driver);
+ ret = platform_driver_register(&qcom_slim_ngd_driver);
+ if (ret) {
+ dev_err(dev, "platform driver register failed: %d\n", ret);
+ return ret;
+ }
+
return of_qcom_slim_ngd_register(dev, ctrl);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-23 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-23 3:23 [PATCH] slimbus: qcom-ngd-ctrl: Add check for platform_driver_register williamsukatube
2022-07-23 3:23 ` williamsukatube
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.