[PATCH] bpftool: replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE macro

[PATCH] bpftool: replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE macro

[Rongguang Wei]

From: Rongguang Wei <weirongguang@kylinos.cn>

Use the ARRAY_SIZE macro and make the code more compact.

Signed-off-by: Rongguang Wei <weirongguang@kylinos.cn>
---
 tools/bpf/bpftool/prog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
index 5c2c63df92e8..1e7768aa7a0e 100644
--- a/tools/bpf/bpftool/prog.c
+++ b/tools/bpf/bpftool/prog.c
@@ -1974,7 +1974,7 @@ static int profile_parse_metrics(int argc, char **argv)
 	int selected_cnt = 0;
 	unsigned int i;
 
-	metric_cnt = sizeof(metrics) / sizeof(struct profile_metric);
+	metric_cnt = ARRAY_SIZE(metrics);
 
 	while (argc > 0) {
 		for (i = 0; i < metric_cnt; i++) {
-- 
2.25.1

Re: [PATCH] bpftool: replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE macro

[Quentin Monnet]

On Tue, 26 Jul 2022 at 10:31, Rongguang Wei <clementwei90@163.com> wrote:
>
> From: Rongguang Wei <weirongguang@kylinos.cn>
>
> Use the ARRAY_SIZE macro and make the code more compact.
>
> Signed-off-by: Rongguang Wei <weirongguang@kylinos.cn>

Reviewed-by: Quentin Monnet <quentin@isovalent.com>

Thank you! For future patches, please specify the target tree in the
object of the message (“[PATCH bpf-next]” in this case).

Re: [PATCH] bpftool: replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE macro

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Tue, 26 Jul 2022 17:30:45 +0800 you wrote:
> From: Rongguang Wei <weirongguang@kylinos.cn>
> 
> Use the ARRAY_SIZE macro and make the code more compact.
> 
> Signed-off-by: Rongguang Wei <weirongguang@kylinos.cn>
> ---
>  tools/bpf/bpftool/prog.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - bpftool: replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE macro
    https://git.kernel.org/bpf/bpf-next/c/5eff8c18f124

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html