* [PATCH 0/2] power/reset/watchdog: dt-bindings: minor clean and qcom,pm8916-wdt to dtschema @ 2022-07-26 12:02 Krzysztof Kozlowski 2022-07-26 12:02 ` [PATCH 1/2] dt-bindings: power: reset: qcom,pon: use absolute path to other schema Krzysztof Kozlowski 2022-07-26 12:02 ` [PATCH 2/2] dt-bindings: watchdog: qcom,pm8916-wdt: convert to dtschema Krzysztof Kozlowski 0 siblings, 2 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-07-26 12:02 UTC (permalink / raw) To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Wim Van Sebroeck, Guenter Roeck, Vinod Koul, linux-pm, devicetree, linux-kernel, linux-arm-msm, linux-watchdog Cc: Krzysztof Kozlowski Hi, Dependency ========== Patch #2 watchdog depends by context on patch #1. Optionally I could split these into two separate patchsets, but then we would have conflict when merging to linux-next/Linus. Let me know if that is preferred. Best regards, Krzysztof Krzysztof Kozlowski (2): dt-bindings: power: reset: qcom,pon: use absolute path to other schema dt-bindings: watchdog: qcom,pm8916-wdt: convert to dtschema .../bindings/power/reset/qcom,pon.yaml | 8 ++- .../bindings/watchdog/qcom,pm8916-wdt.txt | 28 ---------- .../bindings/watchdog/qcom,pm8916-wdt.yaml | 51 +++++++++++++++++++ 3 files changed, 57 insertions(+), 30 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml -- 2.34.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] dt-bindings: power: reset: qcom,pon: use absolute path to other schema 2022-07-26 12:02 [PATCH 0/2] power/reset/watchdog: dt-bindings: minor clean and qcom,pm8916-wdt to dtschema Krzysztof Kozlowski @ 2022-07-26 12:02 ` Krzysztof Kozlowski 2022-07-27 5:22 ` Vinod Koul 2022-07-27 15:13 ` Rob Herring 2022-07-26 12:02 ` [PATCH 2/2] dt-bindings: watchdog: qcom,pm8916-wdt: convert to dtschema Krzysztof Kozlowski 1 sibling, 2 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-07-26 12:02 UTC (permalink / raw) To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Wim Van Sebroeck, Guenter Roeck, Vinod Koul, linux-pm, devicetree, linux-kernel, linux-arm-msm, linux-watchdog Cc: Krzysztof Kozlowski Absolute path to other DT schema is preferred over relative one. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml index 353f155df0f4..e8ecb75155db 100644 --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml @@ -30,11 +30,11 @@ properties: pwrkey: type: object - $ref: "../../input/qcom,pm8941-pwrkey.yaml#" + $ref: /schemas/input/qcom,pm8941-pwrkey.yaml# resin: type: object - $ref: "../../input/qcom,pm8941-pwrkey.yaml#" + $ref: /schemas/input/qcom,pm8941-pwrkey.yaml# required: - compatible -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: power: reset: qcom,pon: use absolute path to other schema 2022-07-26 12:02 ` [PATCH 1/2] dt-bindings: power: reset: qcom,pon: use absolute path to other schema Krzysztof Kozlowski @ 2022-07-27 5:22 ` Vinod Koul 2022-07-27 15:13 ` Rob Herring 1 sibling, 0 replies; 7+ messages in thread From: Vinod Koul @ 2022-07-27 5:22 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Wim Van Sebroeck, Guenter Roeck, linux-pm, devicetree, linux-kernel, linux-arm-msm, linux-watchdog On 26-07-22, 14:02, Krzysztof Kozlowski wrote: > Absolute path to other DT schema is preferred over relative one. Reviewed-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > index 353f155df0f4..e8ecb75155db 100644 > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > @@ -30,11 +30,11 @@ properties: > > pwrkey: > type: object > - $ref: "../../input/qcom,pm8941-pwrkey.yaml#" > + $ref: /schemas/input/qcom,pm8941-pwrkey.yaml# > > resin: > type: object > - $ref: "../../input/qcom,pm8941-pwrkey.yaml#" > + $ref: /schemas/input/qcom,pm8941-pwrkey.yaml# > > required: > - compatible > -- > 2.34.1 -- ~Vinod ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: power: reset: qcom,pon: use absolute path to other schema 2022-07-26 12:02 ` [PATCH 1/2] dt-bindings: power: reset: qcom,pon: use absolute path to other schema Krzysztof Kozlowski 2022-07-27 5:22 ` Vinod Koul @ 2022-07-27 15:13 ` Rob Herring 1 sibling, 0 replies; 7+ messages in thread From: Rob Herring @ 2022-07-27 15:13 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, linux-watchdog, Krzysztof Kozlowski, Wim Van Sebroeck, Konrad Dybcio, devicetree, linux-kernel, linux-arm-msm, Bjorn Andersson, Guenter Roeck, linux-pm, Sebastian Reichel, Andy Gross, Vinod Koul On Tue, 26 Jul 2022 14:02:14 +0200, Krzysztof Kozlowski wrote: > Absolute path to other DT schema is preferred over relative one. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks! ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] dt-bindings: watchdog: qcom,pm8916-wdt: convert to dtschema 2022-07-26 12:02 [PATCH 0/2] power/reset/watchdog: dt-bindings: minor clean and qcom,pm8916-wdt to dtschema Krzysztof Kozlowski 2022-07-26 12:02 ` [PATCH 1/2] dt-bindings: power: reset: qcom,pon: use absolute path to other schema Krzysztof Kozlowski @ 2022-07-26 12:02 ` Krzysztof Kozlowski 2022-07-27 5:22 ` Vinod Koul 2022-07-27 15:13 ` Rob Herring 1 sibling, 2 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-07-26 12:02 UTC (permalink / raw) To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Wim Van Sebroeck, Guenter Roeck, Vinod Koul, linux-pm, devicetree, linux-kernel, linux-arm-msm, linux-watchdog Cc: Krzysztof Kozlowski Convert the Qualcomm PM8916 watchdog timer controller bindings to DT schema and include them in parent device schema. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/power/reset/qcom,pon.yaml | 4 ++ .../bindings/watchdog/qcom,pm8916-wdt.txt | 28 ---------- .../bindings/watchdog/qcom,pm8916-wdt.yaml | 51 +++++++++++++++++++ 3 files changed, 55 insertions(+), 28 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml index e8ecb75155db..e7b436d2e757 100644 --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml @@ -36,6 +36,10 @@ properties: type: object $ref: /schemas/input/qcom,pm8941-pwrkey.yaml# + watchdog: + type: object + $ref: /schemas/watchdog/qcom,pm8916-wdt.yaml + required: - compatible - reg diff --git a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt deleted file mode 100644 index 6fb984f31982..000000000000 --- a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt +++ /dev/null @@ -1,28 +0,0 @@ -QCOM PM8916 watchdog timer controller - -This pm8916 watchdog timer controller must be under pm8916-pon node. - -Required properties: -- compatible: should be "qcom,pm8916-wdt" - -Optional properties : -- interrupts : Watchdog pre-timeout (bark) interrupt. -- timeout-sec : Watchdog timeout value in seconds. - -Example: - - pm8916_0: pm8916@0 { - compatible = "qcom,pm8916", "qcom,spmi-pmic"; - reg = <0x0 SPMI_USID>; - - pon@800 { - compatible = "qcom,pm8916-pon"; - reg = <0x800>; - - watchdog { - compatible = "qcom,pm8916-wdt"; - interrupts = <0x0 0x8 6 IRQ_TYPE_EDGE_RISING>; - timeout-sec = <10>; - }; - }; - }; diff --git a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml new file mode 100644 index 000000000000..568eb8480fc3 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/qcom,pm8916-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm PM8916 watchdog timer controller + +maintainers: + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> + +allOf: + - $ref: watchdog.yaml# + +properties: + compatible: + const: qcom,pm8916-wdt + + interrupts: + maxItems: 1 + +required: + - compatible + - interrupts + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/spmi/spmi.h> + + pmic@0 { + compatible = "qcom,pm8916", "qcom,spmi-pmic"; + reg = <0x0 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + + pon@800 { + compatible = "qcom,pm8916-pon"; + reg = <0x800>; + mode-bootloader = <0x2>; + mode-recovery = <0x1>; + + watchdog { + compatible = "qcom,pm8916-wdt"; + interrupts = <0x0 0x8 6 IRQ_TYPE_EDGE_RISING>; + timeout-sec = <60>; + }; + }; + }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: qcom,pm8916-wdt: convert to dtschema 2022-07-26 12:02 ` [PATCH 2/2] dt-bindings: watchdog: qcom,pm8916-wdt: convert to dtschema Krzysztof Kozlowski @ 2022-07-27 5:22 ` Vinod Koul 2022-07-27 15:13 ` Rob Herring 1 sibling, 0 replies; 7+ messages in thread From: Vinod Koul @ 2022-07-27 5:22 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Wim Van Sebroeck, Guenter Roeck, linux-pm, devicetree, linux-kernel, linux-arm-msm, linux-watchdog On 26-07-22, 14:02, Krzysztof Kozlowski wrote: > Convert the Qualcomm PM8916 watchdog timer controller bindings to DT > schema and include them in parent device schema. Reviewed-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/power/reset/qcom,pon.yaml | 4 ++ > .../bindings/watchdog/qcom,pm8916-wdt.txt | 28 ---------- > .../bindings/watchdog/qcom,pm8916-wdt.yaml | 51 +++++++++++++++++++ > 3 files changed, 55 insertions(+), 28 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > index e8ecb75155db..e7b436d2e757 100644 > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > @@ -36,6 +36,10 @@ properties: > type: object > $ref: /schemas/input/qcom,pm8941-pwrkey.yaml# > > + watchdog: > + type: object > + $ref: /schemas/watchdog/qcom,pm8916-wdt.yaml > + > required: > - compatible > - reg > diff --git a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt > deleted file mode 100644 > index 6fb984f31982..000000000000 > --- a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt > +++ /dev/null > @@ -1,28 +0,0 @@ > -QCOM PM8916 watchdog timer controller > - > -This pm8916 watchdog timer controller must be under pm8916-pon node. > - > -Required properties: > -- compatible: should be "qcom,pm8916-wdt" > - > -Optional properties : > -- interrupts : Watchdog pre-timeout (bark) interrupt. > -- timeout-sec : Watchdog timeout value in seconds. > - > -Example: > - > - pm8916_0: pm8916@0 { > - compatible = "qcom,pm8916", "qcom,spmi-pmic"; > - reg = <0x0 SPMI_USID>; > - > - pon@800 { > - compatible = "qcom,pm8916-pon"; > - reg = <0x800>; > - > - watchdog { > - compatible = "qcom,pm8916-wdt"; > - interrupts = <0x0 0x8 6 IRQ_TYPE_EDGE_RISING>; > - timeout-sec = <10>; > - }; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml > new file mode 100644 > index 000000000000..568eb8480fc3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/qcom,pm8916-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm PM8916 watchdog timer controller > + > +maintainers: > + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > + > +allOf: > + - $ref: watchdog.yaml# > + > +properties: > + compatible: > + const: qcom,pm8916-wdt > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/spmi/spmi.h> > + > + pmic@0 { > + compatible = "qcom,pm8916", "qcom,spmi-pmic"; > + reg = <0x0 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pon@800 { > + compatible = "qcom,pm8916-pon"; > + reg = <0x800>; > + mode-bootloader = <0x2>; > + mode-recovery = <0x1>; > + > + watchdog { > + compatible = "qcom,pm8916-wdt"; > + interrupts = <0x0 0x8 6 IRQ_TYPE_EDGE_RISING>; > + timeout-sec = <60>; > + }; > + }; > + }; > -- > 2.34.1 -- ~Vinod ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: qcom,pm8916-wdt: convert to dtschema 2022-07-26 12:02 ` [PATCH 2/2] dt-bindings: watchdog: qcom,pm8916-wdt: convert to dtschema Krzysztof Kozlowski 2022-07-27 5:22 ` Vinod Koul @ 2022-07-27 15:13 ` Rob Herring 1 sibling, 0 replies; 7+ messages in thread From: Rob Herring @ 2022-07-27 15:13 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Konrad Dybcio, linux-watchdog, Guenter Roeck, linux-kernel, Sebastian Reichel, Bjorn Andersson, Krzysztof Kozlowski, linux-arm-msm, Vinod Koul, Wim Van Sebroeck, linux-pm, Rob Herring, devicetree, Andy Gross On Tue, 26 Jul 2022 14:02:15 +0200, Krzysztof Kozlowski wrote: > Convert the Qualcomm PM8916 watchdog timer controller bindings to DT > schema and include them in parent device schema. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/power/reset/qcom,pon.yaml | 4 ++ > .../bindings/watchdog/qcom,pm8916-wdt.txt | 28 ---------- > .../bindings/watchdog/qcom,pm8916-wdt.yaml | 51 +++++++++++++++++++ > 3 files changed, 55 insertions(+), 28 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/qcom,pm8916-wdt.yaml > Applied, thanks! ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-07-27 15:13 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-07-26 12:02 [PATCH 0/2] power/reset/watchdog: dt-bindings: minor clean and qcom,pm8916-wdt to dtschema Krzysztof Kozlowski 2022-07-26 12:02 ` [PATCH 1/2] dt-bindings: power: reset: qcom,pon: use absolute path to other schema Krzysztof Kozlowski 2022-07-27 5:22 ` Vinod Koul 2022-07-27 15:13 ` Rob Herring 2022-07-26 12:02 ` [PATCH 2/2] dt-bindings: watchdog: qcom,pm8916-wdt: convert to dtschema Krzysztof Kozlowski 2022-07-27 5:22 ` Vinod Koul 2022-07-27 15:13 ` Rob Herring
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.