* [PATCH] soc: mediatek: Let PMIC Wrapper and SCPSYS depend on OF
@ 2022-07-28 9:22 Jean Delvare
2022-07-28 10:51 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2022-07-28 9:22 UTC (permalink / raw)
To: linux-mediatek, Matthias Brugger; +Cc: Sean Wang, LKML, Chenglin Xu
With the following configuration options:
CONFIG_OF is not set
CONFIG_MTK_PMIC_WRAP=y
CONFIG_MTK_SCPSYS=y
we get the following build warnings:
CC drivers/soc/mediatek/mtk-pmic-wrap.o
drivers/soc/mediatek/mtk-pmic-wrap.c:2138:34: warning: ‘of_pwrap_match_tbl’ defined but not used [-Wunused-const-variable=]
drivers/soc/mediatek/mtk-pmic-wrap.c:1953:34: warning: ‘of_slave_match_tbl’ defined but not used [-Wunused-const-variable=]
CC drivers/soc/mediatek/mtk-scpsys.o
drivers/soc/mediatek/mtk-scpsys.c:1084:34: warning: ‘of_scpsys_match_tbl’ defined but not used [-Wunused-const-variable=]
Looking at the code, both drivers can only bind to OF-defined device
nodes, so these drivers are useless without OF and should therefore
depend on it.
Developers or QA teams who wish to test-build the code can still do
so by enabling CONFIG_OF, which is available on all architectures and
has no dependencies.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202207240252.ZY5hSCNB-lkp@intel.com/
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Chenglin Xu <chenglin.xu@mediatek.com>
---
drivers/soc/mediatek/Kconfig | 2 ++
1 file changed, 2 insertions(+)
--- linux-5.18.orig/drivers/soc/mediatek/Kconfig 2022-05-22 21:52:31.000000000 +0200
+++ linux-5.18/drivers/soc/mediatek/Kconfig 2022-07-28 10:59:55.025131145 +0200
@@ -37,6 +37,7 @@ config MTK_INFRACFG
config MTK_PMIC_WRAP
tristate "MediaTek PMIC Wrapper Support"
depends on RESET_CONTROLLER
+ depends on OF
select REGMAP
help
Say yes here to add support for MediaTek PMIC Wrapper found
@@ -46,6 +47,7 @@ config MTK_PMIC_WRAP
config MTK_SCPSYS
bool "MediaTek SCPSYS Support"
default ARCH_MEDIATEK
+ depends on OF
select REGMAP
select MTK_INFRACFG
select PM_GENERIC_DOMAINS if PM
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: Let PMIC Wrapper and SCPSYS depend on OF
2022-07-28 9:22 [PATCH] soc: mediatek: Let PMIC Wrapper and SCPSYS depend on OF Jean Delvare
@ 2022-07-28 10:51 ` AngeloGioacchino Del Regno
2022-07-28 11:38 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-28 10:51 UTC (permalink / raw)
To: Jean Delvare, linux-mediatek, Matthias Brugger
Cc: Sean Wang, LKML, Chenglin Xu
Il 28/07/22 11:22, Jean Delvare ha scritto:
> With the following configuration options:
> CONFIG_OF is not set
> CONFIG_MTK_PMIC_WRAP=y
> CONFIG_MTK_SCPSYS=y
> we get the following build warnings:
>
> CC drivers/soc/mediatek/mtk-pmic-wrap.o
> drivers/soc/mediatek/mtk-pmic-wrap.c:2138:34: warning: ‘of_pwrap_match_tbl’ defined but not used [-Wunused-const-variable=]
> drivers/soc/mediatek/mtk-pmic-wrap.c:1953:34: warning: ‘of_slave_match_tbl’ defined but not used [-Wunused-const-variable=]
> CC drivers/soc/mediatek/mtk-scpsys.o
> drivers/soc/mediatek/mtk-scpsys.c:1084:34: warning: ‘of_scpsys_match_tbl’ defined but not used [-Wunused-const-variable=]
>
> Looking at the code, both drivers can only bind to OF-defined device
> nodes, so these drivers are useless without OF and should therefore
> depend on it.
>
Hello Jean,
I would prefer that you solve this warning by removing of_match_ptr() from both
drivers instead.
Regards,
Angelo
> Developers or QA teams who wish to test-build the code can still do
> so by enabling CONFIG_OF, which is available on all architectures and
> has no dependencies.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202207240252.ZY5hSCNB-lkp@intel.com/
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: Chenglin Xu <chenglin.xu@mediatek.com>
> ---
> drivers/soc/mediatek/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-5.18.orig/drivers/soc/mediatek/Kconfig 2022-05-22 21:52:31.000000000 +0200
> +++ linux-5.18/drivers/soc/mediatek/Kconfig 2022-07-28 10:59:55.025131145 +0200
> @@ -37,6 +37,7 @@ config MTK_INFRACFG
> config MTK_PMIC_WRAP
> tristate "MediaTek PMIC Wrapper Support"
> depends on RESET_CONTROLLER
> + depends on OF
> select REGMAP
> help
> Say yes here to add support for MediaTek PMIC Wrapper found
> @@ -46,6 +47,7 @@ config MTK_PMIC_WRAP
> config MTK_SCPSYS
> bool "MediaTek SCPSYS Support"
> default ARCH_MEDIATEK
> + depends on OF
> select REGMAP
> select MTK_INFRACFG
> select PM_GENERIC_DOMAINS if PM
>
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: Let PMIC Wrapper and SCPSYS depend on OF
2022-07-28 10:51 ` AngeloGioacchino Del Regno
@ 2022-07-28 11:38 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2022-07-28 11:38 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: linux-mediatek, Matthias Brugger, Sean Wang, LKML, Chenglin Xu
Hi Angelo,
On Thu, 28 Jul 2022 12:51:44 +0200, AngeloGioacchino Del Regno wrote:
> Il 28/07/22 11:22, Jean Delvare ha scritto:
> > With the following configuration options:
> > CONFIG_OF is not set
> > CONFIG_MTK_PMIC_WRAP=y
> > CONFIG_MTK_SCPSYS=y
> > we get the following build warnings:
> >
> > CC drivers/soc/mediatek/mtk-pmic-wrap.o
> > drivers/soc/mediatek/mtk-pmic-wrap.c:2138:34: warning: ‘of_pwrap_match_tbl’ defined but not used [-Wunused-const-variable=]
> > drivers/soc/mediatek/mtk-pmic-wrap.c:1953:34: warning: ‘of_slave_match_tbl’ defined but not used [-Wunused-const-variable=]
> > CC drivers/soc/mediatek/mtk-scpsys.o
> > drivers/soc/mediatek/mtk-scpsys.c:1084:34: warning: ‘of_scpsys_match_tbl’ defined but not used [-Wunused-const-variable=]
> >
> > Looking at the code, both drivers can only bind to OF-defined device
> > nodes, so these drivers are useless without OF and should therefore
> > depend on it.
>
> I would prefer that you solve this warning by removing of_match_ptr() from both
> drivers instead.
Actually we could do both. Once the drivers depend on OF,
of_match_ptr(_ptr) will always resolve to (_ptr) so we can indeed
save the preprocessor some work.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-28 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 9:22 [PATCH] soc: mediatek: Let PMIC Wrapper and SCPSYS depend on OF Jean Delvare
2022-07-28 10:51 ` AngeloGioacchino Del Regno
2022-07-28 11:38 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.