[Buildroot] [PATCH 1/1] package/pulseaudio: fix speex dependency

[Buildroot] [PATCH 1/1] package/pulseaudio: fix speex dependency

[Fabrice Fontaine]

pulseaudio needs speexdsp, not speex resulting in the following build
failure since commit 7752afbe4bb9fa1def5ba89daf21564ea58af79a which
explicitly enable or disable speex:

../output-1/build/pulseaudio-16.1/meson.build:713:2: ERROR: Dependency "speexdsp" not found, tried pkgconfig and cmake

Fixes:
 - http://autobuild.buildroot.org/results/8d4c5d5bfd65744753ca75180dd45a01c90f0b91

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/pulseaudio/pulseaudio.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/pulseaudio/pulseaudio.mk b/package/pulseaudio/pulseaudio.mk
index 7b2d362316..38be3fa141 100644
--- a/package/pulseaudio/pulseaudio.mk
+++ b/package/pulseaudio/pulseaudio.mk
@@ -162,9 +162,9 @@ else
 PULSEAUDIO_CONF_OPTS += -Dx11=disabled
 endif
 
-ifeq ($(BR2_PACKAGE_SPEEX),y)
+ifeq ($(BR2_PACKAGE_SPEEXDSP),y)
 PULSEAUDIO_CONF_OPTS += -Dspeex=enabled
-PULSEAUDIO_DEPENDENCIES += speex
+PULSEAUDIO_DEPENDENCIES += speexdsp
 else
 PULSEAUDIO_CONF_OPTS += -Dspeex=disabled
 endif
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pulseaudio: fix speex dependency

[Thomas Petazzoni via buildroot]

On Thu, 28 Jul 2022 13:52:04 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> pulseaudio needs speexdsp, not speex resulting in the following build
> failure since commit 7752afbe4bb9fa1def5ba89daf21564ea58af79a which
> explicitly enable or disable speex:
> 
> ../output-1/build/pulseaudio-16.1/meson.build:713:2: ERROR: Dependency "speexdsp" not found, tried pkgconfig and cmake
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/8d4c5d5bfd65744753ca75180dd45a01c90f0b91
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/pulseaudio/pulseaudio.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I have added a comment in the .mk file that will help us remember that
even though the option is named "speex", it really checks/needs
speexdsp as a dependency. Applied with this change.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot