[PATCH] configure: pass correct cflags to container-based cross compilers

[PATCH] configure: pass correct cflags to container-based cross compilers

[Paolo Bonzini]

probe_target_compiler returns nonempty $target_cc for installed toolchains
and $container_cross_cc for container-based toolchains.  In both cases
however the flags (coming from $cross_cc_cflags_${target_arch}) must be
in $target_cflags.

Therefore, do not clear them prior to returning from probe_target_compiler.

Reported-by: Taylor Simpson <tsimpson@quicinc.com>
Fixes: 92e288fcfb ("build: try both native and cross compilers", 2022-07-08)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure b/configure
index c4c02b8438..72ab03f11a 100755
--- a/configure
+++ b/configure
@@ -2173,7 +2173,6 @@ probe_target_compiler() {
     build_static=
     target_cc=
     target_ccas=
-    target_cflags=
     target_ar=
     target_as=
     target_ld=
-- 
2.36.1

Re: [PATCH] configure: pass correct cflags to container-based cross compilers

[Richard Henderson]

On 7/28/22 15:22, Paolo Bonzini wrote:
> probe_target_compiler returns nonempty $target_cc for installed toolchains
> and $container_cross_cc for container-based toolchains.  In both cases
> however the flags (coming from $cross_cc_cflags_${target_arch}) must be
> in $target_cflags.
> 
> Therefore, do not clear them prior to returning from probe_target_compiler.
> 
> Reported-by: Taylor Simpson <tsimpson@quicinc.com>
> Fixes: 92e288fcfb ("build: try both native and cross compilers", 2022-07-08)
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   configure | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/configure b/configure
> index c4c02b8438..72ab03f11a 100755
> --- a/configure
> +++ b/configure
> @@ -2173,7 +2173,6 @@ probe_target_compiler() {
>       build_static=
>       target_cc=
>       target_ccas=
> -    target_cflags=
>       target_ar=
>       target_as=
>       target_ld=

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

RE: [PATCH] configure: pass correct cflags to container-based cross compilers

[Taylor Simpson]

> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Thursday, July 28, 2022 5:11 PM
> To: Paolo Bonzini <pbonzini@redhat.com>; qemu-devel@nongnu.org
> Cc: Taylor Simpson <tsimpson@quicinc.com>
> Subject: Re: [PATCH] configure: pass correct cflags to container-based cross
> compilers
> 
> On 7/28/22 15:22, Paolo Bonzini wrote:
> > probe_target_compiler returns nonempty $target_cc for installed
> > toolchains and $container_cross_cc for container-based toolchains.  In
> > both cases however the flags (coming from
> > $cross_cc_cflags_${target_arch}) must be in $target_cflags.
> >
> > Therefore, do not clear them prior to returning from
> probe_target_compiler.
> >
> > Reported-by: Taylor Simpson <tsimpson@quicinc.com>
> > Fixes: 92e288fcfb ("build: try both native and cross compilers",
> > 2022-07-08)
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >   configure | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index c4c02b8438..72ab03f11a 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2173,7 +2173,6 @@ probe_target_compiler() {
> >       build_static=
> >       target_cc=
> >       target_ccas=
> > -    target_cflags=
> >       target_ar=
> >       target_as=
> >       target_ld=
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> r~

Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>