[RFC PATCH bpf-next 00/15] bpf: Introduce selectable memcg for bpf map

* [RFC PATCH bpf-next 00/15] bpf: Introduce selectable memcg for bpf map
@ 2022-07-29 15:23 Yafang Shao
  2022-07-29 15:23 ` [RFC PATCH bpf-next 01/15] bpf: Remove unneeded memset in queue_stack_map creation Yafang Shao
                   ` (14 more replies)
  0 siblings, 15 replies; 24+ messages in thread
From: Yafang Shao @ 2022-07-29 15:23 UTC (permalink / raw)
  To: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend,
	kpsingh, sdf, haoluo, jolsa, hannes, mhocko, roman.gushchin,
	shakeelb, songmuchun, akpm
  Cc: netdev, bpf, linux-mm, Yafang Shao

On our production environment, we may load, run and pin bpf programs and
maps in containers. For example, some of our networking bpf programs and
maps are loaded and pinned by a process running in a container on our
k8s environment. In this container, there're also running some other
user applications which watch the networking configurations from remote
servers and update them on this local host, log the error events, monitor
the traffic, and do some other stuffs. Sometimes we may need to update 
these user applications to a new release, and in this update process we
will destroy the old container and then start a new genration. In order not
to interrupt the bpf programs in the update process, we will pin the bpf
programs and maps in bpffs. That is the background and use case on our
production environment. 

After switching to memcg-based bpf memory accounting to limit the bpf
memory, some unexpected issues jumped out at us.
1. The memory usage is not consistent between the first generation and
new generations.
2. After the first generation is destroyed, the bpf memory can't be
limited if the bpf maps are not preallocated, because they will be
reparented.

This patchset tries to resolve these issues by introducing an
independent memcg to limit the bpf memory.

In the bpf map creation, we can assign a specific memcg instead of using
the current memcg.  That makes it flexible in containized environment.
For example, if we want to limit the pinned bpf maps, we can use below
hierarchy,

    Shared resources             Private resources 

     bpf-memcg                      k8s-memcg
     /        \                     /             
bpf-bar-memcg bpf-foo-memcg   srv-foo-memcg        
                  |               /        \
               (charged)     (not charged) (charged)                 
                  |           /              \
                  |          /                \
          bpf-foo-{progs, maps}              srv-foo

srv-foo loads and pins bpf-foo-{progs, maps}, but they are charged to an
independent memcg (bpf-foo-memcg) instead of srv-foo's memcg
(srv-foo-memcg).

Pls. note that there may be no process in bpf-foo-memcg, that means it
can be rmdir-ed by root user currently. Meanwhile we don't forcefully
destroy a memcg if it doesn't have any residents. So this hierarchy is
acceptible. 

In order to make the memcg of bpf maps seletectable, this patchset
introduces some memory allocation wrappers to allocate map related
memory. In these wrappers, it will get the memcg from the map and then
charge the allocated pages or objs.  

Currenly it only supports for bpf map, and we can extend it to bpf prog
as well. It only supports for cgroup2 now, but we can make an additional
change in cgroup_get_from_fd() to support it for cgroup1. 

The observebility can also be supported in the next step, for example,
showing the bpf map's memcg by 'bpftool map show' or even showing which
maps are charged to a specific memcg by 'bpftool cgroup show'.
Furthermore, we may also show an accurate memory size of a bpf map
instead of an estimated memory size in 'bpftool map show' in the future. 

Yafang Shao (15):
  bpf: Remove unneeded memset in queue_stack_map creation
  bpf: Use bpf_map_area_free instread of kvfree
  bpf: Make __GFP_NOWARN consistent in bpf map creation
  bpf: Use bpf_map_area_alloc consistently on bpf map creation
  bpf: Introduce helpers for container of struct bpf_map
  bpf: Use bpf_map_container_alloc helpers in various bpf maps
  bpf: Define bpf_map_get_memcg for !CONFIG_MEMCG_KMEM
  bpf: Use scope-based charge for bpf_map_area_alloc
  bpf: Use bpf_map_kzalloc in arraymap
  bpf: Use bpf_map_pages_alloc in ringbuf
  bpf: Use bpf_map_kvcalloc in bpf_local_storage
  mm, memcg: Add new helper get_obj_cgroup_from_cgroup
  bpf: Add new parameter into bpf_map_container_alloc
  bpf: Add new map flag BPF_F_SELECTABLE_MEMCG
  bpf: Introduce selectable memcg for bpf map

 include/linux/bpf.h            |  19 +++-
 include/linux/memcontrol.h     |  11 ++
 include/uapi/linux/bpf.h       |   5 +
 kernel/bpf/arraymap.c          |  46 ++++----
 kernel/bpf/bloom_filter.c      |  13 ++-
 kernel/bpf/bpf_local_storage.c |  17 +--
 kernel/bpf/bpf_struct_ops.c    |  17 +--
 kernel/bpf/cpumap.c            |  12 +-
 kernel/bpf/devmap.c            |  26 +++--
 kernel/bpf/hashtab.c           |  17 +--
 kernel/bpf/local_storage.c     |  11 +-
 kernel/bpf/lpm_trie.c          |   8 +-
 kernel/bpf/offload.c           |   6 +-
 kernel/bpf/queue_stack_maps.c  |  12 +-
 kernel/bpf/reuseport_array.c   |   9 +-
 kernel/bpf/ringbuf.c           |  57 +++++-----
 kernel/bpf/stackmap.c          |  15 +--
 kernel/bpf/syscall.c           | 197 ++++++++++++++++++++++++++++-----
 mm/memcontrol.c                |  41 +++++++
 net/core/sock_map.c            |  31 +++---
 net/xdp/xskmap.c               |   8 +-
 tools/include/uapi/linux/bpf.h |   5 +
 tools/lib/bpf/bpf.c            |   1 +
 tools/lib/bpf/bpf.h            |   3 +-
 tools/lib/bpf/libbpf.c         |   2 +
 25 files changed, 411 insertions(+), 178 deletions(-)

-- 
2.17.1

^ permalink raw reply	[flat|nested] 24+ messages in thread