[Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Fabrice Fontaine]

Commit 505b5a6cdd337c2fd5965aa875a1a53419d62ed1 wrongly stated that "a
configure script bundled with a package may be generated with an older
version of Autotools, that may not yet support the --runstatedir option.
This will give an "Unsupported arguments" warning and the option will be
ignored.". Indeed, this will raise the following build failure with
attr, libtirpc, readline, etc.:

configure: error: unrecognized option: `--runstatedir=/run'

So to support configure scripts using older version, the variable is set
directly instead of using the --runstatedir argument.

Fixes:
 - http://autobuild.buildroot.org/results/c853f14773d875be30e32ae24daf80e181fef34e
 - http://autobuild.buildroot.org/results/045211cd66cf78c3d89d2d8ac41ec4edf0b0ee58
 - http://autobuild.buildroot.org/results/8c5160eef99de2f1f72f33d5e5ea94d417855b2c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Thomas Petazzoni):
 - Remove revert sentence

 package/pkg-autotools.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
index 548f69cbb8..b6224b349d 100644
--- a/package/pkg-autotools.mk
+++ b/package/pkg-autotools.mk
@@ -187,7 +187,7 @@ define $(2)_CONFIGURE_CMDS
 		--exec-prefix=/usr \
 		--sysconfdir=/etc \
 		--localstatedir=/var \
-		--runstatedir=/run \
+		runstatedir=/run \
 		--program-prefix="" \
 		--disable-gtk-doc \
 		--disable-gtk-doc-html \
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Thomas Petazzoni via buildroot]

On Fri, 29 Jul 2022 17:46:37 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Commit 505b5a6cdd337c2fd5965aa875a1a53419d62ed1 wrongly stated that "a
> configure script bundled with a package may be generated with an older
> version of Autotools, that may not yet support the --runstatedir option.
> This will give an "Unsupported arguments" warning and the option will be
> ignored.". Indeed, this will raise the following build failure with
> attr, libtirpc, readline, etc.:
> 
> configure: error: unrecognized option: `--runstatedir=/run'
> 
> So to support configure scripts using older version, the variable is set
> directly instead of using the --runstatedir argument.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/c853f14773d875be30e32ae24daf80e181fef34e
>  - http://autobuild.buildroot.org/results/045211cd66cf78c3d89d2d8ac41ec4edf0b0ee58
>  - http://autobuild.buildroot.org/results/8c5160eef99de2f1f72f33d5e5ea94d417855b2c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
>  - Remove revert sentence

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Thomas Petazzoni via buildroot]

Hello,

On Fri, 29 Jul 2022 17:46:37 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> index 548f69cbb8..b6224b349d 100644
> --- a/package/pkg-autotools.mk
> +++ b/package/pkg-autotools.mk
> @@ -187,7 +187,7 @@ define $(2)_CONFIGURE_CMDS
>  		--exec-prefix=/usr \
>  		--sysconfdir=/etc \
>  		--localstatedir=/var \
> -		--runstatedir=/run \
> +		runstatedir=/run \

I am afraid this is causing some other problems:

  http://autobuild.buildroot.net/results/c6f/c6fa72802a3d74fe95720eeff836514a5863b3f2/build-end.log

configure: warning: runstatedir=/run: invalid host type
loading site script /dev/null
creating cache ./config.cache
configure: error: can only configure for one host and one target at a time

So I believe we will have to revert this patch, and pass --runstatedir
individually to those packages that understand this option.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Norbert Lange]

Am Mo., 1. Aug. 2022 um 18:54 Uhr schrieb Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> Hello,
>
> On Fri, 29 Jul 2022 17:46:37 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> > index 548f69cbb8..b6224b349d 100644
> > --- a/package/pkg-autotools.mk
> > +++ b/package/pkg-autotools.mk
> > @@ -187,7 +187,7 @@ define $(2)_CONFIGURE_CMDS
> >               --exec-prefix=/usr \
> >               --sysconfdir=/etc \
> >               --localstatedir=/var \
> > -             --runstatedir=/run \
> > +             runstatedir=/run \
>
> I am afraid this is causing some other problems:
>
>   http://autobuild.buildroot.net/results/c6f/c6fa72802a3d74fe95720eeff836514a5863b3f2/build-end.log
>
> configure: warning: runstatedir=/run: invalid host type
> loading site script /dev/null
> creating cache ./config.cache
> configure: error: can only configure for one host and one target at a time
>
> So I believe we will have to revert this patch, and pass --runstatedir
> individually to those packages that understand this option.

Sorry for raising autohell, "runstatedir=/run" was somehow supposed to
set the default.
Arguably the package is at fault, but thats not helping much.

So far this solution seems to cover all problems:

--localstatedir=/var \
`grep -q -e '--runstatedir\b' configure && echo --runstatedir=/run` \
--program-prefix="" \

You want to revert first?

Norbert
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Thomas Petazzoni via buildroot]

Hello,

On Tue, 2 Aug 2022 09:55:33 +0200
Norbert Lange <nolange79@gmail.com> wrote:

> > So I believe we will have to revert this patch, and pass --runstatedir
> > individually to those packages that understand this option.  
> 
> Sorry for raising autohell, "runstatedir=/run" was somehow supposed to
> set the default.
> Arguably the package is at fault, but thats not helping much.

If "wipe" is the only misbehaving package because it does something
particularly incorrect, I am fine with fixing that particular package
and keep the runstatedir=/run.

> So far this solution seems to cover all problems:
> 
> --localstatedir=/var \
> `grep -q -e '--runstatedir\b' configure && echo --runstatedir=/run` \
> --program-prefix="" \

Meh, I see the idea, but it doesn't look like a great solution :-/

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Norbert Lange]

Am Di., 2. Aug. 2022 um 10:40 Uhr schrieb Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> Hello,
>
> On Tue, 2 Aug 2022 09:55:33 +0200
> Norbert Lange <nolange79@gmail.com> wrote:
>
> > > So I believe we will have to revert this patch, and pass --runstatedir
> > > individually to those packages that understand this option.
> >
> > Sorry for raising autohell, "runstatedir=/run" was somehow supposed to
> > set the default.
> > Arguably the package is at fault, but thats not helping much.
>
> If "wipe" is the only misbehaving package because it does something
> particularly incorrect, I am fine with fixing that particular package
> and keep the runstatedir=/run.

wipe doesn't have a configure.ac and autoconf'ed with a really old
version.
WIPE_AUTORECONF = YES should fix it.

Guess we only know when other failures wash up.

>
> > So far this solution seems to cover all problems:
> >
> > --localstatedir=/var \
> > `grep -q -e '--runstatedir\b' configure && echo --runstatedir=/run` \
> > --program-prefix="" \
>
> Meh, I see the idea, but it doesn't look like a great solution :-/

Never said that ;)

>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Norbert
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Thomas Petazzoni via buildroot]

On Tue, 2 Aug 2022 10:49:31 +0200
Norbert Lange <nolange79@gmail.com> wrote:

> wipe doesn't have a configure.ac and autoconf'ed with a really old
> version.
> WIPE_AUTORECONF = YES should fix it.

Could you try if it does? If so, I think this is OK. We will see how
many other packages are affected. If only wipe is affected, fixing wipe
is fine. If too many packages are affected, we will have to think of a
different solution.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Norbert Lange]

Am Di., 2. Aug. 2022 um 11:39 Uhr schrieb Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> On Tue, 2 Aug 2022 10:49:31 +0200
> Norbert Lange <nolange79@gmail.com> wrote:
>
> > wipe doesn't have a configure.ac and autoconf'ed with a really old
> > version.
> > WIPE_AUTORECONF = YES should fix it.
>
> Could you try if it does? If so, I think this is OK. We will see how
> many other packages are affected. If only wipe is affected, fixing wipe
> is fine. If too many packages are affected, we will have to think of a
> different solution.

Gives alot warnings, but yes, fixes the issue.

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Norbert
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Thomas Petazzoni via buildroot]

On Tue, 2 Aug 2022 12:45:01 +0200
Norbert Lange <nolange79@gmail.com> wrote:

> > Could you try if it does? If so, I think this is OK. We will see how
> > many other packages are affected. If only wipe is affected, fixing wipe
> > is fine. If too many packages are affected, we will have to think of a
> > different solution.  
> 
> Gives alot warnings, but yes, fixes the issue.

Will you send a patch?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Thomas Petazzoni via buildroot]

Hello,

On Mon, 1 Aug 2022 18:54:44 +0200
Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:

> I am afraid this is causing some other problems:
> 
>   http://autobuild.buildroot.net/results/c6f/c6fa72802a3d74fe95720eeff836514a5863b3f2/build-end.log
> 
> configure: warning: runstatedir=/run: invalid host type
> loading site script /dev/null
> creating cache ./config.cache
> configure: error: can only configure for one host and one target at a time
> 
> So I believe we will have to revert this patch, and pass --runstatedir
> individually to those packages that understand this option.

Another package exhibiting the same issue:

  http://autobuild.buildroot.net/results/391/391871b766ba0c1aeef8ff2d4daad8f4204f86ad/build-end.log

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Fabrice Fontaine]

[-- Attachment #1.1: Type: text/plain, Size: 1197 bytes --]

Hello,

Le jeu. 11 août 2022 à 22:37, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
a écrit :

> Hello,
>
> On Mon, 1 Aug 2022 18:54:44 +0200
> Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:
>
> > I am afraid this is causing some other problems:
> >
> >
> http://autobuild.buildroot.net/results/c6f/c6fa72802a3d74fe95720eeff836514a5863b3f2/build-end.log
> >
> > configure: warning: runstatedir=/run: invalid host type
> > loading site script /dev/null
> > creating cache ./config.cache
> > configure: error: can only configure for one host and one target at a
> time
> >
> > So I believe we will have to revert this patch, and pass --runstatedir
> > individually to those packages that understand this option.
>
> Another package exhibiting the same issue:
>
>
> http://autobuild.buildroot.net/results/391/391871b766ba0c1aeef8ff2d4daad8f4204f86ad/build-end.log
>

Indeed, I tried to run autoreconf on thttpd but it raises another build
failure.


>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

Best Regards,

Fabrice

[-- Attachment #1.2: Type: text/html, Size: 2233 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 1/1] package/pkg-autotools: fix runtime path

[Peter Korsgaard]

On 02/08/2022 10.40, Thomas Petazzoni via buildroot wrote:

>> So far this solution seems to cover all problems:
>>
>> --localstatedir=/var \
>> `grep -q -e '--runstatedir\b' configure && echo --runstatedir=/run` \
>> --program-prefix="" \
> 
> Meh, I see the idea, but it doesn't look like a great solution :-/

It is ugly, but effective.

We're now >1 month later, but the issues are still not fixed. Thttpd and 
wipe uses autoconf 2.13, so they are broken and this libgpg-error issue 
is possibly not related (I am unable to reproduce it here though):

http://autobuild.buildroot.net/results/658/65882e1f266e818fecef2892c9493d3b8e1e912e/

What do we do for 2022.08? Revert the whole runtime path logic or add a 
new-enough-configure-script detection logic as suggested above by Norbert?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot