[Buildroot] [PATCH 1/2] toolchain/Config.in: fix BR2_TOOLCHAIN_HAS_GCC_BUG_99140 number

[Buildroot] [PATCH 1/2] toolchain/Config.in: fix BR2_TOOLCHAIN_HAS_GCC_BUG_99140 number

[Giulio Benetti]

While introducing gcc bug 99410 I've named BR2_TOOLCHAIN_HAS_GCC_BUG_ to
99140 that is wrong. So let's fix this by changing bug option to
BR2_TOOLCHAIN_HAS_GCC_BUG_99410.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/belle-sip/belle-sip.mk | 2 +-
 toolchain/Config.in            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/belle-sip/belle-sip.mk b/package/belle-sip/belle-sip.mk
index 11b96f3fd9..51e017000c 100644
--- a/package/belle-sip/belle-sip.mk
+++ b/package/belle-sip/belle-sip.mk
@@ -35,7 +35,7 @@ endif
 
 BELLE_SIP_CFLAGS = $(TARGET_CFLAGS)
 
-ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_99140),y)
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_99410)
 BELLE_SIP_CFLAGS += -O0
 endif
 
diff --git a/toolchain/Config.in b/toolchain/Config.in
index 6d12b6fed7..722bdb2de0 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -188,7 +188,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
 # Error: branch offset out of range on Nios II. This bug
 # no longer exists in gcc 8.x but reappeared on gcc 9.x and has been
 # fixed on gcc 11.x.
-config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
+config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
 	bool
 	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
 	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] toolchain/Config.in: update gcc bug 99410

[Giulio Benetti]

Gcc bug 99410 reappeared while building with gcc 11.x and while testing it
also shows up with gcc 12.x, so let's enable this bug for all gcc versions
except gcc 8.x.

Fixes:
autobuild.buildroot.net/results/64e/64e54ef5ba3a3dee391b788315615d57a1dd9fa2/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 toolchain/Config.in | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 722bdb2de0..a71a0db83b 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -186,12 +186,13 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99410
 # Error: branch offset out of range on Nios II. This bug
-# no longer exists in gcc 8.x but reappeared on gcc 9.x and has been
-# fixed on gcc 11.x.
+# no longer exists in gcc 8.x but reappeared on gcc 9.x and still exists
+# on gcc 12.x
 config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
 	bool
-	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
-	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
+	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
+		     BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
+		     BR2_TOOLCHAIN_GCC_AT_LEAST_12
 	depends on BR2_nios2
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101737
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] toolchain/Config.in: update gcc bug 99410

[Giulio Benetti]

On 29/07/22 18:24, Giulio Benetti wrote:
> Gcc bug 99410 reappeared while building with gcc 11.x and while testing it
> also shows up with gcc 12.x, so let's enable this bug for all gcc versions
> except gcc 8.x.
> 
> Fixes:
> autobuild.buildroot.net/results/64e/64e54ef5ba3a3dee391b788315615d57a1dd9fa2/

Sorry, I've forgotten http://

-- 
Giulio Benetti
Benetti Engineering sas

> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   toolchain/Config.in | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 722bdb2de0..a71a0db83b 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -186,12 +186,13 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
>   
>   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99410
>   # Error: branch offset out of range on Nios II. This bug
> -# no longer exists in gcc 8.x but reappeared on gcc 9.x and has been
> -# fixed on gcc 11.x.
> +# no longer exists in gcc 8.x but reappeared on gcc 9.x and still exists
> +# on gcc 12.x
>   config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
>   	bool
> -	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
> -	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
> +	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
> +		     BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
> +		     BR2_TOOLCHAIN_GCC_AT_LEAST_12
>   	depends on BR2_nios2
>   
>   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101737

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: fix BR2_TOOLCHAIN_HAS_GCC_BUG_99140 number

[Arnout Vandecappelle]

On 29/07/2022 18:24, Giulio Benetti wrote:
> While introducing gcc bug 99410 I've named BR2_TOOLCHAIN_HAS_GCC_BUG_ to
> 99140 that is wrong. So let's fix this by changing bug option to
> BR2_TOOLCHAIN_HAS_GCC_BUG_99410.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   package/belle-sip/belle-sip.mk | 2 +-
>   toolchain/Config.in            | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/belle-sip/belle-sip.mk b/package/belle-sip/belle-sip.mk
> index 11b96f3fd9..51e017000c 100644
> --- a/package/belle-sip/belle-sip.mk
> +++ b/package/belle-sip/belle-sip.mk
> @@ -35,7 +35,7 @@ endif
>   
>   BELLE_SIP_CFLAGS = $(TARGET_CFLAGS)
>   
> -ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_99140),y)
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_99410)

  Something went wrong here... ,y) dropped off.

  Regards,
  Arnout

>   BELLE_SIP_CFLAGS += -O0
>   endif
>   
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 6d12b6fed7..722bdb2de0 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -188,7 +188,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
>   # Error: branch offset out of range on Nios II. This bug
>   # no longer exists in gcc 8.x but reappeared on gcc 9.x and has been
>   # fixed on gcc 11.x.
> -config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
> +config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
>   	bool
>   	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
>   	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: fix BR2_TOOLCHAIN_HAS_GCC_BUG_99140 number

[Thomas Petazzoni via buildroot]

On Fri, 29 Jul 2022 18:24:29 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> While introducing gcc bug 99410 I've named BR2_TOOLCHAIN_HAS_GCC_BUG_ to
> 99140 that is wrong. So let's fix this by changing bug option to
> BR2_TOOLCHAIN_HAS_GCC_BUG_99410.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/belle-sip/belle-sip.mk | 2 +-
>  toolchain/Config.in            | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied after fixing the typo noticed by Arnout.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] toolchain/Config.in: update gcc bug 99410

[Thomas Petazzoni via buildroot]

On Fri, 29 Jul 2022 18:24:30 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

>  config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
>  	bool
> -	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
> -	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
> +	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
> +		     BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
> +		     BR2_TOOLCHAIN_GCC_AT_LEAST_12

This looks like a very convoluted way, that can be replaced with:

config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
	bool
	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9

This says:

 - The bug is present if you don't have at least gcc 8.x (so versions
   older than gcc 8.x are affected)

 - The bug is present if you have at least gcc 9.x (so all versions
   more recent than 9.x included are affected)

So I replaced it with that. Let me know if you see a problem with this
change.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] toolchain/Config.in: update gcc bug 99410

[Giulio Benetti]

On 29/07/22 21:55, Thomas Petazzoni via buildroot wrote:
> On Fri, 29 Jul 2022 18:24:30 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>>   config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
>>   	bool
>> -	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
>> -	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
>> +	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
>> +		     BR2_TOOLCHAIN_GCC_AT_LEAST_10 || BR2_TOOLCHAIN_GCC_AT_LEAST_11 || \
>> +		     BR2_TOOLCHAIN_GCC_AT_LEAST_12
> 
> This looks like a very convoluted way, that can be replaced with:
> 
> config BR2_TOOLCHAIN_HAS_GCC_BUG_99410
> 	bool
> 	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
> 	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9
> 
> This says:
> 
>   - The bug is present if you don't have at least gcc 8.x (so versions
>     older than gcc 8.x are affected)
> 
>   - The bug is present if you have at least gcc 9.x (so all versions
>     more recent than 9.x included are affected)
> 
> So I replaced it with that. Let me know if you see a problem with this
> change.

That's true, thank you.

So I can improve also bugs:
BR2_TOOLCHAIN_HAS_GCC_BUG_43744
BR2_TOOLCHAIN_HAS_GCC_BUG_83143

This way we're also sure we always deal with latest gcc version.
What about it?

-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] toolchain/Config.in: update gcc bug 99410

[Thomas Petazzoni via buildroot]

On Fri, 29 Jul 2022 22:22:56 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> So I can improve also bugs:
> BR2_TOOLCHAIN_HAS_GCC_BUG_43744
> BR2_TOOLCHAIN_HAS_GCC_BUG_83143
> 
> This way we're also sure we always deal with latest gcc version.
> What about it?

Sure!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: fix BR2_TOOLCHAIN_HAS_GCC_BUG_99140 number

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > While introducing gcc bug 99410 I've named BR2_TOOLCHAIN_HAS_GCC_BUG_ to
 > 99140 that is wrong. So let's fix this by changing bug option to
 > BR2_TOOLCHAIN_HAS_GCC_BUG_99410.

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] toolchain/Config.in: update gcc bug 99410

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > Gcc bug 99410 reappeared while building with gcc 11.x and while testing it
 > also shows up with gcc 12.x, so let's enable this bug for all gcc versions
 > except gcc 8.x.

 > Fixes:
 > autobuild.buildroot.net/results/64e/64e54ef5ba3a3dee391b788315615d57a1dd9fa2/

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot