* [PATCH] iio: Add names for function definition arguments.
@ 2022-07-31 16:01 Joe Simmons-Talbott
2022-08-06 16:18 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Joe Simmons-Talbott @ 2022-07-31 16:01 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, linux-iio, linux-kernel
Cc: Joe Simmons-Talbott
As reported by checkpatch.pl add missing names for function definition
arguments.
Signed-off-by: Joe Simmons-Talbott <joetalbott@gmail.com>
---
drivers/iio/industrialio-event.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
index b5e059e15b0a..0e2056894965 100644
--- a/drivers/iio/industrialio-event.c
+++ b/drivers/iio/industrialio-event.c
@@ -354,9 +354,10 @@ static int iio_device_add_event(struct iio_dev *indio_dev,
enum iio_shared_by shared_by, const unsigned long *mask)
{
struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
- ssize_t (*show)(struct device *, struct device_attribute *, char *);
- ssize_t (*store)(struct device *, struct device_attribute *,
- const char *, size_t);
+ ssize_t (*show)(struct device *dev, struct device_attribute *attr,
+ char *buf);
+ ssize_t (*store)(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t len);
unsigned int attrcount = 0;
unsigned int i;
char *postfix;
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: Add names for function definition arguments.
2022-07-31 16:01 [PATCH] iio: Add names for function definition arguments Joe Simmons-Talbott
@ 2022-08-06 16:18 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-08-06 16:18 UTC (permalink / raw)
To: Joe Simmons-Talbott; +Cc: Lars-Peter Clausen, linux-iio, linux-kernel
On Sun, 31 Jul 2022 12:01:20 -0400
Joe Simmons-Talbott <joetalbott@gmail.com> wrote:
> As reported by checkpatch.pl add missing names for function definition
> arguments.
>
> Signed-off-by: Joe Simmons-Talbott <joetalbott@gmail.com>
Hi Joe,
I took this last week. Not sure why email didn't hit the list.
Thanks,
Jonathan
> ---
> drivers/iio/industrialio-event.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index b5e059e15b0a..0e2056894965 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -354,9 +354,10 @@ static int iio_device_add_event(struct iio_dev *indio_dev,
> enum iio_shared_by shared_by, const unsigned long *mask)
> {
> struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
> - ssize_t (*show)(struct device *, struct device_attribute *, char *);
> - ssize_t (*store)(struct device *, struct device_attribute *,
> - const char *, size_t);
> + ssize_t (*show)(struct device *dev, struct device_attribute *attr,
> + char *buf);
> + ssize_t (*store)(struct device *dev, struct device_attribute *attr,
> + const char *buf, size_t len);
> unsigned int attrcount = 0;
> unsigned int i;
> char *postfix;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-06 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-31 16:01 [PATCH] iio: Add names for function definition arguments Joe Simmons-Talbott
2022-08-06 16:18 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.