* [PATCH] drm/bridge: lvds-codec: Fix error checking of drm_of_lvds_get_data_mapping()
@ 2022-08-01 12:54 Marek Vasut
2022-08-10 9:27 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2022-08-01 12:54 UTC (permalink / raw)
To: dri-devel; +Cc: Marek Vasut, Sam Ravnborg, Laurent Pinchart, robert.foss
The drm_of_lvds_get_data_mapping() returns either negative value on
error or MEDIA_BUS_FMT_* otherwise. The check for 'ret' would also
catch the positive case of MEDIA_BUS_FMT_* and lead to probe failure
every time 'data-mapping' DT property is specified.
Fixes: 7c4dd0a266527 ("drm: of: Add drm_of_lvds_get_data_mapping")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
To: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/bridge/lvds-codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
index 702ea803a743c..39e7004de7200 100644
--- a/drivers/gpu/drm/bridge/lvds-codec.c
+++ b/drivers/gpu/drm/bridge/lvds-codec.c
@@ -180,7 +180,7 @@ static int lvds_codec_probe(struct platform_device *pdev)
of_node_put(bus_node);
if (ret == -ENODEV) {
dev_warn(dev, "missing 'data-mapping' DT property\n");
- } else if (ret) {
+ } else if (ret < 0) {
dev_err(dev, "invalid 'data-mapping' DT property\n");
return ret;
} else {
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: lvds-codec: Fix error checking of drm_of_lvds_get_data_mapping()
2022-08-01 12:54 [PATCH] drm/bridge: lvds-codec: Fix error checking of drm_of_lvds_get_data_mapping() Marek Vasut
@ 2022-08-10 9:27 ` Neil Armstrong
2022-08-29 15:32 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2022-08-10 9:27 UTC (permalink / raw)
To: Marek Vasut, dri-devel; +Cc: Sam Ravnborg, Laurent Pinchart, robert.foss
On 01/08/2022 14:54, Marek Vasut wrote:
> The drm_of_lvds_get_data_mapping() returns either negative value on
> error or MEDIA_BUS_FMT_* otherwise. The check for 'ret' would also
> catch the positive case of MEDIA_BUS_FMT_* and lead to probe failure
> every time 'data-mapping' DT property is specified.
>
> Fixes: 7c4dd0a266527 ("drm: of: Add drm_of_lvds_get_data_mapping")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> To: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/bridge/lvds-codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
> index 702ea803a743c..39e7004de7200 100644
> --- a/drivers/gpu/drm/bridge/lvds-codec.c
> +++ b/drivers/gpu/drm/bridge/lvds-codec.c
> @@ -180,7 +180,7 @@ static int lvds_codec_probe(struct platform_device *pdev)
> of_node_put(bus_node);
> if (ret == -ENODEV) {
> dev_warn(dev, "missing 'data-mapping' DT property\n");
> - } else if (ret) {
> + } else if (ret < 0) {
> dev_err(dev, "invalid 'data-mapping' DT property\n");
> return ret;
> } else {
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: lvds-codec: Fix error checking of drm_of_lvds_get_data_mapping()
2022-08-10 9:27 ` Neil Armstrong
@ 2022-08-29 15:32 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-08-29 15:32 UTC (permalink / raw)
To: Neil Armstrong; +Cc: Marek Vasut, Sam Ravnborg, Laurent Pinchart, dri-devel
On Wed, 10 Aug 2022 at 11:27, Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> On 01/08/2022 14:54, Marek Vasut wrote:
> > The drm_of_lvds_get_data_mapping() returns either negative value on
> > error or MEDIA_BUS_FMT_* otherwise. The check for 'ret' would also
> > catch the positive case of MEDIA_BUS_FMT_* and lead to probe failure
> > every time 'data-mapping' DT property is specified.
> >
> > Fixes: 7c4dd0a266527 ("drm: of: Add drm_of_lvds_get_data_mapping")
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > To: dri-devel@lists.freedesktop.org
> > ---
> > drivers/gpu/drm/bridge/lvds-codec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
> > index 702ea803a743c..39e7004de7200 100644
> > --- a/drivers/gpu/drm/bridge/lvds-codec.c
> > +++ b/drivers/gpu/drm/bridge/lvds-codec.c
> > @@ -180,7 +180,7 @@ static int lvds_codec_probe(struct platform_device *pdev)
> > of_node_put(bus_node);
> > if (ret == -ENODEV) {
> > dev_warn(dev, "missing 'data-mapping' DT property\n");
> > - } else if (ret) {
> > + } else if (ret < 0) {
> > dev_err(dev, "invalid 'data-mapping' DT property\n");
> > return ret;
> > } else {
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-29 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01 12:54 [PATCH] drm/bridge: lvds-codec: Fix error checking of drm_of_lvds_get_data_mapping() Marek Vasut
2022-08-10 9:27 ` Neil Armstrong
2022-08-29 15:32 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.