From: Rob Herring <robh@kernel.org> To: Marek Vasut <marex@denx.de> Cc: dri-devel@lists.freedesktop.org, robert.foss@linaro.org, Jagan Teki <jagan@amarulasolutions.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Linus Walleij <linus.walleij@linaro.org>, Sam Ravnborg <sam@ravnborg.org>, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap Date: Mon, 1 Aug 2022 10:32:38 -0600 [thread overview] Message-ID: <20220801163238.GA1130127-robh@kernel.org> (raw) In-Reply-To: <20220801131901.183090-1-marex@denx.de> On Mon, Aug 01, 2022 at 03:19:00PM +0200, Marek Vasut wrote: > The ICN6211 is capable of swapping the output DPI RGB/BGR color channels, > document a DT property to select this swap in DT. This can be useful on > hardware where such swap happens. We should ensure this series[1] works for you instead. > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Rob Herring <robh@kernel.org> > Cc: Robert Foss <robert.foss@linaro.org> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: dri-devel@lists.freedesktop.org > Cc: devicetree@vger.kernel.org > --- > .../devicetree/bindings/display/bridge/chipone,icn6211.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > index 18563ebed1a96..e721dd76e6640 100644 > --- a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > @@ -33,6 +33,12 @@ properties: > Optional external clock connected to REF_CLK input. > The clock rate must be in 10..154 MHz range. > > + blue-and-red-swap: 'swap' assumes I know the default order and I don't. Better to make the property name describe the end result. ('invert' properties have the same issue) > + description: > + If defined, the DPI output blue and red channels are swapped, > + i.e. RGB becomes BGR. > + type: boolean > + > enable-gpios: > description: Bridge EN pin, chip is reset when EN is low. Rob [1] https://lore.kernel.org/r/20220628181838.2031-3-max.oss.09@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Marek Vasut <marex@denx.de> Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, robert.foss@linaro.org, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Sam Ravnborg <sam@ravnborg.org>, Jagan Teki <jagan@amarulasolutions.com> Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap Date: Mon, 1 Aug 2022 10:32:38 -0600 [thread overview] Message-ID: <20220801163238.GA1130127-robh@kernel.org> (raw) In-Reply-To: <20220801131901.183090-1-marex@denx.de> On Mon, Aug 01, 2022 at 03:19:00PM +0200, Marek Vasut wrote: > The ICN6211 is capable of swapping the output DPI RGB/BGR color channels, > document a DT property to select this swap in DT. This can be useful on > hardware where such swap happens. We should ensure this series[1] works for you instead. > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Rob Herring <robh@kernel.org> > Cc: Robert Foss <robert.foss@linaro.org> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: dri-devel@lists.freedesktop.org > Cc: devicetree@vger.kernel.org > --- > .../devicetree/bindings/display/bridge/chipone,icn6211.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > index 18563ebed1a96..e721dd76e6640 100644 > --- a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > @@ -33,6 +33,12 @@ properties: > Optional external clock connected to REF_CLK input. > The clock rate must be in 10..154 MHz range. > > + blue-and-red-swap: 'swap' assumes I know the default order and I don't. Better to make the property name describe the end result. ('invert' properties have the same issue) > + description: > + If defined, the DPI output blue and red channels are swapped, > + i.e. RGB becomes BGR. > + type: boolean > + > enable-gpios: > description: Bridge EN pin, chip is reset when EN is low. Rob [1] https://lore.kernel.org/r/20220628181838.2031-3-max.oss.09@gmail.com
next prev parent reply other threads:[~2022-08-01 16:32 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-01 13:19 [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap Marek Vasut 2022-08-01 13:19 ` Marek Vasut 2022-08-01 13:19 ` [PATCH 2/2] drm: " Marek Vasut 2022-08-01 16:32 ` Rob Herring [this message] 2022-08-01 16:32 ` [PATCH 1/2] dt-bindings: display: " Rob Herring 2022-08-02 11:33 ` Marek Vasut 2022-08-02 11:33 ` Marek Vasut 2022-08-03 22:41 ` Rob Herring 2022-08-03 22:41 ` Rob Herring 2022-08-08 1:57 ` Marek Vasut 2022-08-08 1:57 ` Marek Vasut 2022-08-26 11:52 ` Linus Walleij 2022-08-26 11:52 ` Linus Walleij 2022-08-26 11:54 ` Marek Vasut 2022-08-26 11:54 ` Marek Vasut
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220801163238.GA1130127-robh@kernel.org \ --to=robh@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jagan@amarulasolutions.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linus.walleij@linaro.org \ --cc=marex@denx.de \ --cc=robert.foss@linaro.org \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.