All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] doc: develop: Add a note about importing code from other projects
@ 2022-08-01 18:57 Tom Rini
  2022-08-01 19:03 ` Sudeep Holla
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Rini @ 2022-08-01 18:57 UTC (permalink / raw)
  To: u-boot; +Cc: Heinrich Schuchardt, Sudeep Holla

We talk about importing code from other projects in two places. The
first place is in the coding style section, where we explain when to or
not to deviate in terms of white space, etc. In the process
documentation we now add a note about saying where the code was imported
from and to ensure that you do not copy Signed-off-by or other tags.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Given Sudeep's feedback just now on another series, it makes sense to
note this in the documentation, for future reference.
---
 doc/develop/process.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/develop/process.rst b/doc/develop/process.rst
index 0ef24e819982..388945cf9bb9 100644
--- a/doc/develop/process.rst
+++ b/doc/develop/process.rst
@@ -139,6 +139,10 @@ like this:
    as the Linux kernel.  Following this and adding a ``Signed-off-by:`` line
    that contains the developer's name and email address is required.
 
+   * Please note that when importing code from other projects you must say
+     where it comes from, and what revision you are importing. You must not
+     however copy ``Signed-off-by`` or other tags.
+
 #. Everybody who can is invited to review and test the changes.  Typically, we
    follow the same guidelines as the Linux kernel for `Acked-by
    <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by>`_
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] doc: develop: Add a note about importing code from other projects
  2022-08-01 18:57 [PATCH] doc: develop: Add a note about importing code from other projects Tom Rini
@ 2022-08-01 19:03 ` Sudeep Holla
  0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2022-08-01 19:03 UTC (permalink / raw)
  To: Tom Rini; +Cc: u-boot, Heinrich Schuchardt, Sudeep Holla

On Mon, Aug 01, 2022 at 02:57:01PM -0400, Tom Rini wrote:
> We talk about importing code from other projects in two places. The
> first place is in the coding style section, where we explain when to or
> not to deviate in terms of white space, etc. In the process
> documentation we now add a note about saying where the code was imported
> from and to ensure that you do not copy Signed-off-by or other tags.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Given Sudeep's feedback just now on another series, it makes sense to
> note this in the documentation, for future reference.

Thanks for the quick response in the form of patch. That is super fast
and efficient 😄.

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-01 19:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01 18:57 [PATCH] doc: develop: Add a note about importing code from other projects Tom Rini
2022-08-01 19:03 ` Sudeep Holla

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.