All of lore.kernel.org
 help / color / mirror / Atom feed
* kernel/torture.c:491 torture_shuffle_task_register() warn: possible memory leak of 'stp'
@ 2022-08-02  4:06 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-08-02  4:06 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4684 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Christophe Leroy <christophe.leroy@csgroup.eu>
CC: Michael Ellerman <mpe@ellerman.id.au>

Hi Christophe,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9de1f9c8ca5100a02a2e271bdbde36202e251b4b
commit: 1e688dd2a3d6759d416616ff07afc4bb836c4213 powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto
date:   12 months ago
:::::: branch date: 8 hours ago
:::::: commit date: 12 months ago
config: powerpc-randconfig-m031-20220801 (https://download.01.org/0day-ci/archive/20220802/202208021257.o4aL7bR3-lkp(a)intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
kernel/torture.c:491 torture_shuffle_task_register() warn: possible memory leak of 'stp'
drivers/gpu/drm/drm_modeset_lock.c:103 drm_modeset_lock_all() warn: possible memory leak of 'ctx'
drivers/gpu/drm/drm_writeback.c:385 drm_writeback_signal_completion() error: we previously assumed 'job' could be null (see line 377)
drivers/gpu/drm/drm_atomic_uapi.c:196 drm_atomic_set_crtc_for_plane() warn: passing zero to 'PTR_ERR'
net/mac80211/key.c:464 ieee80211_key_replace() error: we previously assumed 'new' could be null (see line 446)
lib/test_rhashtable.c:544 test_insert_dup() warn: possible memory leak of 'rhlt'
kernel/sched/topology.c:1338 asym_cpu_capacity_update_data() warn: possible memory leak of 'entry'
drivers/gpu/drm/nouveau/nouveau_connector.c:260 nouveau_conn_reset() error: uninitialized symbol 'asyc'.
drivers/gpu/drm/nouveau/dispnv50/head.c:483 nv50_head_reset() error: uninitialized symbol 'asyh'.
drivers/gpu/drm/nouveau/dispnv50/wndw.c:632 nv50_wndw_reset() error: uninitialized symbol 'asyw'.
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5926 dm_crtc_reset_state() warn: possible memory leak of 'state'

Old smatch warnings:
drivers/gpu/drm/nouveau/dispnv50/wndw.c:633 nv50_wndw_reset() error: we previously assumed 'plane->state' could be null (see line 629)
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1349 amdgpu_dm_fini() warn: variable dereferenced before check 'adev->dm.dc' (see line 1336)
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5878 create_stream_for_sink() error: we previously assumed 'aconnector->dc_sink' could be null (see line 5776)
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8182 handle_cursor_update() error: we previously assumed 'afb' could be null (see line 8141)

vim +/stp +491 kernel/torture.c

3808dc9fab0591 Paul E. McKenney 2014-01-28  478  
3808dc9fab0591 Paul E. McKenney 2014-01-28  479  /*
3808dc9fab0591 Paul E. McKenney 2014-01-28  480   * Register a task to be shuffled.  If there is no memory, just splat
3808dc9fab0591 Paul E. McKenney 2014-01-28  481   * and don't bother registering.
3808dc9fab0591 Paul E. McKenney 2014-01-28  482   */
3808dc9fab0591 Paul E. McKenney 2014-01-28  483  void torture_shuffle_task_register(struct task_struct *tp)
3808dc9fab0591 Paul E. McKenney 2014-01-28  484  {
3808dc9fab0591 Paul E. McKenney 2014-01-28  485  	struct shuffle_task *stp;
3808dc9fab0591 Paul E. McKenney 2014-01-28  486  
3808dc9fab0591 Paul E. McKenney 2014-01-28  487  	if (WARN_ON_ONCE(tp == NULL))
3808dc9fab0591 Paul E. McKenney 2014-01-28  488  		return;
3808dc9fab0591 Paul E. McKenney 2014-01-28  489  	stp = kmalloc(sizeof(*stp), GFP_KERNEL);
3808dc9fab0591 Paul E. McKenney 2014-01-28  490  	if (WARN_ON_ONCE(stp == NULL))
3808dc9fab0591 Paul E. McKenney 2014-01-28 @491  		return;
3808dc9fab0591 Paul E. McKenney 2014-01-28  492  	stp->st_t = tp;
3808dc9fab0591 Paul E. McKenney 2014-01-28  493  	mutex_lock(&shuffle_task_mutex);
3808dc9fab0591 Paul E. McKenney 2014-01-28  494  	list_add(&stp->st_l, &shuffle_task_list);
3808dc9fab0591 Paul E. McKenney 2014-01-28  495  	mutex_unlock(&shuffle_task_mutex);
3808dc9fab0591 Paul E. McKenney 2014-01-28  496  }
3808dc9fab0591 Paul E. McKenney 2014-01-28  497  EXPORT_SYMBOL_GPL(torture_shuffle_task_register);
3808dc9fab0591 Paul E. McKenney 2014-01-28  498  

:::::: The code at line 491 was first introduced by commit
:::::: 3808dc9fab05913060626d7f0edd0f195cb9dcab rcutorture: Abstract torture_shuffle()

:::::: TO: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
:::::: CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread
* kernel/torture.c:491 torture_shuffle_task_register() warn: possible memory leak of 'stp'
@ 2022-06-12 17:44 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-06-12 17:44 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5285 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Christophe Leroy <christophe.leroy@csgroup.eu>
CC: Michael Ellerman <mpe@ellerman.id.au>

Hi Christophe,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7a68065eb9cd194cf03f135c9211eeb2d5c4c0a0
commit: 1e688dd2a3d6759d416616ff07afc4bb836c4213 powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto
date:   10 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 10 months ago
config: powerpc64-randconfig-m031-20220611 (https://download.01.org/0day-ci/archive/20220613/202206130153.IUYUERW4-lkp(a)intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
kernel/torture.c:491 torture_shuffle_task_register() warn: possible memory leak of 'stp'
security/keys/trusted-keys/trusted_tpm2.c:61 tpm2_key_encode() warn: passing zero to 'PTR_ERR'
drivers/infiniband/core/uverbs_uapi.c:77 uapi_create_write() error: potentially using uninitialized 'exists'.
drivers/reset/core.c:225 reset_control_array_rearm() error: 'rstc' dereferencing possible ERR_PTR()
drivers/reset/core.c:339 reset_control_reset() error: 'rstc' dereferencing possible ERR_PTR()
drivers/reset/core.c:411 reset_control_rearm() error: 'rstc' dereferencing possible ERR_PTR()
drivers/reset/core.c:452 reset_control_assert() error: 'rstc' dereferencing possible ERR_PTR()
drivers/reset/core.c:540 reset_control_deassert() error: 'rstc' dereferencing possible ERR_PTR()
drivers/reset/core.c:612 reset_control_status() error: 'rstc' dereferencing possible ERR_PTR()
drivers/reset/core.c:654 reset_control_acquire() error: 'rstc' dereferencing possible ERR_PTR()
drivers/reset/core.c:723 reset_control_release() error: 'rstc' dereferencing possible ERR_PTR()
drivers/net/wwan/wwan_core.c:1062 wwan_unregister_ops() error: 'wwandev' dereferencing possible ERR_PTR()
sound/core/oss/pcm_oss.c:2603 snd_pcm_oss_ioctl() error: we previously assumed 'substream' could be null (see line 2598)
net/mac80211/key.c:464 ieee80211_key_replace() error: we previously assumed 'new' could be null (see line 446)
net/netfilter/nf_nat_core.c:1039 nf_nat_register_fn() warn: potentially one past the end of array 'nat_ops[hooknum]'
net/netfilter/nf_nat_core.c:1039 nf_nat_register_fn() warn: potentially one past the end of array 'nat_ops[hooknum]'
net/wireless/sme.c:782 __cfg80211_connect_result() error: we previously assumed 'cr->bss' could be null (see line 733)
kernel/sched/topology.c:1338 asym_cpu_capacity_update_data() warn: possible memory leak of 'entry'
kernel/rcu/rcutorture.c:2357 rcu_torture_fwd_prog_cr() warn: possible memory leak of 'rfcp'

Old smatch warnings:
security/keys/trusted-keys/trusted_tpm2.c:83 tpm2_key_encode() warn: passing zero to 'PTR_ERR'
drivers/infiniband/core/uverbs_uapi.c:114 uapi_merge_method() error: uninitialized symbol 'exists'.
arch/powerpc/include/asm/mmu.h:233 early_mmu_has_feature() warn: bitwise AND condition is false here
arch/powerpc/include/asm/mmu.h:233 early_mmu_has_feature() warn: bitwise AND condition is false here

vim +/stp +491 kernel/torture.c

3808dc9fab0591 Paul E. McKenney 2014-01-28  478  
3808dc9fab0591 Paul E. McKenney 2014-01-28  479  /*
3808dc9fab0591 Paul E. McKenney 2014-01-28  480   * Register a task to be shuffled.  If there is no memory, just splat
3808dc9fab0591 Paul E. McKenney 2014-01-28  481   * and don't bother registering.
3808dc9fab0591 Paul E. McKenney 2014-01-28  482   */
3808dc9fab0591 Paul E. McKenney 2014-01-28  483  void torture_shuffle_task_register(struct task_struct *tp)
3808dc9fab0591 Paul E. McKenney 2014-01-28  484  {
3808dc9fab0591 Paul E. McKenney 2014-01-28  485  	struct shuffle_task *stp;
3808dc9fab0591 Paul E. McKenney 2014-01-28  486  
3808dc9fab0591 Paul E. McKenney 2014-01-28  487  	if (WARN_ON_ONCE(tp == NULL))
3808dc9fab0591 Paul E. McKenney 2014-01-28  488  		return;
3808dc9fab0591 Paul E. McKenney 2014-01-28  489  	stp = kmalloc(sizeof(*stp), GFP_KERNEL);
3808dc9fab0591 Paul E. McKenney 2014-01-28  490  	if (WARN_ON_ONCE(stp == NULL))
3808dc9fab0591 Paul E. McKenney 2014-01-28 @491  		return;
3808dc9fab0591 Paul E. McKenney 2014-01-28  492  	stp->st_t = tp;
3808dc9fab0591 Paul E. McKenney 2014-01-28  493  	mutex_lock(&shuffle_task_mutex);
3808dc9fab0591 Paul E. McKenney 2014-01-28  494  	list_add(&stp->st_l, &shuffle_task_list);
3808dc9fab0591 Paul E. McKenney 2014-01-28  495  	mutex_unlock(&shuffle_task_mutex);
3808dc9fab0591 Paul E. McKenney 2014-01-28  496  }
3808dc9fab0591 Paul E. McKenney 2014-01-28  497  EXPORT_SYMBOL_GPL(torture_shuffle_task_register);
3808dc9fab0591 Paul E. McKenney 2014-01-28  498  

:::::: The code at line 491 was first introduced by commit
:::::: 3808dc9fab05913060626d7f0edd0f195cb9dcab rcutorture: Abstract torture_shuffle()

:::::: TO: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
:::::: CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-02  4:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02  4:06 kernel/torture.c:491 torture_shuffle_task_register() warn: possible memory leak of 'stp' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2022-06-12 17:44 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.