Re: [PATCH] selftests/net: Refactor xfrm_fill_key() to use array of structs

From: kernel test robot <lkp@intel.com>
To: Gautam Menghani <gautammenghani201@gmail.com>,
	steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, shuah@kernel.org
Cc: kbuild-all@lists.01.org,
	Gautam Menghani <gautammenghani201@gmail.com>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] selftests/net: Refactor xfrm_fill_key() to use array of structs
Date: Tue, 2 Aug 2022 14:49:38 +0800	[thread overview]
Message-ID: <202208021442.LI0ioKrz-lkp@intel.com> (raw)
In-Reply-To: <20220731170316.71542-1-gautammenghani201@gmail.com>

Hi Gautam,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on klassert-ipsec-next/master]
[also build test WARNING on klassert-ipsec/master net-next/master net/master linus/master v5.19 next-20220728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gautam-Menghani/selftests-net-Refactor-xfrm_fill_key-to-use-array-of-structs/20220801-010446
base:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce:
        # https://github.com/intel-lab-lkp/linux/commit/deea0844458f9991c45aff2949b7180a95105752
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gautam-Menghani/selftests-net-Refactor-xfrm_fill_key-to-use-array-of-structs/20220801-010446
        git checkout deea0844458f9991c45aff2949b7180a95105752
        make O=/tmp/kselftest headers
        make O=/tmp/kselftest -C tools/testing/selftests

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> ipsec.c:83:1: warning: useless storage class specifier in empty declaration
      83 | };
         | ^
   ipsec.c: In function 'xfrm_fill_key':
>> ipsec.c:812:13: warning: unused variable 'i' [-Wunused-variable]
     812 |         int i = 0;
         |             ^

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp