* + tools-testing-selftests-vm-hmm-testsc-fix-build.patch added to mm-unstable branch
@ 2022-08-03 1:10 Andrew Morton
2022-08-03 4:02 ` Ralph Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2022-08-03 1:10 UTC (permalink / raw)
To: mm-commits, rcampbell, lkp, apopple, akpm, akpm
The patch titled
Subject: tools/testing/selftests/vm/hmm-tests.c: fix build
has been added to the -mm mm-unstable branch. Its filename is
tools-testing-selftests-vm-hmm-testsc-fix-build.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/tools-testing-selftests-vm-hmm-testsc-fix-build.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: tools/testing/selftests/vm/hmm-tests.c: fix build
Date: Tue Aug 2 06:03:03 PM PDT 2022
hmm-tests.c:1607:42: error: 'HMM_DMIRROR_MIGRATE' undeclared (first use in this function); did you mean 'HMM_DMIRROR_WRITE'?
Fixes: f6c3e1ae0114cd0 ("mm/hmm: add a test for cross device private faults")
Reported-by: kernel test robot <lkp@intel.com>
Cc: Ralph Campbell <rcampbell@nvidia.com>
Cc: Alistair Popple <apopple@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
tools/testing/selftests/vm/hmm-tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/tools/testing/selftests/vm/hmm-tests.c~tools-testing-selftests-vm-hmm-testsc-fix-build
+++ a/tools/testing/selftests/vm/hmm-tests.c
@@ -1604,7 +1604,7 @@ TEST_F(hmm2, double_map)
ASSERT_EQ(ptr[i], i);
/* Migrate pages to device 1 and try to read from device 0. */
- ret = hmm_dmirror_cmd(self->fd1, HMM_DMIRROR_MIGRATE, buffer, npages);
+ ret = hmm_migrate_sys_to_dev(self->fd1, buffer, npages);
ASSERT_EQ(ret, 0);
ASSERT_EQ(buffer->cpages, npages);
_
Patches currently in -mm which might be from akpm@linux-foundation.org are
tools-testing-selftests-vm-hmm-testsc-fix-build.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: + tools-testing-selftests-vm-hmm-testsc-fix-build.patch added to mm-unstable branch
2022-08-03 1:10 + tools-testing-selftests-vm-hmm-testsc-fix-build.patch added to mm-unstable branch Andrew Morton
@ 2022-08-03 4:02 ` Ralph Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ralph Campbell @ 2022-08-03 4:02 UTC (permalink / raw)
To: Andrew Morton, mm-commits, lkp, apopple
On 8/2/22 18:10, Andrew Morton wrote:
> The patch titled
> Subject: tools/testing/selftests/vm/hmm-tests.c: fix build
> has been added to the -mm mm-unstable branch. Its filename is
> tools-testing-selftests-vm-hmm-testsc-fix-build.patch
>
> This patch will shortly appear at
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/tools-testing-selftests-vm-hmm-testsc-fix-build.patch
>
> This patch will later appear in the mm-unstable branch at
> git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
>
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: tools/testing/selftests/vm/hmm-tests.c: fix build
> Date: Tue Aug 2 06:03:03 PM PDT 2022
>
> hmm-tests.c:1607:42: error: 'HMM_DMIRROR_MIGRATE' undeclared (first use in this function); did you mean 'HMM_DMIRROR_WRITE'?
>
> Fixes: f6c3e1ae0114cd0 ("mm/hmm: add a test for cross device private faults")
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Ralph Campbell <rcampbell@nvidia.com>
> Cc: Alistair Popple <apopple@nvidia.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> tools/testing/selftests/vm/hmm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/tools/testing/selftests/vm/hmm-tests.c~tools-testing-selftests-vm-hmm-testsc-fix-build
> +++ a/tools/testing/selftests/vm/hmm-tests.c
> @@ -1604,7 +1604,7 @@ TEST_F(hmm2, double_map)
> ASSERT_EQ(ptr[i], i);
>
> /* Migrate pages to device 1 and try to read from device 0. */
> - ret = hmm_dmirror_cmd(self->fd1, HMM_DMIRROR_MIGRATE, buffer, npages);
> + ret = hmm_migrate_sys_to_dev(self->fd1, buffer, npages);
> ASSERT_EQ(ret, 0);
> ASSERT_EQ(buffer->cpages, npages);
>
The original patch was based on 5.19.0. This is the right change for 5.20.
Thanks for fixing this. You can add:
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-03 4:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-03 1:10 + tools-testing-selftests-vm-hmm-testsc-fix-build.patch added to mm-unstable branch Andrew Morton
2022-08-03 4:02 ` Ralph Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.