* [PATCH] xen/char: mvebu-uart: Fix MISRA C 2012 Rule 20.7 violation
@ 2022-08-03 7:09 Xenia Ragiadakou
2022-08-03 21:22 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Xenia Ragiadakou @ 2022-08-03 7:09 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Julien Grall, Bertrand Marquis, Volodymyr Babchuk
The macro parameters 'off' and 'uart' are used as expressions and it is
good to be enclosed in parentheses to prevent against unintended expansion.
For the 'uart' case, in mvebu3700_write(), correct the second parentheses
that seems to have been accidently misplaced.
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---
xen/drivers/char/mvebu-uart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c
index 835d1ace3c..a00618b96f 100644
--- a/xen/drivers/char/mvebu-uart.c
+++ b/xen/drivers/char/mvebu-uart.c
@@ -64,8 +64,8 @@ static struct mvebu3700_uart {
struct vuart_info vuart;
} mvebu3700_com = {0};
-#define mvebu3700_read(uart, off) readl((uart)->regs + off)
-#define mvebu3700_write(uart, off, val) writel(val, (uart->regs) + off)
+#define mvebu3700_read(uart, off) readl((uart)->regs + (off))
+#define mvebu3700_write(uart, off, val) writel(val, (uart)->regs + (off))
static void mvebu3700_uart_interrupt(int irq, void *data,
struct cpu_user_regs *regs)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/char: mvebu-uart: Fix MISRA C 2012 Rule 20.7 violation
2022-08-03 7:09 [PATCH] xen/char: mvebu-uart: Fix MISRA C 2012 Rule 20.7 violation Xenia Ragiadakou
@ 2022-08-03 21:22 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2022-08-03 21:22 UTC (permalink / raw)
To: Xenia Ragiadakou
Cc: xen-devel, Stefano Stabellini, Julien Grall, Bertrand Marquis,
Volodymyr Babchuk
On Wed, 3 Aug 2022, Xenia Ragiadakou wrote:
> The macro parameters 'off' and 'uart' are used as expressions and it is
> good to be enclosed in parentheses to prevent against unintended expansion.
>
> For the 'uart' case, in mvebu3700_write(), correct the second parentheses
> that seems to have been accidently misplaced.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/drivers/char/mvebu-uart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c
> index 835d1ace3c..a00618b96f 100644
> --- a/xen/drivers/char/mvebu-uart.c
> +++ b/xen/drivers/char/mvebu-uart.c
> @@ -64,8 +64,8 @@ static struct mvebu3700_uart {
> struct vuart_info vuart;
> } mvebu3700_com = {0};
>
> -#define mvebu3700_read(uart, off) readl((uart)->regs + off)
> -#define mvebu3700_write(uart, off, val) writel(val, (uart->regs) + off)
> +#define mvebu3700_read(uart, off) readl((uart)->regs + (off))
> +#define mvebu3700_write(uart, off, val) writel(val, (uart)->regs + (off))
>
> static void mvebu3700_uart_interrupt(int irq, void *data,
> struct cpu_user_regs *regs)
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-03 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-03 7:09 [PATCH] xen/char: mvebu-uart: Fix MISRA C 2012 Rule 20.7 violation Xenia Ragiadakou
2022-08-03 21:22 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.