* [PATCH v9 0/3] dt-bindings: adc-joystick: add poll-interval
@ 2022-08-03 17:01 Chris Morgan
2022-08-03 17:01 ` [PATCH v9 1/3] " Chris Morgan
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Morgan @ 2022-08-03 17:01 UTC (permalink / raw)
To: linux-input
Cc: linux-iio, dmitry.torokhov, contact, robh+dt,
krzysztof.kozlowski+dt, heiko, jic23, paul, Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
Add support to the existing adc-joystick driver to support polling
rather than relying on triggered buffers. This is useful for devices
that do not offer triggered buffers in hardware. Code adapted from
changes made by Maya Matuszczyk <maccraft123mc@gmail.com>.
Changes from V8:
- Changed logic for checking channels to skip checking of storagebits.
- Changed comment format to comply with Linux style rules.
Changes from V7:
- Dropped acks from adc-joystick.c changes, as it has been altered
somewhat since v7.
- Improved checking value of poll-interval to ensure explicit error
handling in the event of malformed values.
- Adjusted logic to not check for storagebits if polling is in use,
which allows adc-joystick to work in polling mode for devices that
utilize a mux (such as the Odroid Go Super and the Anbernic RG353).
- Changed error message and channel size comparison logic slightly to
ensure code can fit within 80 character column width.
Changes from V6:
- Reverted back to "poll-interval" after mailing list discussion.
- Referenced input.yaml for definition of poll-interval in adc-joystick
documentation.
Changes from V5:
- Corrected an error found by yamllint in the documentation.
Changes from V4:
- Added unit property to devicetree attribute making it now
"poll-interval-ms".
- Simplified logic for setting polled value and made variable names
more clear.
Changes from V3:
- After lengthy discussion decided to support with existing attribute
of "poll-interval". If present, the driver will use polling and if
not present, it will use triggered buffers (as the driver does
today).
- Corrected some lines to honor the 80 character line-limit.
- Check return value from polling method and return early if there
is an error reading the data.
Changes from V2:
- Changed parameter from "adc-joystick,polled" to
"adc-joystick,no-hardware-trigger" as it is more representative of
what the driver and hardware are doing.
Changes from V1:
- Removed driver compatible string of "adc-joystick-polled".
- Added new optional boolean value of "adc-joystick,polled".
- Cleaned up if statements regarding polling behavior.
Chris Morgan (3):
dt-bindings: adc-joystick: add poll-interval
Input: adc-joystick - Add polled input device support
arm64: dts: rockchip: Update joystick to polled for OG2
.../bindings/input/adc-joystick.yaml | 5 ++
.../boot/dts/rockchip/rk3326-odroid-go2.dts | 1 +
drivers/input/joystick/adc-joystick.c | 69 +++++++++++++++----
3 files changed, 60 insertions(+), 15 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v9 1/3] dt-bindings: adc-joystick: add poll-interval
2022-08-03 17:01 [PATCH v9 0/3] dt-bindings: adc-joystick: add poll-interval Chris Morgan
@ 2022-08-03 17:01 ` Chris Morgan
2022-08-03 17:01 ` [PATCH v9 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
2022-08-03 17:01 ` [PATCH v9 3/3] arm64: dts: rockchip: Update joystick to polled for OG2 Chris Morgan
2 siblings, 0 replies; 5+ messages in thread
From: Chris Morgan @ 2022-08-03 17:01 UTC (permalink / raw)
To: linux-input
Cc: linux-iio, dmitry.torokhov, contact, robh+dt,
krzysztof.kozlowski+dt, heiko, jic23, paul, Chris Morgan,
Maya Matuszczyk, Rob Herring
From: Chris Morgan <macromorgan@hotmail.com>
Add poll-interval support for the adc-joystick documentation. This is
an optional value and if not provided the adc-joystick works as it
does today (with buffers). If this value is provided, the adc-joystick
driver is polled at the specified interval. The existing attribute of
"poll-interval" was used instead of complying with property-units.yaml
after discussion of the issue on the mailing list.
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Acked-by: Artur Rojek <contact@artur-rojek.eu>
---
Documentation/devicetree/bindings/input/adc-joystick.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml b/Documentation/devicetree/bindings/input/adc-joystick.yaml
index 2ee04e03bc22..ab5caad055ea 100644
--- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
+++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
@@ -14,6 +14,9 @@ description: >
Bindings for joystick devices connected to ADC controllers supporting
the Industrial I/O subsystem.
+allOf:
+ - $ref: input.yaml#
+
properties:
compatible:
const: adc-joystick
@@ -28,6 +31,8 @@ properties:
https://github.com/devicetree-org/dt-schema/blob/master/schemas/iio/iio-consumer.yaml
for details.
+ poll-interval: true
+
'#address-cells':
const: 1
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v9 2/3] Input: adc-joystick - Add polled input device support
2022-08-03 17:01 [PATCH v9 0/3] dt-bindings: adc-joystick: add poll-interval Chris Morgan
2022-08-03 17:01 ` [PATCH v9 1/3] " Chris Morgan
@ 2022-08-03 17:01 ` Chris Morgan
2022-08-03 17:30 ` Artur Rojek
2022-08-03 17:01 ` [PATCH v9 3/3] arm64: dts: rockchip: Update joystick to polled for OG2 Chris Morgan
2 siblings, 1 reply; 5+ messages in thread
From: Chris Morgan @ 2022-08-03 17:01 UTC (permalink / raw)
To: linux-input
Cc: linux-iio, dmitry.torokhov, contact, robh+dt,
krzysztof.kozlowski+dt, heiko, jic23, paul, Chris Morgan,
Maya Matuszczyk
From: Chris Morgan <macromorgan@hotmail.com>
Add polled input device support to the adc-joystick driver. This is
useful for devices which do not have hardware capable triggers on
their SARADC. Code modified from adc-joystick.c changes made by Maya
Matuszczyk.
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/input/joystick/adc-joystick.c | 69 +++++++++++++++++++++------
1 file changed, 54 insertions(+), 15 deletions(-)
diff --git a/drivers/input/joystick/adc-joystick.c b/drivers/input/joystick/adc-joystick.c
index 78ebca7d400a..0a2c0fb73618 100644
--- a/drivers/input/joystick/adc-joystick.c
+++ b/drivers/input/joystick/adc-joystick.c
@@ -26,8 +26,23 @@ struct adc_joystick {
struct adc_joystick_axis *axes;
struct iio_channel *chans;
int num_chans;
+ bool polled;
};
+static void adc_joystick_poll(struct input_dev *input)
+{
+ struct adc_joystick *joy = input_get_drvdata(input);
+ int i, val, ret;
+
+ for (i = 0; i < joy->num_chans; i++) {
+ ret = iio_read_channel_raw(&joy->chans[i], &val);
+ if (ret < 0)
+ return;
+ input_report_abs(input, joy->axes[i].code, val);
+ }
+ input_sync(input);
+}
+
static int adc_joystick_handle(const void *data, void *private)
{
struct adc_joystick *joy = private;
@@ -179,6 +194,7 @@ static int adc_joystick_probe(struct platform_device *pdev)
int error;
int bits;
int i;
+ unsigned int poll_interval;
joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
if (!joy)
@@ -192,14 +208,27 @@ static int adc_joystick_probe(struct platform_device *pdev)
return error;
}
- /* Count how many channels we got. NULL terminated. */
+ if (device_property_present(dev, "poll-interval")) {
+ error = device_property_read_u32(dev, "poll-interval",
+ &poll_interval);
+ if (error)
+ return error;
+ joy->polled = true;
+ }
+
+ /*
+ * Count how many channels we got. NULL terminated.
+ * Do not check the storage size if using polling.
+ */
for (i = 0; joy->chans[i].indio_dev; i++) {
bits = joy->chans[i].channel->scan_type.storagebits;
- if (!bits || bits > 16) {
- dev_err(dev, "Unsupported channel storage size\n");
+ if (!joy->polled && (!bits || bits > 16)) {
+ dev_err(dev,
+ "Unsupported channel storage size\n");
return -EINVAL;
}
- if (bits != joy->chans[0].channel->scan_type.storagebits) {
+ if (!joy->polled &&
+ bits != joy->chans[0].channel->scan_type.storagebits) {
dev_err(dev, "Channels must have equal storage size\n");
return -EINVAL;
}
@@ -215,8 +244,14 @@ static int adc_joystick_probe(struct platform_device *pdev)
joy->input = input;
input->name = pdev->name;
input->id.bustype = BUS_HOST;
- input->open = adc_joystick_open;
- input->close = adc_joystick_close;
+
+ if (joy->polled) {
+ input_setup_polling(input, adc_joystick_poll);
+ input_set_poll_interval(input, poll_interval);
+ } else {
+ input->open = adc_joystick_open;
+ input->close = adc_joystick_close;
+ }
error = adc_joystick_set_axes(dev, joy);
if (error)
@@ -229,16 +264,20 @@ static int adc_joystick_probe(struct platform_device *pdev)
return error;
}
- joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
- if (IS_ERR(joy->buffer)) {
- dev_err(dev, "Unable to allocate callback buffer\n");
- return PTR_ERR(joy->buffer);
- }
+ if (!joy->polled) {
+ joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle,
+ joy);
+ if (IS_ERR(joy->buffer)) {
+ dev_err(dev, "Unable to allocate callback buffer\n");
+ return PTR_ERR(joy->buffer);
+ }
- error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer);
- if (error) {
- dev_err(dev, "Unable to add action\n");
- return error;
+ error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
+ joy->buffer);
+ if (error) {
+ dev_err(dev, "Unable to add action\n");
+ return error;
+ }
}
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v9 3/3] arm64: dts: rockchip: Update joystick to polled for OG2
2022-08-03 17:01 [PATCH v9 0/3] dt-bindings: adc-joystick: add poll-interval Chris Morgan
2022-08-03 17:01 ` [PATCH v9 1/3] " Chris Morgan
2022-08-03 17:01 ` [PATCH v9 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
@ 2022-08-03 17:01 ` Chris Morgan
2 siblings, 0 replies; 5+ messages in thread
From: Chris Morgan @ 2022-08-03 17:01 UTC (permalink / raw)
To: linux-input
Cc: linux-iio, dmitry.torokhov, contact, robh+dt,
krzysztof.kozlowski+dt, heiko, jic23, paul, Chris Morgan,
Maya Matuszczyk
From: Chris Morgan <macromorgan@hotmail.com>
Update the Odroid Go Advance to use "poll-interval" from the
adc-joystick driver.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
index 415aa9ff8bd4..3389755dbdc8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
@@ -26,6 +26,7 @@ adc-joystick {
compatible = "adc-joystick";
io-channels = <&saradc 1>,
<&saradc 2>;
+ poll-interval = <60>;
#address-cells = <1>;
#size-cells = <0>;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v9 2/3] Input: adc-joystick - Add polled input device support
2022-08-03 17:01 ` [PATCH v9 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
@ 2022-08-03 17:30 ` Artur Rojek
0 siblings, 0 replies; 5+ messages in thread
From: Artur Rojek @ 2022-08-03 17:30 UTC (permalink / raw)
To: Chris Morgan
Cc: linux-input, linux-iio, dmitry.torokhov, robh+dt,
krzysztof.kozlowski+dt, heiko, jic23, paul, Chris Morgan,
Maya Matuszczyk
On 2022-08-03 19:01, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add polled input device support to the adc-joystick driver. This is
> useful for devices which do not have hardware capable triggers on
> their SARADC. Code modified from adc-joystick.c changes made by Maya
> Matuszczyk.
>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
Hey Chris,
comments inline.
Cheers,
Artur
> drivers/input/joystick/adc-joystick.c | 69 +++++++++++++++++++++------
> 1 file changed, 54 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/input/joystick/adc-joystick.c
> b/drivers/input/joystick/adc-joystick.c
> index 78ebca7d400a..0a2c0fb73618 100644
> --- a/drivers/input/joystick/adc-joystick.c
> +++ b/drivers/input/joystick/adc-joystick.c
> @@ -26,8 +26,23 @@ struct adc_joystick {
> struct adc_joystick_axis *axes;
> struct iio_channel *chans;
> int num_chans;
> + bool polled;
> };
>
> +static void adc_joystick_poll(struct input_dev *input)
> +{
> + struct adc_joystick *joy = input_get_drvdata(input);
> + int i, val, ret;
> +
> + for (i = 0; i < joy->num_chans; i++) {
> + ret = iio_read_channel_raw(&joy->chans[i], &val);
> + if (ret < 0)
> + return;
> + input_report_abs(input, joy->axes[i].code, val);
> + }
> + input_sync(input);
> +}
> +
> static int adc_joystick_handle(const void *data, void *private)
> {
> struct adc_joystick *joy = private;
> @@ -179,6 +194,7 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> int error;
> int bits;
> int i;
> + unsigned int poll_interval;
>
> joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
> if (!joy)
> @@ -192,14 +208,27 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> return error;
> }
>
> - /* Count how many channels we got. NULL terminated. */
> + if (device_property_present(dev, "poll-interval")) {
> + error = device_property_read_u32(dev, "poll-interval",
> + &poll_interval);
> + if (error)
> + return error;
> + joy->polled = true;
> + }
> +
> + /*
> + * Count how many channels we got. NULL terminated.
> + * Do not check the storage size if using polling.
> + */
> for (i = 0; joy->chans[i].indio_dev; i++) {
> bits = joy->chans[i].channel->scan_type.storagebits;
> - if (!bits || bits > 16) {
> - dev_err(dev, "Unsupported channel storage size\n");
> + if (!joy->polled && (!bits || bits > 16)) {
Ah, you still need to run the loop to count the channels.
In that case, just do:
```
for (i = 0; joy->chans[i].indio_dev; i++) {
if (joy->polled)
continue;
bits = joy->chans[i].channel->scan_type.storagebits;
...
}
```
> + dev_err(dev,
> + "Unsupported channel storage size\n");
> return -EINVAL;
> }
> - if (bits != joy->chans[0].channel->scan_type.storagebits) {
> + if (!joy->polled &&
> + bits != joy->chans[0].channel->scan_type.storagebits) {
> dev_err(dev, "Channels must have equal storage size\n");
> return -EINVAL;
> }
> @@ -215,8 +244,14 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> joy->input = input;
> input->name = pdev->name;
> input->id.bustype = BUS_HOST;
> - input->open = adc_joystick_open;
> - input->close = adc_joystick_close;
> +
> + if (joy->polled) {
> + input_setup_polling(input, adc_joystick_poll);
> + input_set_poll_interval(input, poll_interval);
> + } else {
> + input->open = adc_joystick_open;
> + input->close = adc_joystick_close;
> + }
>
> error = adc_joystick_set_axes(dev, joy);
> if (error)
> @@ -229,16 +264,20 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> return error;
> }
>
> - joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> - if (IS_ERR(joy->buffer)) {
> - dev_err(dev, "Unable to allocate callback buffer\n");
> - return PTR_ERR(joy->buffer);
> - }
> + if (!joy->polled) {
Since this is the last piece of logic we do in this function, we can as
well inverse the condition:
```
if (joy->polled)
return 0;
```
Then we don't need to indent the remaining lines and the patch impact
is smaller ;)
> + joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle,
> + joy);
> + if (IS_ERR(joy->buffer)) {
> + dev_err(dev, "Unable to allocate callback buffer\n");
> + return PTR_ERR(joy->buffer);
> + }
>
> - error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> joy->buffer);
> - if (error) {
> - dev_err(dev, "Unable to add action\n");
> - return error;
> + error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> + joy->buffer);
> + if (error) {
> + dev_err(dev, "Unable to add action\n");
> + return error;
> + }
> }
>
> return 0;
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-03 17:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-03 17:01 [PATCH v9 0/3] dt-bindings: adc-joystick: add poll-interval Chris Morgan
2022-08-03 17:01 ` [PATCH v9 1/3] " Chris Morgan
2022-08-03 17:01 ` [PATCH v9 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
2022-08-03 17:30 ` Artur Rojek
2022-08-03 17:01 ` [PATCH v9 3/3] arm64: dts: rockchip: Update joystick to polled for OG2 Chris Morgan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.