* drivers/usb/gadget/udc/bcm63xx_udc.c:1861 bcm63xx_udc_stop() warn: sleeping in atomic context
@ 2022-08-05 7:35 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-08-04 16:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5062 bytes --]
BCC: lkp(a)intel.com
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Randy Dunlap <rdunlap@infradead.org>
CC: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1
commit: 5eeaafc8d69373c095e461bdb39e5c9b62228ac5 mips: BCM63XX: ensure that CPU_SUPPORTS_32BIT_KERNEL is set
date: 9 months ago
:::::: branch date: 14 hours ago
:::::: commit date: 9 months ago
config: mips-randconfig-m041-20220804 (https://download.01.org/0day-ci/archive/20220805/202208050012.uDlpcTiD-lkp(a)intel.com/config)
compiler: mips-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/usb/gadget/udc/bcm63xx_udc.c:1861 bcm63xx_udc_stop() warn: sleeping in atomic context
arch/mips/mm/tlbex.c:1677 iPTE_LW() warn: curly braces intended?
arch/mips/mm/fault.c:322 __do_page_fault() warn: inconsistent returns '&mm->mmap_lock'.
Old smatch warnings:
arch/mips/mm/tlbex.c:1709 iPTE_SW() warn: inconsistent indenting
arch/mips/mm/tlbex.c:2166 build_r4000_tlb_load_handler() warn: inconsistent indenting
vim +1861 drivers/usb/gadget/udc/bcm63xx_udc.c
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1840
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1841 /**
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1842 * bcm63xx_udc_stop - Shut down the controller.
b9b70170db4d68 drivers/usb/gadget/udc/bcm63xx_udc.c Greg Kroah-Hartman 2020-06-30 1843 * @gadget: USB device.
b9b70170db4d68 drivers/usb/gadget/udc/bcm63xx_udc.c Greg Kroah-Hartman 2020-06-30 1844 * @driver: Driver for USB device.
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1845 */
22835b807e7ca9 drivers/usb/gadget/udc/bcm63xx_udc.c Felipe Balbi 2014-10-17 1846 static int bcm63xx_udc_stop(struct usb_gadget *gadget)
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1847 {
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1848 struct bcm63xx_udc *udc = gadget_to_udc(gadget);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1849 unsigned long flags;
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1850
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1851 spin_lock_irqsave(&udc->lock, flags);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1852
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1853 udc->driver = NULL;
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1854
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1855 /*
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1856 * If we switch the PHY too abruptly after dropping D+, the host
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1857 * will often complain:
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1858 *
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1859 * hub 1-0:1.0: port 1 disabled by hub (EMI?), re-enabling...
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1860 */
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 @1861 msleep(100);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1862
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1863 bcm63xx_select_phy_mode(udc, false);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1864 set_clocks(udc, false);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1865
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1866 spin_unlock_irqrestore(&udc->lock, flags);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1867
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1868 return 0;
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1869 }
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1870
:::::: The code at line 1861 was first introduced by commit
:::::: 613065e53cb191d00d9d4fc377398b656ed05a45 usb: gadget: bcm63xx UDC driver
:::::: TO: Kevin Cernekee <cernekee@gmail.com>
:::::: CC: Felipe Balbi <balbi@ti.com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/usb/gadget/udc/bcm63xx_udc.c:1861 bcm63xx_udc_stop() warn: sleeping in atomic context
@ 2022-08-05 7:35 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-08-05 7:35 UTC (permalink / raw)
To: kbuild, Randy Dunlap, Kevin Cernekee, Felipe Balbi, linux-usb
Cc: lkp, kbuild-all, linux-kernel, Thomas Bogendoerfer
[ This patch just enabled the build-bot to test more code, so it gets
blamed for the new warnings even though it didn't introduce them.
The actual bug in a USB driver, so I've added linux-usb to the CC
list. -dan ]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1
commit: 5eeaafc8d69373c095e461bdb39e5c9b62228ac5 mips: BCM63XX: ensure that CPU_SUPPORTS_32BIT_KERNEL is set
config: mips-randconfig-m041-20220804 (https://download.01.org/0day-ci/archive/20220805/202208050012.uDlpcTiD-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/usb/gadget/udc/bcm63xx_udc.c:1861 bcm63xx_udc_stop() warn: sleeping in atomic context
vim +1861 drivers/usb/gadget/udc/bcm63xx_udc.c
22835b807e7ca9 drivers/usb/gadget/udc/bcm63xx_udc.c Felipe Balbi 2014-10-17 1846 static int bcm63xx_udc_stop(struct usb_gadget *gadget)
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1847 {
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1848 struct bcm63xx_udc *udc = gadget_to_udc(gadget);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1849 unsigned long flags;
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1850
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1851 spin_lock_irqsave(&udc->lock, flags);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1852
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1853 udc->driver = NULL;
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1854
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1855 /*
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1856 * If we switch the PHY too abruptly after dropping D+, the host
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1857 * will often complain:
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1858 *
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1859 * hub 1-0:1.0: port 1 disabled by hub (EMI?), re-enabling...
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1860 */
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 @1861 msleep(100);
^^^^^^^^^^^^
You can't sleep when you're holding a spinlock.
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1862
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1863 bcm63xx_select_phy_mode(udc, false);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1864 set_clocks(udc, false);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1865
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1866 spin_unlock_irqrestore(&udc->lock, flags);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1867
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1868 return 0;
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1869 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread
* drivers/usb/gadget/udc/bcm63xx_udc.c:1861 bcm63xx_udc_stop() warn: sleeping in atomic context
@ 2022-08-05 7:35 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-08-05 7:35 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4002 bytes --]
[ This patch just enabled the build-bot to test more code, so it gets
blamed for the new warnings even though it didn't introduce them.
The actual bug in a USB driver, so I've added linux-usb to the CC
list. -dan ]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1
commit: 5eeaafc8d69373c095e461bdb39e5c9b62228ac5 mips: BCM63XX: ensure that CPU_SUPPORTS_32BIT_KERNEL is set
config: mips-randconfig-m041-20220804 (https://download.01.org/0day-ci/archive/20220805/202208050012.uDlpcTiD-lkp(a)intel.com/config)
compiler: mips-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/usb/gadget/udc/bcm63xx_udc.c:1861 bcm63xx_udc_stop() warn: sleeping in atomic context
vim +1861 drivers/usb/gadget/udc/bcm63xx_udc.c
22835b807e7ca9 drivers/usb/gadget/udc/bcm63xx_udc.c Felipe Balbi 2014-10-17 1846 static int bcm63xx_udc_stop(struct usb_gadget *gadget)
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1847 {
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1848 struct bcm63xx_udc *udc = gadget_to_udc(gadget);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1849 unsigned long flags;
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1850
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1851 spin_lock_irqsave(&udc->lock, flags);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1852
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1853 udc->driver = NULL;
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1854
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1855 /*
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1856 * If we switch the PHY too abruptly after dropping D+, the host
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1857 * will often complain:
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1858 *
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1859 * hub 1-0:1.0: port 1 disabled by hub (EMI?), re-enabling...
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1860 */
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 @1861 msleep(100);
^^^^^^^^^^^^
You can't sleep when you're holding a spinlock.
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1862
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1863 bcm63xx_select_phy_mode(udc, false);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1864 set_clocks(udc, false);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1865
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1866 spin_unlock_irqrestore(&udc->lock, flags);
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1867
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1868 return 0;
613065e53cb191 drivers/usb/gadget/bcm63xx_udc.c Kevin Cernekee 2012-08-25 1869 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-05 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 16:53 drivers/usb/gadget/udc/bcm63xx_udc.c:1861 bcm63xx_udc_stop() warn: sleeping in atomic context kernel test robot
2022-08-05 7:35 ` Dan Carpenter
2022-08-05 7:35 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.