* [PATCH] drivers: android: binder: Fixed coding style issue
@ 2022-08-05 13:06 Alix Dixon
2022-08-05 13:33 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Alix Dixon @ 2022-08-05 13:06 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Alix Dixon
Fixed issue with comments on multiple lines not being aligned correctly + multiline comments not being on multiple lines
Signed-off-by: Alix Dixon <notdixon.alix@gmail.com>
---
drivers/android/binder.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index c964d7c8c..5a6da6765 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -5289,8 +5289,10 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
unsigned int size = _IOC_SIZE(cmd);
void __user *ubuf = (void __user *)arg;
- /*pr_info("binder_ioctl: %d:%d %x %lx\n",
- proc->pid, current->pid, cmd, arg);*/
+ /*
+ * pr_info("binder_ioctl: %d:%d %x %lx\n",
+ * proc->pid, current->pid, cmd, arg);
+ */
binder_selftest_alloc(&proc->alloc);
@@ -6544,8 +6546,8 @@ static int __init binder_init(void)
if (!IS_ENABLED(CONFIG_ANDROID_BINDERFS) &&
strcmp(binder_devices_param, "") != 0) {
/*
- * Copy the module_parameter string, because we don't want to
- * tokenize it in-place.
+ * Copy the module_parameter string, because we don't want to
+ * tokenize it in-place.
*/
device_names = kstrdup(binder_devices_param, GFP_KERNEL);
if (!device_names) {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: android: binder: Fixed coding style issue
2022-08-05 13:06 [PATCH] drivers: android: binder: Fixed coding style issue Alix Dixon
@ 2022-08-05 13:33 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-08-05 13:33 UTC (permalink / raw)
To: Alix Dixon; +Cc: linux-kernel
On Fri, Aug 05, 2022 at 02:06:11PM +0100, Alix Dixon wrote:
> Fixed issue with comments on multiple lines not being aligned correctly + multiline comments not being on multiple lines
The irony of a changelog about not wrapping lines properly having an
inproper wrapped line is not lost on me :)
>
> Signed-off-by: Alix Dixon <notdixon.alix@gmail.com>
Any reason you didn't cc: all of the proper people that
scripts/get_maintainer.pl told you to cc? This driver does have very
active maintainers.
> ---
> drivers/android/binder.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index c964d7c8c..5a6da6765 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -5289,8 +5289,10 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> unsigned int size = _IOC_SIZE(cmd);
> void __user *ubuf = (void __user *)arg;
>
> - /*pr_info("binder_ioctl: %d:%d %x %lx\n",
> - proc->pid, current->pid, cmd, arg);*/
> + /*
> + * pr_info("binder_ioctl: %d:%d %x %lx\n",
> + * proc->pid, current->pid, cmd, arg);
> + */
There's nothing wrong with the original code here.
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-05 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-05 13:06 [PATCH] drivers: android: binder: Fixed coding style issue Alix Dixon
2022-08-05 13:33 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.