From: Conor Dooley <mail@conchuod.ie> To: Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, Anup Patel <anup@brainfault.org>, Conor Dooley <conor.dooley@microchip.com>, Guo Ren <guoren@kernel.org>, Sagar Kadam <sagar.kadam@sifive.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, qemu-riscv@nongnu.org Subject: [PATCH 0/3] Fix dt-validate issues on qemu dtbdumps due to dt-bindings Date: Fri, 5 Aug 2022 17:28:42 +0100 [thread overview] Message-ID: <20220805162844.1554247-1-mail@conchuod.ie> (raw) From: Conor Dooley <conor.dooley@microchip.com> The device trees produced automatically for the virt and spike machines fail dt-validate on several grounds. Some of these need to be fixed in the linux kernel's dt-bindings, but others are caused by bugs in QEMU. Patches been sent that fix the QEMU issues [0], but a couple of them need to be fixed in the kernel's dt-bindings. The first patches add compatibles for "riscv,{clint,plic}0" which are present in drivers and the auto generated QEMU dtbs. The final patch adds some new ISA strings which needs scruitiny from someone with more knowledge about what ISA extension strings should be reported in a dt than I have. Thanks to Rob Herring for reporting these issues [1], Conor. To reproduce the errors: ./build/qemu-system-riscv64 -nographic -machine virt,dumpdtb=qemu.dtb dt-validate -p /path/to/linux/kernel/Documentation/devicetree/bindings/processed-schema.json qemu.dtb (The processed schema needs to be generated first) 0 - https://lore.kernel.org/linux-riscv/20220805155405.1504081-1-mail@conchuod.ie 1 - https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-robh@kernel.org/ Conor Dooley (3): dt-bindings: timer: sifive,clint: add legacy riscv compatible dt-bindings: interrupt-controller: sifive,plic: add legacy riscv compatible dt-bindings: riscv: add new riscv,isa strings for emulators .../sifive,plic-1.0.0.yaml | 5 +++++ .../devicetree/bindings/riscv/cpus.yaml | 2 ++ .../bindings/timer/sifive,clint.yaml | 18 ++++++++++++------ 3 files changed, 19 insertions(+), 6 deletions(-) base-commit: 42d670bda02fdba0f3944c92f545984501e5788d -- 2.37.1
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <mail@conchuod.ie> To: Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, Anup Patel <anup@brainfault.org>, Conor Dooley <conor.dooley@microchip.com>, Guo Ren <guoren@kernel.org>, Sagar Kadam <sagar.kadam@sifive.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, qemu-riscv@nongnu.org Subject: [PATCH 0/3] Fix dt-validate issues on qemu dtbdumps due to dt-bindings Date: Fri, 5 Aug 2022 17:28:42 +0100 [thread overview] Message-ID: <20220805162844.1554247-1-mail@conchuod.ie> (raw) From: Conor Dooley <conor.dooley@microchip.com> The device trees produced automatically for the virt and spike machines fail dt-validate on several grounds. Some of these need to be fixed in the linux kernel's dt-bindings, but others are caused by bugs in QEMU. Patches been sent that fix the QEMU issues [0], but a couple of them need to be fixed in the kernel's dt-bindings. The first patches add compatibles for "riscv,{clint,plic}0" which are present in drivers and the auto generated QEMU dtbs. The final patch adds some new ISA strings which needs scruitiny from someone with more knowledge about what ISA extension strings should be reported in a dt than I have. Thanks to Rob Herring for reporting these issues [1], Conor. To reproduce the errors: ./build/qemu-system-riscv64 -nographic -machine virt,dumpdtb=qemu.dtb dt-validate -p /path/to/linux/kernel/Documentation/devicetree/bindings/processed-schema.json qemu.dtb (The processed schema needs to be generated first) 0 - https://lore.kernel.org/linux-riscv/20220805155405.1504081-1-mail@conchuod.ie 1 - https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-robh@kernel.org/ Conor Dooley (3): dt-bindings: timer: sifive,clint: add legacy riscv compatible dt-bindings: interrupt-controller: sifive,plic: add legacy riscv compatible dt-bindings: riscv: add new riscv,isa strings for emulators .../sifive,plic-1.0.0.yaml | 5 +++++ .../devicetree/bindings/riscv/cpus.yaml | 2 ++ .../bindings/timer/sifive,clint.yaml | 18 ++++++++++++------ 3 files changed, 19 insertions(+), 6 deletions(-) base-commit: 42d670bda02fdba0f3944c92f545984501e5788d -- 2.37.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2022-08-05 16:29 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-05 16:28 Conor Dooley [this message] 2022-08-05 16:28 ` [PATCH 0/3] Fix dt-validate issues on qemu dtbdumps due to dt-bindings Conor Dooley 2022-08-05 16:28 ` [PATCH 1/3] dt-bindings: timer: sifive,clint: add legacy riscv compatible Conor Dooley 2022-08-05 16:28 ` [PATCH 1/3] dt-bindings: timer: sifive, clint: " Conor Dooley 2022-08-05 16:28 ` [PATCH 1/3] dt-bindings: timer: sifive,clint: " Conor Dooley 2022-08-09 14:16 ` Rob Herring 2022-08-09 14:16 ` Rob Herring 2022-08-09 17:30 ` Conor.Dooley 2022-08-09 17:30 ` Conor.Dooley 2022-08-05 16:28 ` [PATCH 2/3] dt-bindings: interrupt-controller: sifive,plic: " Conor Dooley 2022-08-05 16:28 ` [PATCH 2/3] dt-bindings: interrupt-controller: sifive, plic: " Conor Dooley 2022-08-05 16:28 ` [PATCH 2/3] dt-bindings: interrupt-controller: sifive,plic: " Conor Dooley 2022-08-05 16:28 ` [PATCH 3/3] dt-bindings: riscv: add new riscv,isa strings for emulators Conor Dooley 2022-08-05 16:28 ` [PATCH 3/3] dt-bindings: riscv: add new riscv, isa " Conor Dooley 2022-08-05 16:28 ` [PATCH 3/3] dt-bindings: riscv: add new riscv,isa " Conor Dooley 2022-08-08 21:34 ` [PATCH 0/3] Fix dt-validate issues on qemu dtbdumps due to dt-bindings Jessica Clarke 2022-08-08 21:34 ` Jessica Clarke 2022-08-08 22:01 ` Conor.Dooley 2022-08-08 22:01 ` Conor.Dooley 2022-08-09 14:14 ` Rob Herring 2022-08-09 14:14 ` Rob Herring 2022-08-09 17:25 ` Conor.Dooley 2022-08-09 17:25 ` Conor.Dooley 2022-08-09 18:36 ` Conor.Dooley 2022-08-09 18:36 ` Conor.Dooley 2022-08-15 19:18 ` Conor.Dooley 2022-08-15 19:18 ` Conor.Dooley 2022-08-16 14:06 ` Andrew Jones 2022-08-16 14:06 ` Andrew Jones 2022-08-16 22:53 ` Conor.Dooley 2022-08-16 22:53 ` Conor.Dooley 2022-08-17 7:52 ` Andrew Jones 2022-08-17 7:52 ` Andrew Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220805162844.1554247-1-mail@conchuod.ie \ --to=mail@conchuod.ie \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=conor.dooley@microchip.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=guoren@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=maz@kernel.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=qemu-riscv@nongnu.org \ --cc=robh+dt@kernel.org \ --cc=sagar.kadam@sifive.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.