All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>
Subject: [PATCH v2 17/30] mfd: tps6586x: Remove #ifdef guards for PM related functions
Date: Mon,  8 Aug 2022 19:40:54 +0200	[thread overview]
Message-ID: <20220808174107.38676-18-paul@crapouillou.net> (raw)
In-Reply-To: <20220808174107.38676-1-paul@crapouillou.net>

Use the new pm_sleep_ptr() macro to handle the .irq_set_wake() callback.

This macro allows the mt6397_irq_set_wake() function to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 drivers/mfd/tps6586x.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
index c9303d3d6602..fd57c3974615 100644
--- a/drivers/mfd/tps6586x.c
+++ b/drivers/mfd/tps6586x.c
@@ -269,15 +269,11 @@ static void tps6586x_irq_sync_unlock(struct irq_data *data)
 	mutex_unlock(&tps6586x->irq_lock);
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int tps6586x_irq_set_wake(struct irq_data *irq_data, unsigned int on)
 {
 	struct tps6586x *tps6586x = irq_data_get_irq_chip_data(irq_data);
 	return irq_set_irq_wake(tps6586x->irq, on);
 }
-#else
-#define tps6586x_irq_set_wake NULL
-#endif
 
 static struct irq_chip tps6586x_irq_chip = {
 	.name = "tps6586x",
@@ -285,7 +281,7 @@ static struct irq_chip tps6586x_irq_chip = {
 	.irq_bus_sync_unlock = tps6586x_irq_sync_unlock,
 	.irq_disable = tps6586x_irq_disable,
 	.irq_enable = tps6586x_irq_enable,
-	.irq_set_wake = tps6586x_irq_set_wake,
+	.irq_set_wake = pm_sleep_ptr(tps6586x_irq_set_wake),
 };
 
 static int tps6586x_irq_map(struct irq_domain *h, unsigned int virq,
-- 
2.35.1


  parent reply	other threads:[~2022-08-08 17:45 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 17:40 [PATCH v2 00/30] mfd: Remove #ifdef guards for PM functions Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 01/30] pm: Improve EXPORT_*_DEV_PM_OPS macros Paul Cercueil
2022-08-13 14:49   ` Jonathan Cameron
2022-08-23 17:47   ` Rafael J. Wysocki
2022-08-25 22:42     ` Paul Cercueil
2022-09-25 14:52       ` Jonathan Cameron
2022-09-26 12:00         ` Rafael J. Wysocki
2022-09-26 13:27           ` Paul Cercueil
2022-09-26 13:35             ` Rafael J. Wysocki
2022-10-01 17:01               ` Jonathan Cameron
2022-10-02 11:18                 ` Paul Cercueil
2022-10-04 18:54                   ` Rafael J. Wysocki
2022-10-04 19:12                     ` Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 02/30] mfd: 88pm80x: Remove #ifdef guards for PM related functions Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 03/30] mfd: aat2870: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 04/30] mfd: adp5520: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 05/30] mfd: max8925-i2c: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 06/30] mfd: mt6397-irq: " Paul Cercueil
2022-08-08 17:40   ` Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 07/30] mfd: pcf50633: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 08/30] mfd: rc5t583-irq: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 09/30] mfd: stpmic1: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 10/30] mfd: ucb1x00: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 11/30] mfd: 88pm860x: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 12/30] mfd: intel_soc_pmic: " Paul Cercueil
2022-08-23 14:17   ` Andy Shevchenko
2022-08-08 17:40 ` [PATCH v2 13/30] mfd: mcp-sa11x0: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 14/30] mfd: sec: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 15/30] mfd: sm501: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 16/30] mfd: tc6387xb: " Paul Cercueil
2022-08-08 17:40 ` Paul Cercueil [this message]
2022-08-08 17:40 ` [PATCH v2 18/30] mfd: wm8994: " Paul Cercueil
2022-08-22  9:43   ` Charles Keepax
2022-08-08 17:40 ` [PATCH v2 19/30] mfd: max77620: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 20/30] mfd: t7l66xb: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 21/30] mfd: arizona: " Paul Cercueil
2022-08-22  9:44   ` Charles Keepax
2022-08-08 17:40 ` [PATCH v2 22/30] mfd: max14577: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 23/30] mfd: max77686: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 24/30] mfd: motorola-cpcap: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 25/30] mfd: sprd-sc27xx: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 26/30] mfd: stmfx: " Paul Cercueil
2022-08-08 17:41   ` Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 27/30] mfd: stmpe: " Paul Cercueil
2022-08-08 17:41   ` Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 28/30] mfd: tc3589x: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 29/30] mfd: tc6393xb: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 30/30] mfd: intel-lpss: " Paul Cercueil
2022-08-13 14:50 ` [PATCH v2 00/30] mfd: Remove #ifdef guards for PM functions Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808174107.38676-18-paul@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.