All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	Paul Cercueil <paul@crapouillou.net>,
	patches@opensource.cirrus.com
Subject: [PATCH v2 18/30] mfd: wm8994: Remove #ifdef guards for PM related functions
Date: Mon,  8 Aug 2022 19:40:55 +0200	[thread overview]
Message-ID: <20220808174107.38676-19-paul@crapouillou.net> (raw)
In-Reply-To: <20220808174107.38676-1-paul@crapouillou.net>

Use the new RUNTIME_PM_OPS() and pm_ptr() macros to handle the
.runtime_suspend/.runtime_resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_PM is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Note that this driver should probably use the new
DEFINE_RUNTIME_DEV_PM_OPS() macro instead, which will provide
.suspend/.resume callbacks, pointing to pm_runtime_force_suspend() and
pm_runtime_force_resume() respectively; unless those callbacks really
aren't needed.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
Cc: patches@opensource.cirrus.com

 drivers/mfd/wm8994-core.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
index 7b1d270722ba..a27a13b5ae1e 100644
--- a/drivers/mfd/wm8994-core.c
+++ b/drivers/mfd/wm8994-core.c
@@ -110,7 +110,6 @@ static const char *wm8958_main_supplies[] = {
 	"SPKVDD2",
 };
 
-#ifdef CONFIG_PM
 static int wm8994_suspend(struct device *dev)
 {
 	struct wm8994 *wm8994 = dev_get_drvdata(dev);
@@ -213,7 +212,6 @@ static int wm8994_resume(struct device *dev)
 
 	return ret;
 }
-#endif
 
 #ifdef CONFIG_REGULATOR
 static int wm8994_ldo_in_use(struct wm8994_pdata *pdata, int ldo)
@@ -676,13 +674,13 @@ static const struct i2c_device_id wm8994_i2c_id[] = {
 MODULE_DEVICE_TABLE(i2c, wm8994_i2c_id);
 
 static const struct dev_pm_ops wm8994_pm_ops = {
-	SET_RUNTIME_PM_OPS(wm8994_suspend, wm8994_resume, NULL)
+	RUNTIME_PM_OPS(wm8994_suspend, wm8994_resume, NULL)
 };
 
 static struct i2c_driver wm8994_i2c_driver = {
 	.driver = {
 		.name = "wm8994",
-		.pm = &wm8994_pm_ops,
+		.pm = pm_ptr(&wm8994_pm_ops),
 		.of_match_table = wm8994_of_match,
 	},
 	.probe = wm8994_i2c_probe,
-- 
2.35.1


  parent reply	other threads:[~2022-08-08 17:45 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 17:40 [PATCH v2 00/30] mfd: Remove #ifdef guards for PM functions Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 01/30] pm: Improve EXPORT_*_DEV_PM_OPS macros Paul Cercueil
2022-08-13 14:49   ` Jonathan Cameron
2022-08-23 17:47   ` Rafael J. Wysocki
2022-08-25 22:42     ` Paul Cercueil
2022-09-25 14:52       ` Jonathan Cameron
2022-09-26 12:00         ` Rafael J. Wysocki
2022-09-26 13:27           ` Paul Cercueil
2022-09-26 13:35             ` Rafael J. Wysocki
2022-10-01 17:01               ` Jonathan Cameron
2022-10-02 11:18                 ` Paul Cercueil
2022-10-04 18:54                   ` Rafael J. Wysocki
2022-10-04 19:12                     ` Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 02/30] mfd: 88pm80x: Remove #ifdef guards for PM related functions Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 03/30] mfd: aat2870: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 04/30] mfd: adp5520: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 05/30] mfd: max8925-i2c: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 06/30] mfd: mt6397-irq: " Paul Cercueil
2022-08-08 17:40   ` Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 07/30] mfd: pcf50633: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 08/30] mfd: rc5t583-irq: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 09/30] mfd: stpmic1: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 10/30] mfd: ucb1x00: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 11/30] mfd: 88pm860x: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 12/30] mfd: intel_soc_pmic: " Paul Cercueil
2022-08-23 14:17   ` Andy Shevchenko
2022-08-08 17:40 ` [PATCH v2 13/30] mfd: mcp-sa11x0: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 14/30] mfd: sec: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 15/30] mfd: sm501: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 16/30] mfd: tc6387xb: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 17/30] mfd: tps6586x: " Paul Cercueil
2022-08-08 17:40 ` Paul Cercueil [this message]
2022-08-22  9:43   ` [PATCH v2 18/30] mfd: wm8994: " Charles Keepax
2022-08-08 17:40 ` [PATCH v2 19/30] mfd: max77620: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 20/30] mfd: t7l66xb: " Paul Cercueil
2022-08-08 17:40 ` [PATCH v2 21/30] mfd: arizona: " Paul Cercueil
2022-08-22  9:44   ` Charles Keepax
2022-08-08 17:40 ` [PATCH v2 22/30] mfd: max14577: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 23/30] mfd: max77686: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 24/30] mfd: motorola-cpcap: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 25/30] mfd: sprd-sc27xx: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 26/30] mfd: stmfx: " Paul Cercueil
2022-08-08 17:41   ` Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 27/30] mfd: stmpe: " Paul Cercueil
2022-08-08 17:41   ` Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 28/30] mfd: tc3589x: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 29/30] mfd: tc6393xb: " Paul Cercueil
2022-08-08 17:41 ` [PATCH v2 30/30] mfd: intel-lpss: " Paul Cercueil
2022-08-13 14:50 ` [PATCH v2 00/30] mfd: Remove #ifdef guards for PM functions Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808174107.38676-19-paul@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.