All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: bvanassche@acm.org, linux-block@vger.kernel.org,
	dm-devel@redhat.com, snitzer@kernel.org, axboe@kernel.dk,
	hch@lst.de, linux-nvme@lists.infradead.org,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH v2 01/20] block: Add PR callouts for read keys and reservation
Date: Mon,  8 Aug 2022 19:04:00 -0500	[thread overview]
Message-ID: <20220809000419.10674-2-michael.christie@oracle.com> (raw)
In-Reply-To: <20220809000419.10674-1-michael.christie@oracle.com>

Add callouts for reading keys and reservations. This allows LIO to support
the READ_KEYS and READ_RESERVATION commands and will allow dm-multipath
to optimize it's error handling so it can check if it's getting an error
because there's an existing reservation or if we need to retry different
paths.

Note: This only initially adds the struct definitions in the kernel as I'm
not sure if we wanted to export the interface to userspace yet. read_keys
and read_reservation are exactly what dm-multipath and LIO need, but for a
userspace interface we may want something like SCSI's READ_FULL_STATUS and
NVMe's report reservation commands. Those are overkill for dm/LIO and
READ_FULL_STATUS is sometimes broken for SCSI devices.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 include/linux/pr.h | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/include/linux/pr.h b/include/linux/pr.h
index 94ceec713afe..79b3d2853a20 100644
--- a/include/linux/pr.h
+++ b/include/linux/pr.h
@@ -4,6 +4,18 @@
 
 #include <uapi/linux/pr.h>
 
+struct pr_keys {
+	u32	generation;
+	u32	num_keys;
+	u64	keys[];
+};
+
+struct pr_held_reservation {
+	u64	key;
+	u32	type;
+	u32	generation;
+};
+
 struct pr_ops {
 	int (*pr_register)(struct block_device *bdev, u64 old_key, u64 new_key,
 			u32 flags);
@@ -14,6 +26,18 @@ struct pr_ops {
 	int (*pr_preempt)(struct block_device *bdev, u64 old_key, u64 new_key,
 			enum pr_type type, bool abort);
 	int (*pr_clear)(struct block_device *bdev, u64 key);
+	/*
+	 * pr_read_keys - Read the registered keys and return them in the
+	 * pr_keys->keys array. The keys array will have been allocated at the
+	 * end of the pr_keys struct and is keys_len bytes. If there are more
+	 * keys than can fit in the array, success will still be returned and
+	 * pr_keys->num_keys will reflect the total number of keys the device
+	 * contains, so the caller can retry with a larger array.
+	 */
+	int (*pr_read_keys)(struct block_device *bdev,
+			struct pr_keys *keys_info, u32 keys_len);
+	int (*pr_read_reservation)(struct block_device *bdev,
+			struct pr_held_reservation *rsv);
 };
 
 #endif /* LINUX_PR_H */
-- 
2.18.2


WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michael.christie@oracle.com>
To: bvanassche@acm.org, linux-block@vger.kernel.org,
	dm-devel@redhat.com, snitzer@kernel.org, axboe@kernel.dk,
	hch@lst.de, linux-nvme@lists.infradead.org,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [dm-devel] [PATCH v2 01/20] block: Add PR callouts for read keys and reservation
Date: Mon,  8 Aug 2022 19:04:00 -0500	[thread overview]
Message-ID: <20220809000419.10674-2-michael.christie@oracle.com> (raw)
In-Reply-To: <20220809000419.10674-1-michael.christie@oracle.com>

Add callouts for reading keys and reservations. This allows LIO to support
the READ_KEYS and READ_RESERVATION commands and will allow dm-multipath
to optimize it's error handling so it can check if it's getting an error
because there's an existing reservation or if we need to retry different
paths.

Note: This only initially adds the struct definitions in the kernel as I'm
not sure if we wanted to export the interface to userspace yet. read_keys
and read_reservation are exactly what dm-multipath and LIO need, but for a
userspace interface we may want something like SCSI's READ_FULL_STATUS and
NVMe's report reservation commands. Those are overkill for dm/LIO and
READ_FULL_STATUS is sometimes broken for SCSI devices.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 include/linux/pr.h | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/include/linux/pr.h b/include/linux/pr.h
index 94ceec713afe..79b3d2853a20 100644
--- a/include/linux/pr.h
+++ b/include/linux/pr.h
@@ -4,6 +4,18 @@
 
 #include <uapi/linux/pr.h>
 
+struct pr_keys {
+	u32	generation;
+	u32	num_keys;
+	u64	keys[];
+};
+
+struct pr_held_reservation {
+	u64	key;
+	u32	type;
+	u32	generation;
+};
+
 struct pr_ops {
 	int (*pr_register)(struct block_device *bdev, u64 old_key, u64 new_key,
 			u32 flags);
@@ -14,6 +26,18 @@ struct pr_ops {
 	int (*pr_preempt)(struct block_device *bdev, u64 old_key, u64 new_key,
 			enum pr_type type, bool abort);
 	int (*pr_clear)(struct block_device *bdev, u64 key);
+	/*
+	 * pr_read_keys - Read the registered keys and return them in the
+	 * pr_keys->keys array. The keys array will have been allocated at the
+	 * end of the pr_keys struct and is keys_len bytes. If there are more
+	 * keys than can fit in the array, success will still be returned and
+	 * pr_keys->num_keys will reflect the total number of keys the device
+	 * contains, so the caller can retry with a larger array.
+	 */
+	int (*pr_read_keys)(struct block_device *bdev,
+			struct pr_keys *keys_info, u32 keys_len);
+	int (*pr_read_reservation)(struct block_device *bdev,
+			struct pr_held_reservation *rsv);
 };
 
 #endif /* LINUX_PR_H */
-- 
2.18.2

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2022-08-09  0:04 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  0:03 [PATCH 0/20] Use block pr_ops in LIO Mike Christie
2022-08-09  0:03 ` [dm-devel] " Mike Christie
2022-08-09  0:04 ` Mike Christie [this message]
2022-08-09  0:04   ` [dm-devel] [PATCH v2 01/20] block: Add PR callouts for read keys and reservation Mike Christie
2022-08-09  0:04 ` [PATCH v2 02/20] scsi: Rename sd_pr_command Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09 19:22   ` Bart Van Assche
2022-08-09 19:22     ` [dm-devel] " Bart Van Assche
2022-08-09  0:04 ` [PATCH v2 03/20] scsi: Move sd_pr_type to header to share Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  0:04 ` [PATCH v2 04/20] scsi: Add support for block PR read keys/reservation Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09 19:26   ` Bart Van Assche
2022-08-09 19:26     ` [dm-devel] " Bart Van Assche
2022-08-10  3:28     ` Mike Christie
2022-08-10  3:28       ` [dm-devel] " Mike Christie
2022-08-09  0:04 ` [PATCH v2 05/20] dm: " Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  0:04 ` [PATCH v2 06/20] nvme: Fix reservation status related structs Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  7:19   ` Christoph Hellwig
2022-08-09  7:19     ` [dm-devel] " Christoph Hellwig
2022-08-09 11:09     ` Chaitanya Kulkarni
2022-08-09 11:09       ` [dm-devel] " Chaitanya Kulkarni
2022-08-09  0:04 ` [PATCH v2 07/20] nvme: Don't hardcode the data len for pr commands Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  7:19   ` Christoph Hellwig
2022-08-09  7:19     ` [dm-devel] " Christoph Hellwig
2022-08-09  0:04 ` [PATCH v2 08/20] nvme: Add helper to convert to a pr_ops PR type Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  7:20   ` Christoph Hellwig
2022-08-09  7:20     ` [dm-devel] " Christoph Hellwig
2022-08-09 11:12   ` Chaitanya Kulkarni
2022-08-09 11:12     ` [dm-devel] " Chaitanya Kulkarni
2022-08-09  0:04 ` [PATCH v2 09/20] nvme: Add helper to execute Reservation Report Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09 10:55   ` Chaitanya Kulkarni
2022-08-09 10:55     ` [dm-devel] " Chaitanya Kulkarni
2022-08-09 16:18     ` Mike Christie
2022-08-09 16:18       ` [dm-devel] " Mike Christie
2022-08-09 10:56   ` Chaitanya Kulkarni
2022-08-09 10:56     ` [dm-devel] " Chaitanya Kulkarni
2022-08-09 14:51     ` Keith Busch
2022-08-09 14:51       ` [dm-devel] " Keith Busch
2022-08-09 16:21       ` Mike Christie
2022-08-09 16:21         ` [dm-devel] " Mike Christie
2022-08-10  1:45         ` Chaitanya Kulkarni
2022-08-10  1:45           ` [dm-devel] " Chaitanya Kulkarni
2022-08-10  3:17           ` Keith Busch
2022-08-10  3:17             ` [dm-devel] " Keith Busch
2022-08-10  4:54             ` Chaitanya Kulkarni
2022-08-10  4:54               ` [dm-devel] " Chaitanya Kulkarni
2022-08-09  0:04 ` [PATCH v2 10/20] nvme: Add pr_ops read_keys support Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  0:04 ` [PATCH v2 11/20] nvme: Add pr_ops read_reservation support Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  0:04 ` [PATCH v2 12/20] block,nvme,scsi,dm: Add blk_status to pr_ops callouts Mike Christie
2022-08-09  0:04   ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Mike Christie
2022-08-09  7:21   ` [PATCH v2 12/20] block,nvme,scsi,dm: " Christoph Hellwig
2022-08-09  7:21     ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Christoph Hellwig
2022-08-09 18:08     ` [PATCH v2 12/20] block,nvme,scsi,dm: " Mike Christie
2022-08-09 18:08       ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Mike Christie
2022-08-09 19:33       ` [PATCH v2 12/20] block,nvme,scsi,dm: " Bart Van Assche
2022-08-09 19:33         ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Bart Van Assche
2022-08-10  3:34         ` [PATCH v2 12/20] block,nvme,scsi,dm: " Mike Christie
2022-08-10  3:34           ` [dm-devel] [PATCH v2 12/20] block, nvme, scsi, dm: " Mike Christie
2022-08-09  0:04 ` [PATCH v2 13/20] nvme: Have nvme pr_ops return a blk_status_t Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09 10:58   ` Chaitanya Kulkarni
2022-08-09 10:58     ` [dm-devel] " Chaitanya Kulkarni
2022-08-09  0:04 ` [PATCH v2 14/20] scsi: Retry pr_ops commands if a UA is returned Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  7:16   ` Christoph Hellwig
2022-08-09  7:16     ` [dm-devel] " Christoph Hellwig
2022-08-09 16:24     ` Mike Christie
2022-08-09 16:24       ` [dm-devel] " Mike Christie
2022-08-09 19:31       ` Bart Van Assche
2022-08-09 19:31         ` [dm-devel] " Bart Van Assche
2022-08-09  0:04 ` [PATCH v2 15/20] scsi: Export scsi_result_to_blk_status Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  0:04 ` [PATCH v2 16/20] scsi: Have sd pr_ops return a blk_status_t Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  7:18   ` Christoph Hellwig
2022-08-09  7:18     ` [dm-devel] " Christoph Hellwig
2022-08-09 16:22     ` Mike Christie
2022-08-09 16:22       ` [dm-devel] " Mike Christie
2022-08-09  0:04 ` [PATCH v2 17/20] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie
2022-08-09  0:04 ` [dm-devel] [PATCH v2 18/20] scsi: target: Allow backends to hook into PR handling Mike Christie
2022-08-09  0:04   ` Mike Christie
2022-08-09  0:04 ` [dm-devel] [PATCH v2 19/20] scsi: target: Don't support SCSI-2 RESERVE/RELEASE Mike Christie
2022-08-09  0:04   ` Mike Christie
2022-08-09  0:04 ` [PATCH v2 20/20] scsi: target: Add block PR support to iblock Mike Christie
2022-08-09  0:04   ` [dm-devel] " Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220809000419.10674-2-michael.christie@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.