All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Grzeschik <mgr@pengutronix.de>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] media: hantro: Add support for RK356x JPEG encoder
Date: Tue, 9 Aug 2022 14:45:08 +0200	[thread overview]
Message-ID: <20220809124508.GL14307@pengutronix.de> (raw)
In-Reply-To: <20220427224438.335327-3-frattaroli.nicolas@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

Hi Nicolas,

On Thu, Apr 28, 2022 at 12:44:37AM +0200, Nicolas Frattaroli wrote:
>The RK3566 and RK3568 SoCs come with a small Hantro instance which
>is solely dedicated to encoding JPEG. This patch adds the necessary
>structs to the Hantro driver to allow it to function.
>
>Tested with the following GStreamer command:
>
>gst-launch-1.0 videotestsrc ! v4l2jpegenc ! matroskamux ! \
>               filesink location=foo.mkv

I just tried this pipeline on v5.19. The filesize generated is increasing and
data is generated. However the content seems to be unusable.

When playing foo.mkv with e.g. vlc the following errors, that no JPEG data was found
in the images, is generated:


[mjpeg @ 0x7f2f08c1f780] No JPEG data found in image
[mjpeg @ 0x7f2f08c1f780] No JPEG data found in image
[mjpeg @ 0x7f2f08c1f780] No JPEG data found in image
...


The same with gstreamer:

gst-launch-1.0 filesrc location=foo.mkv ! decodebin ! glimagesink
../ext/jpeg/gstjpegdec.c(1418): gst_jpeg_dec_handle_frame (): /GstPipeline:pipeline0/GstDecodeBin:decodebin0/GstJpegDec:jpegdec0:
Decode error #53: Not a JPEG file: starts with 0x00 0x00
..


Do you have an idea why that is? Did you test the pipeline with an earlier
kernelversion and validated the generated content of foo.mkv?

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Michael Grzeschik <mgr@pengutronix.de>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] media: hantro: Add support for RK356x JPEG encoder
Date: Tue, 9 Aug 2022 14:45:08 +0200	[thread overview]
Message-ID: <20220809124508.GL14307@pengutronix.de> (raw)
In-Reply-To: <20220427224438.335327-3-frattaroli.nicolas@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1636 bytes --]

Hi Nicolas,

On Thu, Apr 28, 2022 at 12:44:37AM +0200, Nicolas Frattaroli wrote:
>The RK3566 and RK3568 SoCs come with a small Hantro instance which
>is solely dedicated to encoding JPEG. This patch adds the necessary
>structs to the Hantro driver to allow it to function.
>
>Tested with the following GStreamer command:
>
>gst-launch-1.0 videotestsrc ! v4l2jpegenc ! matroskamux ! \
>               filesink location=foo.mkv

I just tried this pipeline on v5.19. The filesize generated is increasing and
data is generated. However the content seems to be unusable.

When playing foo.mkv with e.g. vlc the following errors, that no JPEG data was found
in the images, is generated:


[mjpeg @ 0x7f2f08c1f780] No JPEG data found in image
[mjpeg @ 0x7f2f08c1f780] No JPEG data found in image
[mjpeg @ 0x7f2f08c1f780] No JPEG data found in image
...


The same with gstreamer:

gst-launch-1.0 filesrc location=foo.mkv ! decodebin ! glimagesink
../ext/jpeg/gstjpegdec.c(1418): gst_jpeg_dec_handle_frame (): /GstPipeline:pipeline0/GstDecodeBin:decodebin0/GstJpegDec:jpegdec0:
Decode error #53: Not a JPEG file: starts with 0x00 0x00
..


Do you have an idea why that is? Did you test the pipeline with an earlier
kernelversion and validated the generated content of foo.mkv?

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Michael Grzeschik <mgr@pengutronix.de>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] media: hantro: Add support for RK356x JPEG encoder
Date: Tue, 9 Aug 2022 14:45:08 +0200	[thread overview]
Message-ID: <20220809124508.GL14307@pengutronix.de> (raw)
In-Reply-To: <20220427224438.335327-3-frattaroli.nicolas@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1636 bytes --]

Hi Nicolas,

On Thu, Apr 28, 2022 at 12:44:37AM +0200, Nicolas Frattaroli wrote:
>The RK3566 and RK3568 SoCs come with a small Hantro instance which
>is solely dedicated to encoding JPEG. This patch adds the necessary
>structs to the Hantro driver to allow it to function.
>
>Tested with the following GStreamer command:
>
>gst-launch-1.0 videotestsrc ! v4l2jpegenc ! matroskamux ! \
>               filesink location=foo.mkv

I just tried this pipeline on v5.19. The filesize generated is increasing and
data is generated. However the content seems to be unusable.

When playing foo.mkv with e.g. vlc the following errors, that no JPEG data was found
in the images, is generated:


[mjpeg @ 0x7f2f08c1f780] No JPEG data found in image
[mjpeg @ 0x7f2f08c1f780] No JPEG data found in image
[mjpeg @ 0x7f2f08c1f780] No JPEG data found in image
...


The same with gstreamer:

gst-launch-1.0 filesrc location=foo.mkv ! decodebin ! glimagesink
../ext/jpeg/gstjpegdec.c(1418): gst_jpeg_dec_handle_frame (): /GstPipeline:pipeline0/GstDecodeBin:decodebin0/GstJpegDec:jpegdec0:
Decode error #53: Not a JPEG file: starts with 0x00 0x00
..


Do you have an idea why that is? Did you test the pipeline with an earlier
kernelversion and validated the generated content of foo.mkv?

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-09 12:45 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 22:44 [PATCH 0/3] Enable JPEG Encoder on RK3566/RK3568 Nicolas Frattaroli
2022-04-27 22:44 ` Nicolas Frattaroli
2022-04-27 22:44 ` Nicolas Frattaroli
2022-04-27 22:44 ` [PATCH 1/3] dt-bindings: media: rockchip-vpu: Add RK3568 JPEG compatible Nicolas Frattaroli
2022-04-27 22:44   ` Nicolas Frattaroli
2022-04-27 22:44   ` Nicolas Frattaroli
2022-05-04 20:23   ` Rob Herring
2022-05-04 20:23     ` Rob Herring
2022-05-04 20:23     ` Rob Herring
2022-04-27 22:44 ` [PATCH 2/3] media: hantro: Add support for RK356x JPEG encoder Nicolas Frattaroli
2022-04-27 22:44   ` Nicolas Frattaroli
2022-04-27 22:44   ` Nicolas Frattaroli
2022-08-09 12:45   ` Michael Grzeschik [this message]
2022-08-09 12:45     ` Michael Grzeschik
2022-08-09 12:45     ` Michael Grzeschik
2022-08-09 18:43     ` Michael Grzeschik
2022-08-09 18:43       ` Michael Grzeschik
2022-08-09 18:43       ` Michael Grzeschik
2022-04-27 22:44 ` [PATCH 3/3] arm64: dts: rockchip: Add JPEG encoder node to rk356x Nicolas Frattaroli
2022-04-27 22:44   ` Nicolas Frattaroli
2022-04-27 22:44   ` Nicolas Frattaroli
2022-04-29 14:46 ` [PATCH 0/3] Enable JPEG Encoder on RK3566/RK3568 Nicolas Dufresne
2022-04-29 14:46   ` Nicolas Dufresne
2022-04-29 14:46   ` Nicolas Dufresne
2022-04-29 15:28   ` Nicolas Frattaroli
2022-04-29 15:28     ` Nicolas Frattaroli
2022-04-29 15:28     ` Nicolas Frattaroli
2022-04-29 23:20     ` Michael Grzeschik
2022-04-29 23:20       ` Michael Grzeschik
2022-04-29 23:20       ` Michael Grzeschik
2022-05-02 12:20       ` Nicolas Dufresne
2022-05-02 12:20         ` Nicolas Dufresne
2022-05-02 12:20         ` Nicolas Dufresne
2022-06-20 13:40         ` Michael Grzeschik
2022-06-20 13:40           ` Michael Grzeschik
2022-06-20 13:40           ` Michael Grzeschik
2022-06-21 14:44           ` Nicolas Dufresne
2022-06-21 14:44             ` Nicolas Dufresne
2022-06-21 14:44             ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220809124508.GL14307@pengutronix.de \
    --to=mgr@pengutronix.de \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=frattaroli.nicolas@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.