[PATCH] thermal/core: Add missing EXPORT_SYMBOL_GPL

[PATCH] thermal/core: Add missing EXPORT_SYMBOL_GPL

[Daniel Lezcano]

The function thermal_zone_device_register_with_trips() is not exported
for modules.

Add the missing EXPORT_SYMBOL_GPL().

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/thermal_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index b4c68410c158..10c979dce512 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1329,6 +1329,7 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
 	kfree(tz);
 	return ERR_PTR(result);
 }
+EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
 
 struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
 							 void *devdata, struct thermal_zone_device_ops *ops,
-- 
2.34.1

Re: [PATCH] thermal/core: Add missing EXPORT_SYMBOL_GPL

[Rafael J. Wysocki]

On Wed, Aug 10, 2022 at 12:07 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> The function thermal_zone_device_register_with_trips() is not exported
> for modules.
>
> Add the missing EXPORT_SYMBOL_GPL().
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

A Fixes tag missing?

> ---
>  drivers/thermal/thermal_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index b4c68410c158..10c979dce512 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1329,6 +1329,7 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
>         kfree(tz);
>         return ERR_PTR(result);
>  }
> +EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
>
>  struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
>                                                          void *devdata, struct thermal_zone_device_ops *ops,
> --
> 2.34.1
>

Re: [PATCH] thermal/core: Add missing EXPORT_SYMBOL_GPL

[Daniel Lezcano]

On 10/08/2022 13:58, Rafael J. Wysocki wrote:
> On Wed, Aug 10, 2022 at 12:07 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> The function thermal_zone_device_register_with_trips() is not exported
>> for modules.
>>
>> Add the missing EXPORT_SYMBOL_GPL().
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> 
> A Fixes tag missing?

He he :) Indeed ...


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] thermal/core: Add missing EXPORT_SYMBOL_GPL

[Daniel Lezcano]

On 10/08/2022 13:58, Rafael J. Wysocki wrote:
> On Wed, Aug 10, 2022 at 12:07 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>>
>> The function thermal_zone_device_register_with_trips() is not exported
>> for modules.
>>
>> Add the missing EXPORT_SYMBOL_GPL().
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> 
> A Fixes tag missing?

I've added the missing tag in the thermal/linux-next branch

https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/commit/?h=thermal/linux-next&id=78ad78d78b43538e6dcbce3fd0699f15b79cfe3f

> 
>> ---
>>   drivers/thermal/thermal_core.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
>> index b4c68410c158..10c979dce512 100644
>> --- a/drivers/thermal/thermal_core.c
>> +++ b/drivers/thermal/thermal_core.c
>> @@ -1329,6 +1329,7 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
>>          kfree(tz);
>>          return ERR_PTR(result);
>>   }
>> +EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
>>
>>   struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
>>                                                           void *devdata, struct thermal_zone_device_ops *ops,
>> --
>> 2.34.1
>>


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[thermal: thermal/fixes] thermal/core: Add missing EXPORT_SYMBOL_GPL

[thermal-bot for Daniel Lezcano]

The following commit has been merged into the thermal/fixes branch of thermal:

Commit-ID:     a921be53b46c393d8d594a62a44f418c97e5504b
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//a921be53b46c393d8d594a62a44f418c97e5504b
Author:        Daniel Lezcano <daniel.lezcano@linaro.org>
AuthorDate:    Wed, 10 Aug 2022 12:07:31 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 15 Aug 2022 20:38:19 +02:00

thermal/core: Add missing EXPORT_SYMBOL_GPL

The function thermal_zone_device_register_with_trips() is not exported
for modules.

Add the missing EXPORT_SYMBOL_GPL().

Fixes: fae11de507f0e ("thermal/core: Add thermal_trip in thermal_zone")
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20220810100731.749317-1-daniel.lezcano@linaro.org
---
 drivers/thermal/thermal_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 6a5d0ae..50d50ce 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1329,6 +1329,7 @@ free_tz:
 	kfree(tz);
 	return ERR_PTR(result);
 }
+EXPORT_SYMBOL_GPL(thermal_zone_device_register_with_trips);
 
 struct thermal_zone_device *thermal_zone_device_register(const char *type, int ntrips, int mask,
 							 void *devdata, struct thermal_zone_device_ops *ops,