From: Andrew Jones <andrew.jones@linux.dev> To: Ricardo Koller <ricarkol@google.com> Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, maz@kernel.org, alexandru.elisei@arm.com, eric.auger@redhat.com, oliver.upton@linux.dev, reijiw@google.com Subject: Re: [kvm-unit-tests PATCH v3 2/3] arm: pmu: Reset the pmu registers before starting some tests Date: Thu, 11 Aug 2022 09:04:05 +0200 [thread overview] Message-ID: <20220811070405.ivo5w2mliwi4cpqk@kamzik> (raw) In-Reply-To: <YvRARgEDkSI1ken5@google.com> On Wed, Aug 10, 2022 at 04:33:26PM -0700, Ricardo Koller wrote: > On Wed, Aug 10, 2022 at 09:02:16PM +0200, Andrew Jones wrote: > > On Thu, Aug 04, 2022 at 05:41:38PM -0700, Ricardo Koller wrote: > > > Some registers like the PMOVS reset to an architecturally UNKNOWN value. > > > Most tests expect them to be reset (mostly zeroed) using pmu_reset(). > > > Add a pmu_reset() on all the tests that need one. > > > > > > As a bonus, fix a couple of comments related to the register state > > > before a sub-test. > > > > > > Reviewed-by: Eric Auger <eric.auger@redhat.com> > > > Signed-off-by: Ricardo Koller <ricarkol@google.com> > > > --- > > > arm/pmu.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/arm/pmu.c b/arm/pmu.c > > > index 4c601b05..12e7d84e 100644 > > > --- a/arm/pmu.c > > > +++ b/arm/pmu.c > > > @@ -826,7 +826,7 @@ static void test_overflow_interrupt(void) > > > write_regn_el0(pmevcntr, 1, PRE_OVERFLOW); > > > isb(); > > > > > > - /* interrupts are disabled */ > > > + /* interrupts are disabled (PMINTENSET_EL1 == 0) */ > > > > > > mem_access_loop(addr, 200, pmu.pmcr_ro | PMU_PMCR_E); > > > report(expect_interrupts(0), "no overflow interrupt after preset"); > > > @@ -842,7 +842,7 @@ static void test_overflow_interrupt(void) > > > isb(); > > > report(expect_interrupts(0), "no overflow interrupt after counting"); > > > > > > - /* enable interrupts */ > > > + /* enable interrupts (PMINTENSET_EL1 <= ALL_SET) */ > > > > > > pmu_reset_stats(); > > > > > > @@ -890,6 +890,7 @@ static bool check_cycles_increase(void) > > > bool success = true; > > > > > > /* init before event access, this test only cares about cycle count */ > > > + pmu_reset(); > > > > This and the other pmu_reset() call below break compilation on 32-bit arm, > > because there's no pmu_reset() defined for it. > I completely missed the 32-bit arm case. Thanks! > > > It'd probably be best if > > we actually implemented some sort of reset for arm, considering it's being > > called in common tests. > > Mind if I start by creating a pmu_reset() for 32-bit arm, which can > later be used by a general arm_reset()? No need to worry about a general one. We just need a pmu_reset implemented for 32-bit arm up in its #ifdef __arm__ section. Thanks, drew > > > > > Thanks, > > drew > > > > > set_pmcntenset(1 << PMU_CYCLE_IDX); > > > set_pmccfiltr(0); /* count cycles in EL0, EL1, but not EL2 */ > > > > > > @@ -944,6 +945,7 @@ static bool check_cpi(int cpi) > > > uint32_t pmcr = get_pmcr() | PMU_PMCR_LC | PMU_PMCR_C | PMU_PMCR_E; > > > > > > /* init before event access, this test only cares about cycle count */ > > > + pmu_reset(); > > > set_pmcntenset(1 << PMU_CYCLE_IDX); > > > set_pmccfiltr(0); /* count cycles in EL0, EL1, but not EL2 */ > > > > > > -- > > > 2.37.1.559.g78731f0fdb-goog > > >
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <andrew.jones@linux.dev> To: Ricardo Koller <ricarkol@google.com> Cc: kvm@vger.kernel.org, maz@kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [kvm-unit-tests PATCH v3 2/3] arm: pmu: Reset the pmu registers before starting some tests Date: Thu, 11 Aug 2022 09:04:05 +0200 [thread overview] Message-ID: <20220811070405.ivo5w2mliwi4cpqk@kamzik> (raw) In-Reply-To: <YvRARgEDkSI1ken5@google.com> On Wed, Aug 10, 2022 at 04:33:26PM -0700, Ricardo Koller wrote: > On Wed, Aug 10, 2022 at 09:02:16PM +0200, Andrew Jones wrote: > > On Thu, Aug 04, 2022 at 05:41:38PM -0700, Ricardo Koller wrote: > > > Some registers like the PMOVS reset to an architecturally UNKNOWN value. > > > Most tests expect them to be reset (mostly zeroed) using pmu_reset(). > > > Add a pmu_reset() on all the tests that need one. > > > > > > As a bonus, fix a couple of comments related to the register state > > > before a sub-test. > > > > > > Reviewed-by: Eric Auger <eric.auger@redhat.com> > > > Signed-off-by: Ricardo Koller <ricarkol@google.com> > > > --- > > > arm/pmu.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/arm/pmu.c b/arm/pmu.c > > > index 4c601b05..12e7d84e 100644 > > > --- a/arm/pmu.c > > > +++ b/arm/pmu.c > > > @@ -826,7 +826,7 @@ static void test_overflow_interrupt(void) > > > write_regn_el0(pmevcntr, 1, PRE_OVERFLOW); > > > isb(); > > > > > > - /* interrupts are disabled */ > > > + /* interrupts are disabled (PMINTENSET_EL1 == 0) */ > > > > > > mem_access_loop(addr, 200, pmu.pmcr_ro | PMU_PMCR_E); > > > report(expect_interrupts(0), "no overflow interrupt after preset"); > > > @@ -842,7 +842,7 @@ static void test_overflow_interrupt(void) > > > isb(); > > > report(expect_interrupts(0), "no overflow interrupt after counting"); > > > > > > - /* enable interrupts */ > > > + /* enable interrupts (PMINTENSET_EL1 <= ALL_SET) */ > > > > > > pmu_reset_stats(); > > > > > > @@ -890,6 +890,7 @@ static bool check_cycles_increase(void) > > > bool success = true; > > > > > > /* init before event access, this test only cares about cycle count */ > > > + pmu_reset(); > > > > This and the other pmu_reset() call below break compilation on 32-bit arm, > > because there's no pmu_reset() defined for it. > I completely missed the 32-bit arm case. Thanks! > > > It'd probably be best if > > we actually implemented some sort of reset for arm, considering it's being > > called in common tests. > > Mind if I start by creating a pmu_reset() for 32-bit arm, which can > later be used by a general arm_reset()? No need to worry about a general one. We just need a pmu_reset implemented for 32-bit arm up in its #ifdef __arm__ section. Thanks, drew > > > > > Thanks, > > drew > > > > > set_pmcntenset(1 << PMU_CYCLE_IDX); > > > set_pmccfiltr(0); /* count cycles in EL0, EL1, but not EL2 */ > > > > > > @@ -944,6 +945,7 @@ static bool check_cpi(int cpi) > > > uint32_t pmcr = get_pmcr() | PMU_PMCR_LC | PMU_PMCR_C | PMU_PMCR_E; > > > > > > /* init before event access, this test only cares about cycle count */ > > > + pmu_reset(); > > > set_pmcntenset(1 << PMU_CYCLE_IDX); > > > set_pmccfiltr(0); /* count cycles in EL0, EL1, but not EL2 */ > > > > > > -- > > > 2.37.1.559.g78731f0fdb-goog > > > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-08-11 7:04 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-05 0:41 [kvm-unit-tests PATCH v3 0/3] arm: pmu: Fixes for bare metal Ricardo Koller 2022-08-05 0:41 ` Ricardo Koller 2022-08-05 0:41 ` [kvm-unit-tests PATCH v3 1/3] arm: pmu: Add missing isb()'s after sys register writing Ricardo Koller 2022-08-05 0:41 ` Ricardo Koller 2022-08-09 15:21 ` Alexandru Elisei 2022-08-09 15:21 ` Alexandru Elisei 2022-08-05 0:41 ` [kvm-unit-tests PATCH v3 2/3] arm: pmu: Reset the pmu registers before starting some tests Ricardo Koller 2022-08-05 0:41 ` Ricardo Koller 2022-08-10 19:02 ` Andrew Jones 2022-08-10 19:02 ` Andrew Jones 2022-08-10 23:33 ` Ricardo Koller 2022-08-10 23:33 ` Ricardo Koller 2022-08-11 7:04 ` Andrew Jones [this message] 2022-08-11 7:04 ` Andrew Jones 2022-08-11 18:51 ` Ricardo Koller 2022-08-11 18:51 ` Ricardo Koller 2022-08-05 0:41 ` [kvm-unit-tests PATCH v3 3/3] arm: pmu: Check for overflow in the low counter in chained counters tests Ricardo Koller 2022-08-05 0:41 ` Ricardo Koller 2022-08-10 17:30 ` Oliver Upton 2022-08-10 17:30 ` Oliver Upton 2022-08-10 18:28 ` Andrew Jones 2022-08-10 18:28 ` Andrew Jones 2022-08-10 17:33 ` [kvm-unit-tests PATCH v3 0/3] arm: pmu: Fixes for bare metal Oliver Upton 2022-08-10 17:33 ` Oliver Upton 2022-10-04 16:20 ` Eric Auger 2022-10-04 16:20 ` Eric Auger 2022-10-04 16:58 ` Alexandru Elisei 2022-10-04 16:58 ` Alexandru Elisei 2022-10-04 17:31 ` Eric Auger 2022-10-04 17:31 ` Eric Auger 2022-10-05 9:21 ` Alexandru Elisei 2022-10-05 9:21 ` Alexandru Elisei 2022-10-05 9:41 ` Alexandru Elisei 2022-10-05 9:41 ` Alexandru Elisei 2022-10-05 9:51 ` Eric Auger 2022-10-05 9:51 ` Eric Auger 2022-10-05 9:50 ` Eric Auger 2022-10-05 9:50 ` Eric Auger 2022-10-06 9:25 ` Alexandru Elisei 2022-10-06 9:25 ` Alexandru Elisei 2022-10-11 3:50 ` Ricardo Koller 2022-10-11 3:50 ` Ricardo Koller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220811070405.ivo5w2mliwi4cpqk@kamzik \ --to=andrew.jones@linux.dev \ --cc=alexandru.elisei@arm.com \ --cc=eric.auger@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=maz@kernel.org \ --cc=oliver.upton@linux.dev \ --cc=reijiw@google.com \ --cc=ricarkol@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.