All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Raghav <p.raghav@samsung.com>
To: snitzer@kernel.org, axboe@kernel.dk, hch@lst.de, agk@redhat.com,
	damien.lemoal@opensource.wdc.com
Cc: linux-block@vger.kernel.org, Johannes.Thumshirn@wdc.com,
	bvanassche@acm.org, matias.bjorling@wdc.com, hare@suse.de,
	gost.dev@samsung.com, linux-nvme@lists.infradead.org,
	jaegeuk@kernel.org, pankydev8@gmail.com,
	linux-kernel@vger.kernel.org, dm-devel@redhat.com,
	Pankaj Raghav <p.raghav@samsung.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Adam Manzanares <a.manzanares@samsung.com>
Subject: [PATCH v10 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size
Date: Thu, 11 Aug 2022 16:30:31 +0200	[thread overview]
Message-ID: <20220811143043.126029-2-p.raghav@samsung.com> (raw)
In-Reply-To: <20220811143043.126029-1-p.raghav@samsung.com>

Adapt bdev_nr_zones and disk_zone_no functions so that they can
also work for non-power-of-2 zone sizes.

As the existing deployments assume that a device zone size is a power of
2 number of sectors, power-of-2 optimized calculation is used for those
devices.

There are no direct hot paths modified and the changes just
introduce one new branch per call.

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Adam Manzanares <a.manzanares@samsung.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
---
 block/blk-zoned.c      | 13 +++++++++----
 include/linux/blkdev.h |  8 +++++++-
 2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index a264621d4905..dce9c95b4bcd 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -111,17 +111,22 @@ EXPORT_SYMBOL_GPL(__blk_req_zone_write_unlock);
  * bdev_nr_zones - Get number of zones
  * @bdev:	Target device
  *
- * Return the total number of zones of a zoned block device.  For a block
- * device without zone capabilities, the number of zones is always 0.
+ * Return the total number of zones of a zoned block device, including the
+ * eventual small last zone if present. For a block device without zone
+ * capabilities, the number of zones is always 0.
  */
 unsigned int bdev_nr_zones(struct block_device *bdev)
 {
 	sector_t zone_sectors = bdev_zone_sectors(bdev);
+	sector_t capacity = bdev_nr_sectors(bdev);
 
 	if (!bdev_is_zoned(bdev))
 		return 0;
-	return (bdev_nr_sectors(bdev) + zone_sectors - 1) >>
-		ilog2(zone_sectors);
+
+	if (is_power_of_2(zone_sectors))
+		return (capacity + zone_sectors - 1) >> ilog2(zone_sectors);
+
+	return DIV_ROUND_UP_SECTOR_T(capacity, zone_sectors);
 }
 EXPORT_SYMBOL_GPL(bdev_nr_zones);
 
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 84b13fdd34a7..ab82d1ff0cce 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -674,9 +674,15 @@ static inline unsigned int disk_nr_zones(struct gendisk *disk)
 
 static inline unsigned int disk_zone_no(struct gendisk *disk, sector_t sector)
 {
+	sector_t zone_sectors = disk->queue->limits.chunk_sectors;
+
 	if (!blk_queue_is_zoned(disk->queue))
 		return 0;
-	return sector >> ilog2(disk->queue->limits.chunk_sectors);
+
+	if (is_power_of_2(zone_sectors))
+		return sector >> ilog2(zone_sectors);
+
+	return div64_u64(sector, zone_sectors);
 }
 
 static inline bool disk_zone_is_seq(struct gendisk *disk, sector_t sector)
-- 
2.25.1


  parent reply	other threads:[~2022-08-11 14:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220811143044eucas1p2cb35a5c247788689aeebf2bc8eb9f5df@eucas1p2.samsung.com>
2022-08-11 14:30 ` [PATCH v10 00/13] support zoned block devices with non-power-of-2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220811143045eucas1p2773a7e7bbe9f3667d1105cc1465dac42@eucas1p2.samsung.com>
2022-08-11 14:30     ` Pankaj Raghav [this message]
     [not found]   ` <CGME20220811143046eucas1p2e49a778cff29476c7ebaef1d1c67d86c@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} helpers in blkdev.h Pankaj Raghav
2022-08-11 20:21       ` Damien Le Moal
     [not found]   ` <CGME20220811143048eucas1p10e3ae3ef0c93228e9598e1a1a613f6e1@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
     [not found]   ` <CGME20220811143049eucas1p141d029f2efd6703b596bbea71ab69204@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220811143050eucas1p12321909b1b7f94182708b935b35e4ff9@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-08-16 21:14       ` Keith Busch
2022-08-17  7:28         ` Pankaj Raghav
     [not found]   ` <CGME20220811143051eucas1p24c16e378cd8080b0b22f5fb4d7659cf0@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220811143052eucas1p1426fad3e5fd52fb93243e5daaf06ce7d@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 07/13] zonefs: allow non power of 2 zoned devices Pankaj Raghav
     [not found]   ` <CGME20220811143053eucas1p2eda49423b8f18ef71c47583af4855f6b@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
     [not found]   ` <CGME20220811143054eucas1p219e5b31b24cca97e2bc563351436543d@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
     [not found]   ` <CGME20220811143055eucas1p2211be7f9ed867e40df58c25e6222be2d@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220811143056eucas1p13136f35c6f0c7c2717b68a63c8d4c7c6@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices Pankaj Raghav
     [not found]   ` <CGME20220811143057eucas1p1210aba036ebd96d290d74bfe0231299c@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 12/13] dm: introduce DM_EMULATED_ZONES target type Pankaj Raghav
     [not found]   ` <CGME20220811143058eucas1p247291685ffff7a75186947fd30b5c13f@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-11 16:15       ` Damien Le Moal
2022-08-12  7:25         ` Pankaj Raghav
2022-08-12 12:03       ` Joel Granados
2022-08-12 15:57       ` Damien Le Moal
2022-08-15 13:38         ` Pankaj Raghav
2022-08-15 18:56           ` Damien Le Moal
2022-08-16  8:02             ` Pankaj Raghav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811143043.126029-2-p.raghav@samsung.com \
    --to=p.raghav@samsung.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=a.manzanares@samsung.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=matias.bjorling@wdc.com \
    --cc=mcgrof@kernel.org \
    --cc=pankydev8@gmail.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.