All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Raghav <p.raghav@samsung.com>
To: snitzer@kernel.org, axboe@kernel.dk, hch@lst.de, agk@redhat.com,
	damien.lemoal@opensource.wdc.com
Cc: linux-block@vger.kernel.org, Johannes.Thumshirn@wdc.com,
	bvanassche@acm.org, matias.bjorling@wdc.com, hare@suse.de,
	gost.dev@samsung.com, linux-nvme@lists.infradead.org,
	jaegeuk@kernel.org, pankydev8@gmail.com,
	linux-kernel@vger.kernel.org, dm-devel@redhat.com,
	Luis Chamberlain <mcgrof@kernel.org>,
	Pankaj Raghav <p.raghav@samsung.com>
Subject: [PATCH v10 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed
Date: Thu, 11 Aug 2022 16:30:38 +0200	[thread overview]
Message-ID: <20220811143043.126029-9-p.raghav@samsung.com> (raw)
In-Reply-To: <20220811143043.126029-1-p.raghav@samsung.com>

From: Luis Chamberlain <mcgrof@kernel.org>

dm-zoned relies on the assumption that the zone size is a
power-of-2(po2) and the zone capacity is same as the zone size.

Ensure only po2 devices can be used as dm-zoned target until a native
support for zoned devices with non-po2 zone size is added.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
 drivers/md/dm-zoned-target.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
index 95b132b52f33..9325bf5dee81 100644
--- a/drivers/md/dm-zoned-target.c
+++ b/drivers/md/dm-zoned-target.c
@@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti)
 				return -EINVAL;
 			}
 			zone_nr_sectors = bdev_zone_sectors(bdev);
+			if (!is_power_of_2(zone_nr_sectors)) {
+				ti->error = "Zone size is not a power-of-2 number of sectors";
+				return -EINVAL;
+			}
 			zoned_dev->zone_nr_sectors = zone_nr_sectors;
 			zoned_dev->nr_zones = bdev_nr_zones(bdev);
 		}
@@ -804,6 +808,10 @@ static int dmz_fixup_devices(struct dm_target *ti)
 			return -EINVAL;
 		}
 		zoned_dev->zone_nr_sectors = bdev_zone_sectors(bdev);
+		if (!is_power_of_2(zoned_dev->zone_nr_sectors)) {
+			ti->error = "Zone size is not a power-of-2 number of sectors";
+			return -EINVAL;
+		}
 		zoned_dev->nr_zones = bdev_nr_zones(bdev);
 	}
 
-- 
2.25.1


  parent reply	other threads:[~2022-08-11 14:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220811143044eucas1p2cb35a5c247788689aeebf2bc8eb9f5df@eucas1p2.samsung.com>
2022-08-11 14:30 ` [PATCH v10 00/13] support zoned block devices with non-power-of-2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220811143045eucas1p2773a7e7bbe9f3667d1105cc1465dac42@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size Pankaj Raghav
     [not found]   ` <CGME20220811143046eucas1p2e49a778cff29476c7ebaef1d1c67d86c@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} helpers in blkdev.h Pankaj Raghav
2022-08-11 20:21       ` Damien Le Moal
     [not found]   ` <CGME20220811143048eucas1p10e3ae3ef0c93228e9598e1a1a613f6e1@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
     [not found]   ` <CGME20220811143049eucas1p141d029f2efd6703b596bbea71ab69204@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220811143050eucas1p12321909b1b7f94182708b935b35e4ff9@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-08-16 21:14       ` Keith Busch
2022-08-17  7:28         ` Pankaj Raghav
     [not found]   ` <CGME20220811143051eucas1p24c16e378cd8080b0b22f5fb4d7659cf0@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220811143052eucas1p1426fad3e5fd52fb93243e5daaf06ce7d@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 07/13] zonefs: allow non power of 2 zoned devices Pankaj Raghav
     [not found]   ` <CGME20220811143053eucas1p2eda49423b8f18ef71c47583af4855f6b@eucas1p2.samsung.com>
2022-08-11 14:30     ` Pankaj Raghav [this message]
     [not found]   ` <CGME20220811143054eucas1p219e5b31b24cca97e2bc563351436543d@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
     [not found]   ` <CGME20220811143055eucas1p2211be7f9ed867e40df58c25e6222be2d@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220811143056eucas1p13136f35c6f0c7c2717b68a63c8d4c7c6@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices Pankaj Raghav
     [not found]   ` <CGME20220811143057eucas1p1210aba036ebd96d290d74bfe0231299c@eucas1p1.samsung.com>
2022-08-11 14:30     ` [PATCH v10 12/13] dm: introduce DM_EMULATED_ZONES target type Pankaj Raghav
     [not found]   ` <CGME20220811143058eucas1p247291685ffff7a75186947fd30b5c13f@eucas1p2.samsung.com>
2022-08-11 14:30     ` [PATCH v10 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-11 16:15       ` Damien Le Moal
2022-08-12  7:25         ` Pankaj Raghav
2022-08-12 12:03       ` Joel Granados
2022-08-12 15:57       ` Damien Le Moal
2022-08-15 13:38         ` Pankaj Raghav
2022-08-15 18:56           ` Damien Le Moal
2022-08-16  8:02             ` Pankaj Raghav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811143043.126029-9-p.raghav@samsung.com \
    --to=p.raghav@samsung.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=matias.bjorling@wdc.com \
    --cc=mcgrof@kernel.org \
    --cc=pankydev8@gmail.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.