* [PATCH] hw/arm/bcm2835_property: Add support for RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS
@ 2022-08-12 14:35 Enrik Berkhan
2022-08-16 0:49 ` Philippe Mathieu-Daudé via
2022-08-23 21:45 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Enrik Berkhan @ 2022-08-12 14:35 UTC (permalink / raw)
To: qemu-arm
Cc: Peter Maydell, Philippe Mathieu-Daudé, qemu-devel, Enrik Berkhan
In more recent Raspbian OS Linux kernels, the fb driver gives up
immediately if RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS fails or no
displays are reported.
This change simply always reports one display. It makes bcm2835_fb work
again with these more recent kernels.
Signed-off-by: Enrik Berkhan <Enrik.Berkhan@inka.de>
---
hw/misc/bcm2835_property.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index e94e951057..890ae7bae5 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -270,6 +270,10 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
stl_le_phys(&s->dma_as, value + 12, 0);
resplen = 4;
break;
+ case 0x00040013: /* Get number of displays */
+ stl_le_phys(&s->dma_as, value + 12, 1);
+ resplen = 4;
+ break;
case 0x00060001: /* Get DMA channels */
/* channels 2-5 */
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/bcm2835_property: Add support for RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS
2022-08-12 14:35 [PATCH] hw/arm/bcm2835_property: Add support for RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS Enrik Berkhan
@ 2022-08-16 0:49 ` Philippe Mathieu-Daudé via
2022-08-23 21:45 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-08-16 0:49 UTC (permalink / raw)
To: Enrik Berkhan, qemu-arm; +Cc: Peter Maydell, qemu-devel
On 12/8/22 16:35, Enrik Berkhan wrote:
> In more recent Raspbian OS Linux kernels, the fb driver gives up
> immediately if RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS fails or no
> displays are reported.
>
> This change simply always reports one display. It makes bcm2835_fb work
> again with these more recent kernels.
>
> Signed-off-by: Enrik Berkhan <Enrik.Berkhan@inka.de>
> ---
> hw/misc/bcm2835_property.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
> index e94e951057..890ae7bae5 100644
> --- a/hw/misc/bcm2835_property.c
> +++ b/hw/misc/bcm2835_property.c
> @@ -270,6 +270,10 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
> stl_le_phys(&s->dma_as, value + 12, 0);
> resplen = 4;
> break;
> + case 0x00040013: /* Get number of displays */
> + stl_le_phys(&s->dma_as, value + 12, 1);
> + resplen = 4;
> + break;
>
> case 0x00060001: /* Get DMA channels */
> /* channels 2-5 */
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/bcm2835_property: Add support for RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS
2022-08-12 14:35 [PATCH] hw/arm/bcm2835_property: Add support for RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS Enrik Berkhan
2022-08-16 0:49 ` Philippe Mathieu-Daudé via
@ 2022-08-23 21:45 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2022-08-23 21:45 UTC (permalink / raw)
To: Enrik Berkhan, qemu-arm
Cc: Peter Maydell, Philippe Mathieu-Daudé, qemu-devel
On 8/12/22 07:35, Enrik Berkhan wrote:
> In more recent Raspbian OS Linux kernels, the fb driver gives up
> immediately if RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS fails or no
> displays are reported.
>
> This change simply always reports one display. It makes bcm2835_fb work
> again with these more recent kernels.
>
> Signed-off-by: Enrik Berkhan <Enrik.Berkhan@inka.de>
Thanks, queued to target-arm.next.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-23 21:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-12 14:35 [PATCH] hw/arm/bcm2835_property: Add support for RPI_FIRMWARE_FRAMEBUFFER_GET_NUM_DISPLAYS Enrik Berkhan
2022-08-16 0:49 ` Philippe Mathieu-Daudé via
2022-08-23 21:45 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.