* [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature
@ 2022-08-13 10:51 Thomas Petazzoni via buildroot
2022-08-13 21:43 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-08-13 10:51 UTC (permalink / raw)
To: Buildroot List; +Cc: Romain Naour, Giulio Benetti, Thomas Petazzoni
binutils 2.39 added support for gprofng, a new profiler (see
https://www.phoronix.com/news/GNU-Profiler-gprofng).
This new profiler is enabled by default, but it requires bison on the
host.
In order to handle this, this commit:
- Adds a new option BR2_BINUTILS_GPROFNG, which allows to
enable/disable gprofng in host-binutils
- Unconditionnally disables gprofng for the target binutils, based on
the idea that in a Buildroot context the analysis of profiling data
is generally done on the host system. This can of course always be
revisited later by adding a new option to the target binutils
package.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/binutils/Config.in.host | 6 ++++++
package/binutils/binutils.mk | 8 ++++++++
2 files changed, 14 insertions(+)
diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
index 907b63de13..51802db043 100644
--- a/package/binutils/Config.in.host
+++ b/package/binutils/Config.in.host
@@ -34,6 +34,12 @@ config BR2_BINUTILS_VERSION
default "2.38" if BR2_BINUTILS_VERSION_2_38_X
default "2.39" if BR2_BINUTILS_VERSION_2_39_X
+config BR2_BINUTILS_GPROFNG
+ bool "gprofng support"
+ depends on BR2_BINUTILS_VERSION_2_39_X
+ help
+ This option enables support for gprofng, a new profiler.
+
config BR2_BINUTILS_EXTRA_CONFIG_OPTIONS
string "Additional binutils options"
default ""
diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
index a3fece27dc..e4cb19896d 100644
--- a/package/binutils/binutils.mk
+++ b/package/binutils/binutils.mk
@@ -52,6 +52,7 @@ BINUTILS_CONF_OPTS = \
--enable-install-libiberty \
--enable-build-warnings=no \
--with-system-zlib \
+ --disable-gprofng \
$(BINUTILS_DISABLE_GDB_CONF_OPTS) \
$(BINUTILS_EXTRA_CONFIG_OPTIONS)
@@ -91,6 +92,13 @@ HOST_BINUTILS_CONF_OPTS = \
$(BINUTILS_DISABLE_GDB_CONF_OPTS) \
$(BINUTILS_EXTRA_CONFIG_OPTIONS)
+ifeq ($(BR2_BINUTILS_GPROFNG),y)
+HOST_BINUTILS_DEPENDENCIES += host-bison
+HOST_INBUTILS_CONF_OPTS += --enable-gprofng
+else
+HOST_INBUTILS_CONF_OPTS += --disable-gprofng
+endif
+
# binutils run configure script of subdirs at make time, so ensure
# our TARGET_CONFIGURE_ARGS are taken into consideration for those
BINUTILS_MAKE_ENV = $(TARGET_CONFIGURE_ARGS)
--
2.37.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature
2022-08-13 10:51 [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature Thomas Petazzoni via buildroot
@ 2022-08-13 21:43 ` Yann E. MORIN
2022-08-13 21:46 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2022-08-13 21:43 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Romain Naour, Giulio Benetti, Buildroot List
Thomas, All,
On 2022-08-13 12:51 +0200, Thomas Petazzoni via buildroot spake thusly:
> binutils 2.39 added support for gprofng, a new profiler (see
> https://www.phoronix.com/news/GNU-Profiler-gprofng).
>
> This new profiler is enabled by default, but it requires bison on the
> host.
>
> In order to handle this, this commit:
>
> - Adds a new option BR2_BINUTILS_GPROFNG, which allows to
> enable/disable gprofng in host-binutils
I was wondering if we should not just unconditionally build it. The
overhead of building host-bison and its dependencies is probably very
low when compared to the rest of the toolchain, especially with TLPB.
But OK, option it is...
> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> index a3fece27dc..e4cb19896d 100644
> --- a/package/binutils/binutils.mk
> +++ b/package/binutils/binutils.mk
[--SNIP--]
> @@ -91,6 +92,13 @@ HOST_BINUTILS_CONF_OPTS = \
> $(BINUTILS_DISABLE_GDB_CONF_OPTS) \
> $(BINUTILS_EXTRA_CONFIG_OPTIONS)
>
> +ifeq ($(BR2_BINUTILS_GPROFNG),y)
> +HOST_BINUTILS_DEPENDENCIES += host-bison
> +HOST_INBUTILS_CONF_OPTS += --enable-gprofng
> +else
> +HOST_INBUTILS_CONF_OPTS += --disable-gprofng
$ make check-package
package/binutils/binutils.mk:97: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*
package/binutils/binutils.mk:99: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*
Untested code? ;-)
Applied to next, with the above fixed, thanks.
Regards,
Yann E. MORIN.
> +endif
> +
> # binutils run configure script of subdirs at make time, so ensure
> # our TARGET_CONFIGURE_ARGS are taken into consideration for those
> BINUTILS_MAKE_ENV = $(TARGET_CONFIGURE_ARGS)
> --
> 2.37.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature
2022-08-13 21:43 ` Yann E. MORIN
@ 2022-08-13 21:46 ` Thomas Petazzoni via buildroot
2022-08-14 15:15 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-08-13 21:46 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Romain Naour, Giulio Benetti, Buildroot List
Hello,
On Sat, 13 Aug 2022 23:43:16 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > - Adds a new option BR2_BINUTILS_GPROFNG, which allows to
> > enable/disable gprofng in host-binutils
>
> I was wondering if we should not just unconditionally build it. The
> overhead of building host-bison and its dependencies is probably very
> low when compared to the rest of the toolchain, especially with TLPB.
>
> But OK, option it is...
Yes, I agree this question is relevant.
> > diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> > index a3fece27dc..e4cb19896d 100644
> > --- a/package/binutils/binutils.mk
> > +++ b/package/binutils/binutils.mk
> [--SNIP--]
> > @@ -91,6 +92,13 @@ HOST_BINUTILS_CONF_OPTS = \
> > $(BINUTILS_DISABLE_GDB_CONF_OPTS) \
> > $(BINUTILS_EXTRA_CONFIG_OPTIONS)
> >
> > +ifeq ($(BR2_BINUTILS_GPROFNG),y)
> > +HOST_BINUTILS_DEPENDENCIES += host-bison
> > +HOST_INBUTILS_CONF_OPTS += --enable-gprofng
> > +else
> > +HOST_INBUTILS_CONF_OPTS += --disable-gprofng
>
> $ make check-package
> package/binutils/binutils.mk:97: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*
> package/binutils/binutils.mk:99: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*
>
> Untested code? ;-)
Meh, weird, I definitely tested it: I got a build failure before, and
not after. Strange. Anyway, thanks for fixing and applying!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature
2022-08-13 21:46 ` Thomas Petazzoni via buildroot
@ 2022-08-14 15:15 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2022-08-14 15:15 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Romain Naour, Giulio Benetti, Buildroot List
On 2022-08-13 23:46 +0200, Thomas Petazzoni spake thusly:
> On Sat, 13 Aug 2022 23:43:16 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > $ make check-package
> > package/binutils/binutils.mk:97: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*
> > package/binutils/binutils.mk:99: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*
> Meh, weird, I definitely tested it: I got a build failure before, and
> not after. Strange. Anyway, thanks for fixing and applying!
Gah, I totally forgot to amend the commit before pushing. Grrr....
Fixed and pushed, now...
Damn, this heat-wave really had a toll on me... ;-]
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-14 15:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-13 10:51 [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature Thomas Petazzoni via buildroot
2022-08-13 21:43 ` Yann E. MORIN
2022-08-13 21:46 ` Thomas Petazzoni via buildroot
2022-08-14 15:15 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.