* [PATCH v2] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties
@ 2022-08-15 16:29 ` Stefan Binding
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Binding @ 2022-08-15 16:29 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-kernel, patches, Stefan Binding
For devices which use HID CSC3551, correct ACPI _DSD properties are
required to be able support those systems.
Add error message to clarify this.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
sound/pci/hda/cs35l41_hda.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index 129bffb431c2..15e2a0009080 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd
hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
hw_cfg->gpio1.valid = true;
} else {
+ /*
+ * Note: CLSA010(0/1) are special cases which use a slightly different design.
+ * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported.
+ */
+ dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %s.\n", hid);
hw_cfg->valid = false;
hw_cfg->gpio1.valid = false;
hw_cfg->gpio2.valid = false;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties
@ 2022-08-15 16:29 ` Stefan Binding
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Binding @ 2022-08-15 16:29 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: patches, alsa-devel, linux-kernel, Stefan Binding
For devices which use HID CSC3551, correct ACPI _DSD properties are
required to be able support those systems.
Add error message to clarify this.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
sound/pci/hda/cs35l41_hda.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index 129bffb431c2..15e2a0009080 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd
hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
hw_cfg->gpio1.valid = true;
} else {
+ /*
+ * Note: CLSA010(0/1) are special cases which use a slightly different design.
+ * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported.
+ */
+ dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %s.\n", hid);
hw_cfg->valid = false;
hw_cfg->gpio1.valid = false;
hw_cfg->gpio2.valid = false;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties
2022-08-15 16:29 ` Stefan Binding
@ 2022-08-16 13:13 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-08-16 13:13 UTC (permalink / raw)
To: Stefan Binding
Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel, patches
On Mon, 15 Aug 2022 18:29:06 +0200,
Stefan Binding wrote:
>
> For devices which use HID CSC3551, correct ACPI _DSD properties are
> required to be able support those systems.
> Add error message to clarify this.
>
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties
@ 2022-08-16 13:13 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-08-16 13:13 UTC (permalink / raw)
To: Stefan Binding; +Cc: linux-kernel, alsa-devel, patches, Takashi Iwai
On Mon, 15 Aug 2022 18:29:06 +0200,
Stefan Binding wrote:
>
> For devices which use HID CSC3551, correct ACPI _DSD properties are
> required to be able support those systems.
> Add error message to clarify this.
>
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-16 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 16:29 [PATCH v2] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties Stefan Binding
2022-08-15 16:29 ` Stefan Binding
2022-08-16 13:13 ` Takashi Iwai
2022-08-16 13:13 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.