All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: thomas.hellstrom@linux.intel.com, andi.shyti@linux.intel.com,
	jani.nikula@intel.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk,
	airlied@linux.ie, andrzej.hajda@intel.com,
	matthew.auld@intel.com, mchehab@kernel.org, nirmoy.das@intel.com
Subject: [PATCH v7 6/8] drm/i915: Check if the size is too big while creating shmem file
Date: Tue, 16 Aug 2022 18:35:23 +0900	[thread overview]
Message-ID: <20220816093525.184940-7-gwan-gyeong.mun@intel.com> (raw)
In-Reply-To: <20220816093525.184940-1-gwan-gyeong.mun@intel.com>

The __shmem_file_setup() function returns -EINVAL if size is greater than
MAX_LFS_FILESIZE. To handle the same error as other code that returns
-E2BIG when the size is too large, it add a code that returns -E2BIG when
the size is larger than the size that can be handled.

v4: If BITS_PER_LONG is 32, size > MAX_LFS_FILESIZE is always false, so it
    checks only when BITS_PER_LONG is 64.

Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index 4cb35808e431..4a7a6d65fc7a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -541,6 +541,20 @@ static int __create_shmem(struct drm_i915_private *i915,
 
 	drm_gem_private_object_init(&i915->drm, obj, size);
 
+	/* XXX: The __shmem_file_setup() function returns -EINVAL if size is
+	 * greater than MAX_LFS_FILESIZE.
+	 * To handle the same error as other code that returns -E2BIG when
+	 * the size is too large, we add a code that returns -E2BIG when the
+	 * size is larger than the size that can be handled.
+	 * If BITS_PER_LONG is 32, size > MAX_LFS_FILESIZE is always false,
+	 * so we only needs to check when BITS_PER_LONG is 64.
+	 * If BITS_PER_LONG is 32, E2BIG checks are processed when
+	 * i915_gem_object_size_2big() is called before init_object() callback
+	 * is called.
+	 */
+	if (BITS_PER_LONG == 64 && size > MAX_LFS_FILESIZE)
+		return -E2BIG;
+
 	if (i915->mm.gemfs)
 		filp = shmem_file_setup_with_mnt(i915->mm.gemfs, "i915", size,
 						 flags);
-- 
2.37.1


WARNING: multiple messages have this Message-ID (diff)
From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: thomas.hellstrom@linux.intel.com, jani.nikula@intel.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	chris@chris-wilson.co.uk, airlied@linux.ie,
	andrzej.hajda@intel.com, matthew.auld@intel.com, daniel@ffwll.ch,
	mchehab@kernel.org, nirmoy.das@intel.com
Subject: [Intel-gfx] [PATCH v7 6/8] drm/i915: Check if the size is too big while creating shmem file
Date: Tue, 16 Aug 2022 18:35:23 +0900	[thread overview]
Message-ID: <20220816093525.184940-7-gwan-gyeong.mun@intel.com> (raw)
In-Reply-To: <20220816093525.184940-1-gwan-gyeong.mun@intel.com>

The __shmem_file_setup() function returns -EINVAL if size is greater than
MAX_LFS_FILESIZE. To handle the same error as other code that returns
-E2BIG when the size is too large, it add a code that returns -E2BIG when
the size is larger than the size that can be handled.

v4: If BITS_PER_LONG is 32, size > MAX_LFS_FILESIZE is always false, so it
    checks only when BITS_PER_LONG is 64.

Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index 4cb35808e431..4a7a6d65fc7a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -541,6 +541,20 @@ static int __create_shmem(struct drm_i915_private *i915,
 
 	drm_gem_private_object_init(&i915->drm, obj, size);
 
+	/* XXX: The __shmem_file_setup() function returns -EINVAL if size is
+	 * greater than MAX_LFS_FILESIZE.
+	 * To handle the same error as other code that returns -E2BIG when
+	 * the size is too large, we add a code that returns -E2BIG when the
+	 * size is larger than the size that can be handled.
+	 * If BITS_PER_LONG is 32, size > MAX_LFS_FILESIZE is always false,
+	 * so we only needs to check when BITS_PER_LONG is 64.
+	 * If BITS_PER_LONG is 32, E2BIG checks are processed when
+	 * i915_gem_object_size_2big() is called before init_object() callback
+	 * is called.
+	 */
+	if (BITS_PER_LONG == 64 && size > MAX_LFS_FILESIZE)
+		return -E2BIG;
+
 	if (i915->mm.gemfs)
 		filp = shmem_file_setup_with_mnt(i915->mm.gemfs, "i915", size,
 						 flags);
-- 
2.37.1


WARNING: multiple messages have this Message-ID (diff)
From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	mchehab@kernel.org, chris@chris-wilson.co.uk,
	matthew.auld@intel.com, thomas.hellstrom@linux.intel.com,
	jani.nikula@intel.com, nirmoy.das@intel.com, airlied@linux.ie,
	daniel@ffwll.ch, andi.shyti@linux.intel.com,
	andrzej.hajda@intel.com
Subject: [PATCH v7 6/8] drm/i915: Check if the size is too big while creating shmem file
Date: Tue, 16 Aug 2022 18:35:23 +0900	[thread overview]
Message-ID: <20220816093525.184940-7-gwan-gyeong.mun@intel.com> (raw)
In-Reply-To: <20220816093525.184940-1-gwan-gyeong.mun@intel.com>

The __shmem_file_setup() function returns -EINVAL if size is greater than
MAX_LFS_FILESIZE. To handle the same error as other code that returns
-E2BIG when the size is too large, it add a code that returns -E2BIG when
the size is larger than the size that can be handled.

v4: If BITS_PER_LONG is 32, size > MAX_LFS_FILESIZE is always false, so it
    checks only when BITS_PER_LONG is 64.

Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index 4cb35808e431..4a7a6d65fc7a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -541,6 +541,20 @@ static int __create_shmem(struct drm_i915_private *i915,
 
 	drm_gem_private_object_init(&i915->drm, obj, size);
 
+	/* XXX: The __shmem_file_setup() function returns -EINVAL if size is
+	 * greater than MAX_LFS_FILESIZE.
+	 * To handle the same error as other code that returns -E2BIG when
+	 * the size is too large, we add a code that returns -E2BIG when the
+	 * size is larger than the size that can be handled.
+	 * If BITS_PER_LONG is 32, size > MAX_LFS_FILESIZE is always false,
+	 * so we only needs to check when BITS_PER_LONG is 64.
+	 * If BITS_PER_LONG is 32, E2BIG checks are processed when
+	 * i915_gem_object_size_2big() is called before init_object() callback
+	 * is called.
+	 */
+	if (BITS_PER_LONG == 64 && size > MAX_LFS_FILESIZE)
+		return -E2BIG;
+
 	if (i915->mm.gemfs)
 		filp = shmem_file_setup_with_mnt(i915->mm.gemfs, "i915", size,
 						 flags);
-- 
2.37.1


  parent reply	other threads:[~2022-08-16  9:37 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16  9:35 [PATCH v7 0/8] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation Gwan-gyeong Mun
2022-08-16  9:35 ` Gwan-gyeong Mun
2022-08-16  9:35 ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-16  9:35 ` [PATCH v7 1/8] overflow: Move and add few utility macros into overflow Gwan-gyeong Mun
2022-08-16  9:35   ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-16  9:35   ` Gwan-gyeong Mun
2022-08-17 23:07   ` Andi Shyti
2022-08-17 23:07     ` [Intel-gfx] " Andi Shyti
2022-08-17 23:07     ` Andi Shyti
2022-08-18  0:12     ` Kees Cook
2022-08-18  0:12       ` [Intel-gfx] " Kees Cook
2022-08-18  0:12       ` Kees Cook
2022-08-22 11:02       ` Jani Nikula
2022-08-22 11:02         ` [Intel-gfx] " Jani Nikula
2022-08-22 11:02         ` Jani Nikula
2022-08-22 14:05       ` Andrzej Hajda
2022-08-22 14:05         ` [Intel-gfx] " Andrzej Hajda
2022-08-22 14:05         ` Andrzej Hajda
2022-08-22 14:26         ` [Intel-gfx] " Andrzej Hajda
2022-08-22 14:26           ` Andrzej Hajda
2022-08-22 19:32         ` Gwan-gyeong Mun
2022-08-22 19:32           ` Gwan-gyeong Mun
2022-08-22 19:32           ` Gwan-gyeong Mun
2022-08-22 20:12           ` Kees Cook
2022-08-22 20:12             ` [Intel-gfx] " Kees Cook
2022-08-22 20:12             ` Kees Cook
2022-08-23  2:30             ` Gwan-gyeong Mun
2022-08-23  2:30               ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-23  2:30               ` Gwan-gyeong Mun
2022-08-16  9:35 ` [PATCH v7 2/8] util_macros: Add exact_type macro to catch type mis-match while compiling Gwan-gyeong Mun
2022-08-16  9:35   ` Gwan-gyeong Mun
2022-08-16  9:35   ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-16  9:35 ` [PATCH v7 3/8] drm/i915/gem: Typecheck page lookups Gwan-gyeong Mun
2022-08-16  9:35   ` Gwan-gyeong Mun
2022-08-16  9:35   ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-16  9:35 ` [PATCH v7 4/8] drm/i915: Check for integer truncation on scatterlist creation Gwan-gyeong Mun
2022-08-16  9:35   ` Gwan-gyeong Mun
2022-08-16  9:35   ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-16  9:35 ` [PATCH v7 5/8] drm/i915: Check for integer truncation on the configuration of ttm place Gwan-gyeong Mun
2022-08-16  9:35   ` Gwan-gyeong Mun
2022-08-16  9:35   ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-16  9:35 ` Gwan-gyeong Mun [this message]
2022-08-16  9:35   ` [PATCH v7 6/8] drm/i915: Check if the size is too big while creating shmem file Gwan-gyeong Mun
2022-08-16  9:35   ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-16  9:35 ` [PATCH v7 7/8] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large Gwan-gyeong Mun
2022-08-16  9:35   ` Gwan-gyeong Mun
2022-08-16  9:35   ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-16  9:35 ` [PATCH v7 8/8] drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun
2022-08-16  9:35   ` Gwan-gyeong Mun
2022-08-16  9:35   ` [Intel-gfx] " Gwan-gyeong Mun
2022-08-24 19:00 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation Patchwork
2022-08-24 19:00 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-08-24 19:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-26 14:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220816093525.184940-7-gwan-gyeong.mun@intel.com \
    --to=gwan-gyeong.mun@intel.com \
    --cc=airlied@linux.ie \
    --cc=andi.shyti@linux.intel.com \
    --cc=andrzej.hajda@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.auld@intel.com \
    --cc=mchehab@kernel.org \
    --cc=nirmoy.das@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.